From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0E23C36008 for ; Wed, 26 Mar 2025 09:41:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LWxx/jrpY6V+1XndVGlGtsX2gJfwN+bcofRIBcLEqv8=; b=QsbTTN5PBJaUEvvWXM3t+axjHJ /IqLQZOYYsB/B9KdcOsSaMOMUCk5jSYkF7/iU9vBfZRIqL4J3VD3hTsdsM80rOJ/b7zg7XmJQLtuX EL79bKj3Fw9/6EqHoMvBmAcd8av/HOLQxDVCk+IKbaSfOZY5N+ehCd024+y/9JDTyNNH3AYKbGMNI 7ligOZdxaKXxfRrfryMm+Rou5rxHSqZ/+UZVizBw0KJPEWHyEZOAM03K7ucl1b2YRjZoPJkMOyQhd THy8zKO77s5nVpowBXhBvdpbZGamRm7oCBLLRQ1U9la1lgPlaCx8+ArhoDUagKyhQK8CERX4zc7yY oxv5nb+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1txNG5-000000083aM-0iHf; Wed, 26 Mar 2025 09:41:13 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1txNEL-000000083QM-3sGx for linux-arm-kernel@lists.infradead.org; Wed, 26 Mar 2025 09:39:27 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 27BB043860; Wed, 26 Mar 2025 09:39:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58BCFC4CEEA; Wed, 26 Mar 2025 09:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742981965; bh=Mp7PS2Hsz1Y1++3pUe2iXl59mJgfLQOY3hRaKyxKOI4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ApaHC+Uf5A1ua9ePUD6nc+4eNxhxdmJH86reahFps3SZnbjkkcaDbtuuLG46Q2vwn 9p5C9lhcUgbVIhErca64F5Klq1j3vBjf3203GoyfTL/1Ro3RxORx4H5PUAFgz0CJXC wxcnse2vbdu3drRJT+Z0zstzCF+lYGNA9ZRRB9WCR7RMeTFQa0zpLwVoa5pGPS4v0O qDEgtHVffgkTlaXwitLFukstMZB7CmXrI4VU6YUTefSWl8J3+KbKaqMRbMeHp67iK6 D9VB2WjE1p5cAafC/2mhoTnozJlOzRP8luEoYrO4R4rHj9gFFHz8lVA3PTc1+23VCy 3TmocOn5qRnXw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1txNEJ-00HEb9-0v; Wed, 26 Mar 2025 09:39:23 +0000 Date: Wed, 26 Mar 2025 09:39:22 +0000 Message-ID: <86zfh8ku5x.wl-maz@kernel.org> From: Marc Zyngier To: Keir Fraser Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kristina Martsenko , Catalin Marinas , Mark Rutland , Will Deacon , stable@vger.kernel.org Subject: Re: [PATCH] arm64: mops: Do not dereference src reg for a set operation In-Reply-To: <20250326070255.2567981-1-keirf@google.com> References: <20250326070255.2567981-1-keirf@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: keirf@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kristina.martsenko@arm.com, catalin.marinas@arm.com, mark.rutland@arm.com, will@kernel.org, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250326_023925_999613_13F8B0DC X-CRM114-Status: GOOD ( 21.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 26 Mar 2025 07:02:55 +0000, Keir Fraser wrote: > > The register is not defined and reading it can result in a UBSAN > out-of-bounds array access error, specifically when the srcreg field > value is 31. Gah, XZR/SP encoding strikes back... > > Cc: Kristina Martsenko > Cc: Catalin Marinas > Cc: Mark Rutland > Cc: Will Deacon > Cc: Marc Zyngier > Cc: stable@vger.kernel.org > Signed-off-by: Keir Fraser > --- > arch/arm64/include/asm/traps.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/traps.h b/arch/arm64/include/asm/traps.h > index d780d1bd2eac..82cf1f879c61 100644 > --- a/arch/arm64/include/asm/traps.h > +++ b/arch/arm64/include/asm/traps.h > @@ -109,10 +109,9 @@ static inline void arm64_mops_reset_regs(struct user_pt_regs *regs, unsigned lon > int dstreg = ESR_ELx_MOPS_ISS_DESTREG(esr); > int srcreg = ESR_ELx_MOPS_ISS_SRCREG(esr); > int sizereg = ESR_ELx_MOPS_ISS_SIZEREG(esr); > - unsigned long dst, src, size; > + unsigned long dst, size; > > dst = regs->regs[dstreg]; > - src = regs->regs[srcreg]; > size = regs->regs[sizereg]; > > /* > @@ -129,6 +128,7 @@ static inline void arm64_mops_reset_regs(struct user_pt_regs *regs, unsigned lon > } > } else { > /* CPY* instruction */ > + unsigned long src = regs->regs[srcreg]; > if (!(option_a ^ wrong_option)) { > /* Format is from Option B */ > if (regs->pstate & PSR_N_BIT) { Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.