From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEE3BC3DA61 for ; Sat, 27 Jul 2024 09:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YPRLjzmrn6I+3/A+j5CO7JhseXcyM8XfzGX4qQ2e0NQ=; b=4/Qnk5yPIk1Hp7Vcdkrg0aBn1d ml8Z9k4/5xpkCnxS5kPNpnYriaMSIPgzWmJjegdYRvetojyIf37Su6Q+OAuhYAOOCujf596ieaovP jFcRfwFNe0KkK1LT5x06sZ1xVybL4JjEiNUiQyfOVNp7WhwQWIng3DENEEnEPdKOIgLmp5P777Bjg XiaVufBJnwNy5s1XkzuNZk0s2eIhxBsd8Wlc/Wl3xdonaQFv48Zb2IYARPBtiv0MCdhC5KW/fqfkl MpL4G1PQsJj1TXH4k/o4SQK/nI2bT16BrfB3w8Q4+IRq5ItmGWDCkm32rmZ7LQVbCRY6bxn3WMpaY qrhtgIfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXdvf-00000006QVi-3aip; Sat, 27 Jul 2024 09:41:31 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXdvF-00000006QP0-0QfJ for linux-arm-kernel@lists.infradead.org; Sat, 27 Jul 2024 09:41:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 18FE9CE0FB5; Sat, 27 Jul 2024 09:41:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68F58C32781; Sat, 27 Jul 2024 09:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722073262; bh=I/TrLaduxjdZgcj+s3Q1EQKZO7dhJ/hm+0Mp1b/lXD8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EAGXytKIMy1OL5Ao2jbeYdszsmAe+/+smN1ISQl7o7u52V01NYfG6GecmruIC4qDf ZqXY4bcrmv/N7MRIJI/Izwubd0jLmb8mUKRBQ2//L24bFQ4Rv7dO5Mvu865kpzvR9d KTuZGUgeJUBRqQpwEssKrljsOor2nl4uf5kuPuZcdAlgaDV8mBkgtM8zKIOew7WPrr TpVdiCqOUwGl7dl5LFYpW/jk3cPEzNWiNjjWocz1ePTyZptiHq2uINV//Twhx307+k QE0fE0VqWh0rennnicPwLYLElYdXf8nJhJ7dyDfbWPaILQP2QuktmhZ/mGWVlvK1vR Fb7j01TGJKIwQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sXdv9-00Fnz7-UZ; Sat, 27 Jul 2024 10:41:00 +0100 Date: Sat, 27 Jul 2024 10:40:59 +0100 Message-ID: <86zfq318b8.wl-maz@kernel.org> From: Marc Zyngier To: Jinjie Ruan Cc: , , , , , , Subject: Re: [PATCH] irqchip/gic-v3: Remove asmlinkage for gic_handle_irq() In-Reply-To: <861q3f2n4e.wl-maz@kernel.org> References: <20240727073648.1042377-1-ruanjinjie@huawei.com> <861q3f2n4e.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ruanjinjie@huawei.com, tglx@linutronix.de, joey.gouly@arm.com, mark.rutland@arm.com, will@kernel.org, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240727_024105_521921_CF16BE83 X-CRM114-Status: GOOD ( 21.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 27 Jul 2024 10:35:45 +0100, Marc Zyngier wrote: > > On Sat, 27 Jul 2024 08:36:48 +0100, > Jinjie Ruan wrote: > > > > Since commit 064dbfb41691 ("arm64: entry: convert IRQ+FIQ handlers to C"), > > the gic_handle_irq() is only called by C functions, so remove > > the asmlinkage. > > You clearly haven't looked very far. > > > > > Fixes: 064dbfb41691 ("arm64: entry: convert IRQ+FIQ handlers to C") > > Signed-off-by: Jinjie Ruan > > --- > > drivers/irqchip/irq-gic-v3.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > > index c19083bfb943..0efa3443c323 100644 > > --- a/drivers/irqchip/irq-gic-v3.c > > +++ b/drivers/irqchip/irq-gic-v3.c > > @@ -930,7 +930,7 @@ static void __gic_handle_irq_from_irqsoff(struct pt_regs *regs) > > __gic_handle_nmi(irqnr, regs); > > } > > > > -static asmlinkage void __exception_irq_entry gic_handle_irq(struct pt_regs *regs) > > +static void __exception_irq_entry gic_handle_irq(struct pt_regs *regs) > > { > > if (unlikely(gic_supports_nmi() && !interrupts_enabled(regs))) > > __gic_handle_irq_from_irqsoff(regs); > > $ git grep handle_arch_irq arch/arm/ > arch/arm/kernel/entry-armv.S: bl generic_handle_arch_irq > arch/arm/kernel/entry-armv.S: mov_l r0, generic_handle_arch_irq > > Until someone rewrites 32bit ARM to have all of its low-level > interrupt handling in C, this stays. This has no effect on arm64 > anyway. Scratch that, I misread it. We have an indirection, so this patch is fine. Apologies for the noise. M. -- Without deviation from the norm, progress is not possible.