From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95164CF9C69 for ; Wed, 25 Sep 2024 02:10:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lhT4emZQMu0iLsfja78mVDr5B3L8j965fQjbvHU4u9w=; b=4jFWq21xrDsA4V2qCeLe0jceul RIKlSMzfR6qdkx2de0JflOcEr+Zu3I45Cs8A9P31bRDVvqMKwH3ZshvpWifuE1XlrXbvD+GdESltY daGdlpZNTr/iv5wC6zn4VyOecHBZcHVv3mOaBHAQYWnVfuo3QeCHCG5VGqYLoln92owhQr6lxQmyH IOolvD9MP9XJq/ESQk9J+5rOiQ2Bt+7TQ32NqJoHDKzCJGyIqvmEcSpROiR8jIPzGWZTZReeHKOYc NaRzPiSRFL21lRvY3a7qx8vLGd+bFW8vIFH+IdscCKwn6Z2JUdRSNt70iu9ZA9EyEF0a2vp77GArF 8R4+RZwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stHUG-00000003nlc-2eJF; Wed, 25 Sep 2024 02:10:40 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stHT6-00000003ncB-1O0L; Wed, 25 Sep 2024 02:09:29 +0000 Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-2deec99c780so622347a91.2; Tue, 24 Sep 2024 19:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727230167; x=1727834967; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lhT4emZQMu0iLsfja78mVDr5B3L8j965fQjbvHU4u9w=; b=Vr8D37iQFZF5Khp+GkB0TxW2byB7i7W3MPY9IqIGrUxtob5rREf9NIPKYwFnnBxYhp CbDKiSldl8PklwGTJjGR/8R57Ova7/D/8GYhwZJHuaVxMr4Uhi7XeYdtcek6B6X/HpfR AKXZ3vybjopo0fxy4lQixhZNYrlj+4UMqoGm9O8WfSS35hR1+iOr+La09ay7Cb4UVwn2 o95xKhNKR8WtGwaISJ9nu9HUCBN9EGrWD6OTi5su1AVGu+ksiAB00/1W4H2tz8jVevpL TFY7tUr29+TfkopizJAvkRJ6Kb+zqQh5ijfiMMUXKE1WftNm81ZOi/vGgCceXMx3kHWv eY0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727230167; x=1727834967; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lhT4emZQMu0iLsfja78mVDr5B3L8j965fQjbvHU4u9w=; b=j9OnbqQzPrYKQq1oS8X04/NAWDJWJf6UKgfHzLBhu1cNQlNoghG1cTSN+Mr5jtHh3L LTJHx5jYIgbQ53vzlo63hpswJ8NY3RnG4gYsWrTxV3YUNmOFyvx1IrRya8iM8pW1UV16 rETJfXwT/Qxt4GhdjIc1i6Phnkze8IXkIVQDN6AYY/mCC4aci+3s00qSvBSLWYiaeFU7 rB74Brj9ZhORdA+JY4+MRvpIa8b2Y7zCHfPHZ06N+ixMGIWD2VmJ6dMbFE+P7VQjo0I3 +ZuNbLERQWdKDVBKUaPxuzsgaI1xdHQhxVtpQ8Pp4DzfqPxZe93PP5lOyTPo7xDNW7VL cOCw== X-Forwarded-Encrypted: i=1; AJvYcCUO/9VUCz97OElRt6RkTJmCKdp2iltyFLIqVIeVrrq3br7u1lJJxVbr8SpzYuAckLS+aSlpCaejy7bN@lists.infradead.org, AJvYcCWCID31Fq04TQ52hMutTtW+WQqi+3tK3UxQY2/uRLxMSMCAEIzscRrnrDv2hTgo7fbgLYHz/6k9zxW+F5JrdfU=@lists.infradead.org, AJvYcCXkaGSaB7+tZK7QsMj/N4obEQw48m9CcV8ubmoD7/At9VcmzvxuYoVgCcNYBfzTR3ZqJoBJkZdvTjhcq0GLbyG+@lists.infradead.org X-Gm-Message-State: AOJu0Yx847InzSxQrHhGwXdboxNGtL0WtRYyTwVcdKutpDLdjr/qFVlH 9+o4YAw+c+jQORw8W7oCIbX33oflUCxRwpQP3xVV/vxTKV7BTfumwFJAkh3D X-Google-Smtp-Source: AGHT+IEgOjNFa2IPtnydRtu4ja6d33MWXnvg3q5KwwfLA4hgKFc9OYCnHhghim3qoE66AaUQyL+GJA== X-Received: by 2002:a17:90b:3a86:b0:2db:60b:9be5 with SMTP id 98e67ed59e1d1-2e06affdd19mr597228a91.8.1727230167336; Tue, 24 Sep 2024 19:09:27 -0700 (PDT) Received: from [192.168.60.56] ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e06e1e6660sm287402a91.24.2024.09.24.19.09.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Sep 2024 19:09:27 -0700 (PDT) Message-ID: <87146372-6d05-4994-8f64-47f4cb07e2b4@gmail.com> Date: Wed, 25 Sep 2024 10:09:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3576 Content-Language: en-US To: Conor Dooley , krzk@kernel.org Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, william.wu@rock-chips.com, tim.chen@rock-chips.com, Frank Wang References: <20240924085510.20863-1-frawang.cn@gmail.com> <20240924-overtly-curable-13df2e7fdc9b@spud> From: Frank Wang In-Reply-To: <20240924-overtly-curable-13df2e7fdc9b@spud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240924_190928_393574_E8D4D75C X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Conor, On 2024/9/25 0:11, Conor Dooley wrote: > On Tue, Sep 24, 2024 at 04:55:09PM +0800, Frank Wang wrote: >> From: Frank Wang >> >> Add compatible for the USB2 phy in the Rockchip RK3576 SoC. >> >> Signed-off-by: Frank Wang >> --- >> Changelog: >> v2: >> - Categorize clock names by oneOf keyword. >> >> v1: >> - https://patchwork.kernel.org/project/linux-phy/patch/20240923025326.10467-1-frank.wang@rock-chips.com/ >> >> .../bindings/phy/rockchip,inno-usb2phy.yaml | 16 ++++++++++++++-- >> 1 file changed, 14 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml >> index 5254413137c64..8af4e0f8637fc 100644 >> --- a/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml >> +++ b/Documentation/devicetree/bindings/phy/rockchip,inno-usb2phy.yaml >> @@ -20,6 +20,7 @@ properties: >> - rockchip,rk3366-usb2phy >> - rockchip,rk3399-usb2phy >> - rockchip,rk3568-usb2phy >> + - rockchip,rk3576-usb2phy >> - rockchip,rk3588-usb2phy >> - rockchip,rv1108-usb2phy >> >> @@ -34,10 +35,20 @@ properties: >> const: 0 >> >> clocks: >> - maxItems: 1 >> + minItems: 1 >> + maxItems: 3 >> >> clock-names: >> - const: phyclk >> + minItems: 1 >> + maxItems: 3 > clock-names isn't a required property, you can't allow jumbling the order > like this does without breaking the ABI. Why can't the new device have > phyclk in position 1? I sent a draft changes in patch v1 comments which put the "phyclk" in position 1, Krzysztof said I have messed the order, so I reorder them in v2. Did I misunderstand? anyway, should the changes like the below? @@ -34,10 +35,20 @@ properties:       const: 0     clocks: -    maxItems: 1 +    minItems: 1 +    maxItems: 3     clock-names: -    const: phyclk +    minItems: 1 +    maxItems: 3 +    items: +      oneOf: +        - description: PHY input reference clocks. +          const: phyclk +        - description: aclk for USB MMU. +          const: aclk +        - description: aclk_slv for USB MMU. +          const: aclk_slv BR. Frank >> + items: >> + oneOf: >> + - description: aclk for USB MMU. >> + const: aclk >> + - description: aclk_slv for USB MMU. >> + const: aclk_slv >> + - description: PHY input reference clocks. >> + const: phyclk >> >> assigned-clocks: >> description: >> @@ -143,6 +154,7 @@ allOf: >> contains: >> enum: >> - rockchip,rk3568-usb2phy >> + - rockchip,rk3576-usb2phy >> - rockchip,rk3588-usb2phy >> >> then: >> -- >> 2.45.2 >>