From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87216C44508 for ; Wed, 15 Jul 2026 15:57:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XDk0Of4Ii82xYZ6joqOrrIwhzl5iv/e/NSKekosnOY0=; b=TWxx6E06JUP2Pu9KLOQvT13cfj oaZ+Q4P+QaLwXnecwNqUn/HVDDtL6s8IhntYQzmqPgV9ZnpWGCp5rWZ7AOuRpRXrKsc5UQPx2QoAy o8Ba0qzf+shpTPAen9cB8qeGBIeePqAs2/eLXWQePT0gtzXbTbvoKASBcx42xg0QcJzzVP0+NHDrx 7SDM+g304XZ1BGodgwACkex2IrFviBw6kqKTM8TJ3QsetO9Xp86b3iP+DQHcZyZwLjP7WCDNmLUia NvmCM9ygKC10NEC8BmP3KcE5RrCSACoPk39g3Xhvz7yngFcWCuqyYukfyEmOGsccD6oSzVf5j/o17 OnaKYKJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wk1zS-0000000FNiy-35Bu; Wed, 15 Jul 2026 15:57:42 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wk1zR-0000000FNiP-2bTj for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2026 15:57:41 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 092564039F; Wed, 15 Jul 2026 15:57:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DBC961F00A3A; Wed, 15 Jul 2026 15:57:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784131060; bh=XDk0Of4Ii82xYZ6joqOrrIwhzl5iv/e/NSKekosnOY0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=kwt0wudy3mYXXqfhCr12TM/l479wknYIrDYxMIkO9sP9BH3icQgfDObNvzDUNhVBR EycTqxzIw5coFW/yIfMyHtfMPvfHivYLxf9JECR4GgDzBRacoX+5l+o1xPFWycOBA1 nZVX80Z6WUud6jPDlk3CahjPIZdmxnM+4wQkvz0pM4EtPOMm0pm1lZYvre5SL+hndr cjLepI8IY/JT6yt+CJeWSPKhrcdjU+recDjPDZG1TCkSsFVAjfdB1mWD1lw5F1Eazv lfHXICV2wpdmX5Uw48OKCvGQ5hUiuCPnFlcHMNVZQkkmWcqveiwZSihRH9wVNI3DWg Ms+BlBkC8NakA== Received: from [194.56.92.2] (helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wk1zO-00000005Nsf-2dLH; Wed, 15 Jul 2026 15:57:38 +0000 Date: Wed, 15 Jul 2026 16:59:28 +0100 Message-ID: <871pd45jmn.wl-maz@kernel.org> From: Marc Zyngier To: Steven Price Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, Catalin Marinas , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" , Emi Kisanuki , Vishal Annapurve , WeiLin.Chang@arm.com, Lorenzo Pieralisi Subject: Re: [PATCH v15 02/37] KVM: arm64: Avoid including linux/kvm_host.h in kvm_pgtable.h In-Reply-To: <20260715142841.80544-3-steven.price@arm.com> References: <20260715142841.80544-1-steven.price@arm.com> <20260715142841.80544-3-steven.price@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 194.56.92.2 X-SA-Exim-Rcpt-To: steven.price@arm.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, oliver.upton@linux.dev, suzuki.poulose@arm.com, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, joey.gouly@arm.com, alexandru.elisei@arm.com, christoffer.dall@arm.com, tabba@google.com, linux-coco@lists.linux.dev, gankulkarni@os.amperecomputing.com, gshan@redhat.com, sdonthineni@nvidia.com, alpergun@google.com, aneesh.kumar@kernel.org, fj0570is@fujitsu.com, vannapurve@google.com, WeiLin.Chang@arm.com, lpieralisi@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 15 Jul 2026 15:28:04 +0100, Steven Price wrote: > > To avoid future include cycles, drop the linux/kvm_host.h include in > kvm_pgtable.h and include the lightweight headers required for the types and > inline helpers used there. Additionally provide a forward declaration for > struct kvm_s2_mmu as it's only used as a pointer in this file. > > Both pgtable.c and kvm_pkvm.h relied on the indirect inclusion of > kvm_host.h, so make that explicit. > > Signed-off-by: Steven Price > --- > New patch in v13 > --- > arch/arm64/include/asm/kvm_pgtable.h | 6 +++++- > arch/arm64/include/asm/kvm_pkvm.h | 2 +- > arch/arm64/kvm/hyp/pgtable.c | 1 + > 3 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h > index 41a8687938eb..c2e4b29e605f 100644 > --- a/arch/arm64/include/asm/kvm_pgtable.h > +++ b/arch/arm64/include/asm/kvm_pgtable.h > @@ -8,9 +8,13 @@ > #define __ARM64_KVM_PGTABLE_H__ > > #include > -#include > +#include > +#include > +#include > #include > > +struct kvm_s2_mmu; > + > #define KVM_PGTABLE_FIRST_LEVEL -1 > #define KVM_PGTABLE_LAST_LEVEL 3 > > diff --git a/arch/arm64/include/asm/kvm_pkvm.h b/arch/arm64/include/asm/kvm_pkvm.h > index 74fedd9c5ff0..a0f7a699d690 100644 > --- a/arch/arm64/include/asm/kvm_pkvm.h > +++ b/arch/arm64/include/asm/kvm_pkvm.h > @@ -9,7 +9,7 @@ > #include > #include > #include > -#include > +#include nit: please keep the include directives in alphabetical order. M. -- Jazz isn't dead. It just smells funny.