From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83841C3DA64 for ; Sun, 28 Jul 2024 21:42:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UJ8avubm+TshxAKGY+3dwML6RHR/hQP1VCu5ckxFM3c=; b=0EagN8mna7/+l3egvGFH3RGqGa 5OHsehl/ttQ4f4EH45dO7RwhSTkrMr+DQDrzFkuMhhW53S6k4Qe74MSOnS4AVPYVQBBe9DemtbtLO Y8DrSPWhHYZc/YEKzCn7jug6mfVhxryqYHHrvvK3uCPNsy4OVi0j8mGc2YSj8ECs42V5xZN93eKK2 iP88apTzOFvoQKC6MgCBQvPg+riLNyyG2E+Sn5KRiDc7Bm7FyN9qDAmVTDIeXdbF5pNBGwU7bDVSs wqOHH2vwAq0E5ojSzNVKKorJ4B7RyESwTjcWUrz4xETQUUyh1zqqSKs3xSXQI7UAzIaMRZcuoIaTa WpMs+ozA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYBeO-00000009HUy-1HLu; Sun, 28 Jul 2024 21:41:56 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYBdv-00000009HSW-3A6C for linux-arm-kernel@lists.infradead.org; Sun, 28 Jul 2024 21:41:31 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1722202885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UJ8avubm+TshxAKGY+3dwML6RHR/hQP1VCu5ckxFM3c=; b=ZBQ8USYZJ9eCgowXSSNIEGmd4/42zK7tooKTkGSAfo+pBukYZx/4rhip9zD57Vrm4P+H/h pjm/+D+GorXarDDSARcNVvsJfw8qPLBWACVLNr34A7MnJFai0ZPlOoq8M9l+MXFwUdDfYN xTDH8Fa7lwVWYd2U2ROmicdJeddKrN8hImJeF8/VXETGdubt2NF5XoYE5ZFAZTXZLBNP4+ fhUdJAwBnjr5zdSs9AjhDkxhgiRBBvjCbvLevUin4LuzbbL0AhLZs7A5UUUrLJv0CGhnqm JBhSZbdNXQg2nTlRLk1USQJp29qrzTc1RjRgDPZVkLnjXs3QWqvZZ6Xi8cNccQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1722202885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UJ8avubm+TshxAKGY+3dwML6RHR/hQP1VCu5ckxFM3c=; b=0Vw1Uv2k4wuFMuvbAjCkDLBzxFZP7Qh5yvUHOffL/4vkyVTfY2kFsWBt+5r/hGOMeOEfhl eJVkmUbTZu0GAECQ== To: Marek =?utf-8?Q?Beh=C3=BAn?= , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, arm@kernel.org, Andy Shevchenko , Hans de Goede , Ilpo =?utf-8?Q?J=C3=A4rvinen?= Cc: Marek =?utf-8?Q?Beh=C3=BAn?= Subject: Re: [PATCH 03/13] irqchip/armada-370-xp: Rename struct irq_domain variables for consistency In-Reply-To: <20240715105156.18388-4-kabel@kernel.org> References: <20240715105156.18388-1-kabel@kernel.org> <20240715105156.18388-4-kabel@kernel.org> Date: Sun, 28 Jul 2024 23:41:25 +0200 Message-ID: <871q3dtcsa.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240728_144127_957144_A3F49A1A X-CRM114-Status: UNSURE ( 8.06 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 15 2024 at 12:51, Marek Beh=C3=BAn wrote: > Rename struct irq_domain variables passed as arguments into callbacks to > "h", for consistency. The "d" name is reserved for irq_data, while > "domain" is unnecessarily long. 'domain' is way more descriptive than the pulled out of thin air 'h'. I'm not convinced about the value of this change. > for (unsigned int i =3D 0; i < nr_irqs; i++) > - irq_domain_set_info(domain, virq + i, hwirq + i, > + irq_domain_set_info(h, virq + i, hwirq + i, > &mpic_msi_bottom_irq_chip, > - domain->host_data, handle_simple_irq, > + h->host_data, handle_simple_irq, > NULL, NULL); Reducing the number of line breaks by utilizing the 100 character limit would be more valuable. =20=20 Thanks, tglx