From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 894A0C2BD09 for ; Wed, 3 Jul 2024 13:58:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XH6QO9JWwoOujTbpUhp4MtAndneXDiax3/mdKKqKVh8=; b=AX5yp5Gl/8IubfkMnqvU/8S6ma QkOHUp4cvaA3eHqbaqhcLRCXbDvaGJT9qlLfbPferG4Jdi/fBfK3yVxTQwURaPCDM07zLU4e4S+Fi qIa2DdIvgovQ+QYlNjvgDNqaR+xsFPJgYPrLRSEOr9jeYH4L12iC576BXfm1SRnc6q1lxanbWeEnw ooYnqOy5hyMGoKhIrYokB/XCLhSJr5JejcDPBzUlzRYaEAE9cVIN6i3q34cBTjaXxHoDloMU0XZwQ 55jNomBK/LUyxSK5bscEKEXs/knA1VGfl/qHt4iwtPqASshxnV+Hlqmp9q7ItfgcKIa+Gqxsqs1/Y ilnpAkZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sP0VD-0000000ANsB-310q; Wed, 03 Jul 2024 13:58:31 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sP0Uw-0000000ANlk-3KWI for linux-arm-kernel@lists.infradead.org; Wed, 03 Jul 2024 13:58:20 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1720015090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XH6QO9JWwoOujTbpUhp4MtAndneXDiax3/mdKKqKVh8=; b=H3Cm4nvH0sZJLdpeNsPM46kZmY+PMMqdr7J7bMPA/ljr0rKhMjs1LGw5SLeL/rDhvA1TvN WQWhsZNCHZoH5nJvFIPh8BOgNLAmvZFVi77QvgOmOsCupxFe/nyXHF9lc3L1TEx1PfBoIH gKA7sV7OqOT+noR5yEiGoETpiFs49i3Pa/EPiMWwq5mJ5uHDaaNekqQERaJvKNdRTwX6jo 7hDHi/3La0+pTTeSzfIGDcGRkG53LiJrq5/bHQMvW5DxFFTCGj5wdY+YnHy49Yj5JdfmsW D0PuRS8JRGUDL7OEUErKmVa4+CDaq52tnB80Ng/DFhqWtqpgenKHQ4uXe9j0sg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1720015090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XH6QO9JWwoOujTbpUhp4MtAndneXDiax3/mdKKqKVh8=; b=0eJG6eVhjeCS0NJ1TEK/AjCh1Xn0NeiVV0hoL31PGn+AusmRI46YQ6cVkkz5Kxtu+17MSc 37VDZxT9w+Q9+LBw== To: Lorenzo Pieralisi Cc: LKML , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, maz@kernel.org, anna-maria@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, bhelgaas@google.com, rdunlap@infradead.org, vidyas@nvidia.com, ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com, kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org, lorenzo.pieralisi@arm.com, jgg@mellanox.com, ammarfaizi2@gnuweeb.org, robin.murphy@arm.com, nm@ti.com, kristo@kernel.org, vkoul@kernel.org, okaya@kernel.org, agross@kernel.org, andersson@kernel.org, mark.rutland@arm.com, shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com, shivamurthy.shastri@linutronix.de Subject: Re: [patch V4 02/21] irqchip: Provide irq-msi-lib In-Reply-To: References: <20240623142137.448898081@linutronix.de> <20240623142234.840975799@linutronix.de> Date: Wed, 03 Jul 2024 15:57:48 +0200 Message-ID: <871q4ay3vn.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240703_065815_014552_92C95A1A X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 01 2024 at 12:18, Lorenzo Pieralisi wrote: > On Sun, Jun 23, 2024 at 05:18:34PM +0200, Thomas Gleixner wrote: >> +bool msi_lib_init_dev_msi_info(struct device *dev, struct irq_domain *domain, >> + struct irq_domain *real_parent, >> + struct msi_domain_info *info) >> +{ >> + const struct msi_parent_ops *pops = real_parent->msi_parent_ops; >> + >> + /* >> + * MSI parent domain specific settings. For now there is only the >> + * root parent domain, e.g. NEXUS, acting as a MSI parent, but it is >> + * possible to stack MSI parents. See x86 vector -> irq remapping >> + */ >> + if (domain->bus_token == pops->bus_select_token) { >> + if (WARN_ON_ONCE(domain != real_parent)) >> + return false; >> + } else { >> + WARN_ON_ONCE(1); >> + return false; >> + } >> + >> + /* Parent ops available? */ >> + if (WARN_ON_ONCE(!pops)) > > We have already dereferenced pops above, we should move this warning > before we dereference it (ie checked devmsi-arm-v4-2 too - branch same > comment applies there too). Oops. Yes.