From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D716C5478C for ; Mon, 26 Feb 2024 16:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zQOY/DILYYdBtMJfwa5Wp1otkJM4tSSbRi6UHw4a6Rc=; b=zBWGYF8i2kOvGh PujhHyvGM9nYoGeuC3IBekuf5IK4JQuDaXwVSzTtvsOV6nmTjUO76wZZkrrnr0GS+eOunDz9CdptB NuXbzLhfy/o4P0ZnHoCIviGQn2SD+8r4EE4KI0rGlSrQNuv8exkC4ZiYL6QlJcGA4kHzdwjx3iFSx HQvUcYS6/p5PXgX3NVhVuQ3M/XmBjwlFFYkDhaKqkzyO1p3xeosLVB6EveK8kaJnqLRz0tnq9wkns 81CiB7g2ZLUT8u8kbIyMGBJkoDxwax9aL0MPU7JZyXRfhOV2RSt3t3tf823zl1ZCLyuhnubaIuAHf PQTeTZBwrllF42XYtkrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1redPF-00000001Xxx-01TB; Mon, 26 Feb 2024 16:00:41 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1redOy-00000001Xn7-3Ycr for linux-arm-kernel@lists.infradead.org; Mon, 26 Feb 2024 16:00:30 +0000 From: Anna-Maria Behnsen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1708963220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WEmhdiiQQbTfuRjiNB7+533BTNvYbMz78iuKIE4w618=; b=dXqqfxIv9snhj53TLlWIoYnlfb2uv2KCZYP0gst5jHNgf+TacKXsogPHCK0T73IAZ2or8m mDl9B1Z2CIO6m3VBkrVk9rsBXShjB3YAx81XMe9dtHjB9BQ2sLlc2jecIjYL997IxLq87w axZ8ExqOBivLnwBmYIWlSqIN3D0WNBZQWQMGjx7iQFKMFWIq7xuhOSyytNkDBgdxqnqwgl nh+RcVDQj5yWCi0WWHXHl+CgH1h7pNfArIZTNpobXhZB9+8dwbqvhssq0J6auC7qEq+JgA 94qTo83w2ufuYAjAoexK1mQOX/9jFwFJ0gYZmBNDFttXxX7pSRFziG6AMNIX2g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1708963220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WEmhdiiQQbTfuRjiNB7+533BTNvYbMz78iuKIE4w618=; b=e36mqOQpOvMbmMukekA46dOhO4E6SSBBK1zQDxRVK/a9JFTFZjjmQuS0YAMjSr3HFeQd6B 3xS/EnFxXx+GZSDA== To: Arnd Bergmann , Naresh Kamboju , open list , lkft-triage@lists.linaro.org, Linux ARM , Thomas Gleixner , Vincenzo Frascino Cc: Ard Biesheuvel , Catalin Marinas , Kees Cook Subject: Re: arch/arm64/include/asm/atomic_ll_sc.h:298:9: error: unknown type name 'u128' In-Reply-To: <0fe0add2-6b17-441f-a0e1-7c1ee9b0ea71@app.fastmail.com> References: <0fe0add2-6b17-441f-a0e1-7c1ee9b0ea71@app.fastmail.com> Date: Mon, 26 Feb 2024 17:00:20 +0100 Message-ID: <871q8zkygb.fsf@somnus> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240226_080025_070268_FB5B5239 X-CRM114-Status: GOOD ( 15.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org "Arnd Bergmann" writes: > On Fri, Feb 23, 2024, at 10:10, Naresh Kamboju wrote: >> In file included from arch/arm64/include/asm/lse.h:5, >> from arch/arm64/include/asm/cmpxchg.h:14, >> from arch/arm64/include/asm/atomic.h:16, >> from include/linux/atomic.h:7, >> from include/asm-generic/bitops/atomic.h:5, >> from arch/arm64/include/asm/bitops.h:25, >> from include/linux/bitops.h:68, >> from arch/arm64/include/asm/memory.h:209, >> from arch/arm64/include/asm/page.h:46, >> from include/vdso/datapage.h:22, >> from lib/vdso/gettimeofday.c:5, >> >> from : >> arch/arm64/include/asm/atomic_ll_sc.h:298:9: error: unknown type name 'u128' >> 298 | u128 full; >> | ^~~~ >> arch/arm64/include/asm/atomic_ll_sc.h:305:24: error: unknown type name 'u128' >> 305 | static __always_inline u128 > > The problem here is the separation of vdso/*.h headers and > linux/*.h headers. > > Commit a0d2fcd62ac2 ("vdso/ARM: Make union vdso_data_store > available for all architectures") introduced a reference to > the asm/page.h in include/vdso/datapage.h, but this is outside > of the vdso/*.h namespace and doesn't work in the compat vdso. But the asm namespace works for the vdso namespace. Only linux headers do not work, or am I wrong? > I think it is only needed because of the PAGE_SIZE macro, > so that constant needs to come from somewhere else. Yes. > I have an older patch that I never merged to unify the > page size configuration in Kconfig, and could try to > dig that out if nobody has a better idea. If we do that, > we could introduce a CONFIG_PAGE_SIZE. PAGE_SIZE is defined in asm/page-def.h for arm64. So this could be a fast fix (tested with clang-14): ---8<---- --- a/include/vdso/datapage.h +++ b/include/vdso/datapage.h @@ -19,7 +19,11 @@ #include #include +#ifdef CONFIG_ARM64 +#include +#else #include +#endif #ifdef CONFIG_ARCH_HAS_VDSO_DATA #include ---8<--- Thanks, Anna-Maria _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel