From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D872CEEEC01 for ; Fri, 15 Sep 2023 19:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C/aL8u20/khnopIwRWFUCqgYWFT/Qj333Eywxx0OZAo=; b=q3xJyxQLnYqMKM lwbtw8LI2El4zm1NXEflGjg0wheLughkJoaUfWmWeX5ayuW30YOFcWogm3GFUJt+k4nJS2J8oUrdB Eb4AHOlYUo51tZTuM+idPl+iPQo3qxYki069pyFJClPkRxx3wWJtM+xu2UWZxNHjdMDxbgklTGAEO Vlhzr+377j4SiOa19BMOVqpm1yOwHj7ifOghQD71CP7HqY52B4I8yIuR8cPRUpt7Bx7EADqcNPgyF rlic9KbLHgBsePkmRb1mF/k0TFzA/+35IzA2lg2aPQ8GtijDPTL8AyPcDkBGq3SyGzLd+GIWo6WCj IGl00xHzsR8ipSWRiBRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qhEBo-00BF8W-1e; Fri, 15 Sep 2023 19:09:16 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qhEBl-00BF87-1A for linux-arm-kernel@lists.infradead.org; Fri, 15 Sep 2023 19:09:14 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1694804951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FDeIVKTICKDFwpeyMiKeUyQnaEhJj8v8RkRSMefmd/k=; b=AHhoxWCpLqkPmcYu/FFKkCMeN1qFRbSQa9NH06THW5izeby06dvSy8CbZpcnjAln4Y9CZW +YnMsh53yrTYClYKQ2Hlrn0ZSNZRO03YSPFHP9egzWgUldP072yO8kSidxwSx881SkmpUI WXQSiF4ghsDsnDK3I+JS2f6PtOSfiYMNOm2uhITtE8MThM7nvkwzC72foLGnqIHtnlRGbd 0LvoKP1quv4a9z6mNqyUp6kuXEDr8HOCl8BHHDMHIoBBrZmVE1EOziz2MKhGUvMTAAAxtA mKU2tks1Qp9J0F0oeB2aYYINw4fyoXMVhmUb4I0Hv6P2deRKSnEoNGyHY9QjaA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1694804951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FDeIVKTICKDFwpeyMiKeUyQnaEhJj8v8RkRSMefmd/k=; b=ijQ0D6WzikBWYrorxKopMvxIQLmVdcyirOD2bgrPoV6JiJG3+BsxpPmKRUZIYx+Nm78qDP WLkEpJeyJvydd7Bg== To: "Russell King (Oracle)" , linux-acpi@vger.kernel.org, James Morse Cc: loongarch@lists.linux.dev, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com, Borislav Petkov , Dave Hansen , Salil Mehta , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , linux-ia64@vger.kernel.org Subject: Re: [PATCH RFC v2] cpu-hotplug: provide prototypes for arch CPU registration In-Reply-To: References: Date: Fri, 15 Sep 2023 21:09:10 +0200 Message-ID: <871qez1cfd.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230915_120913_561077_DE1687D0 X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 14 2023 at 15:51, Russell King wrote: > Provide common prototypes for arch_register_cpu() and > arch_unregister_cpu(). These are called by acpi_processor.c, with > weak versions, so the prototype for this is already set. It is > generally not necessary for function prototypes to be conditional > on preprocessor macros. > > Some architectures (e.g. Loongarch) are missing the prototype for this, > and rather than add it to Loongarch's asm/cpu.h, lets do the job once > for everyone. > > Since this covers everyone, remove the now unnecessary prototypes in > asm/cpu.h, and we also need to remove the 'static' from one of ia64's > arch_register_cpu() definitions. > > Signed-off-by: Russell King (Oracle) > --- > Spotted during the review of James Morse's patches, I think rather than > adding prototypes for loongarch to its asm/cpu.h, it would make more > sense to provide the prototypes in a non-arch specific header file so > everyone can benefit, rather than having each architecture do its own > thing. > > I'm sending this as RFC as James has yet to comment on my proposal, and > also to a wider audience, and although it makes a little more work for > James (to respin his series) it does mean that his series should get a > little smaller. And it makes tons of sense. > See: > https://lore.kernel.org/r/20230913163823.7880-2-james.morse@arm.com > https://lore.kernel.org/r/20230913163823.7880-4-james.morse@arm.com > https://lore.kernel.org/r/20230913163823.7880-23-james.morse@arm.com > > v2: lets try not fat-fingering vim. Yeah. I wondered how you managed to mangle that :) > arch/ia64/include/asm/cpu.h | 5 ----- > arch/ia64/kernel/topology.c | 2 +- That's moot as ia64 is queued for removal :) Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel