From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 415EBC54E76 for ; Tue, 17 Jan 2023 21:24:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sUZCtqjxwstOMdx+3ds/HXrAlQL9vLA1wDNV2LigzrY=; b=oomFZkPnwWMXlJ NZqRe3F+DBNGMA5GC3FE2xCnFNs+Gxq6KNEw3RtFbvwc+BT9/Spl7eOuEuc2zFnR6VeFNAi5yawxr W0+hshCN2qwLI/LJ1SSIhjfRfN92Udirq3IBPT+jcAWt/tLtSeLVUFXLft6umBnvVJQRUgj8NhNaI mr6+JIuUpU2zxgPiBvjAx17LR/WJZiAEcgHibxvMYGUIW+3WvvyXBfDm6Vs9btVaT7AkEpERqLX8b yh/VoulpoIH9XFZQgSibKrnS3YlKvZNm1j7W17ocb1nnF5mvFSa8HoHbbcYXHZ1bozdEz/Z/k1guL KtqaXpspNjCOHM+BGGUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHtQT-00FwTA-6G; Tue, 17 Jan 2023 21:23:25 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHtQQ-00FwRk-22 for linux-arm-kernel@lists.infradead.org; Tue, 17 Jan 2023 21:23:23 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1673990600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9cR92r6412sVEgsFseieEmbL64hVIExQVx/uajzRUqs=; b=4gvMSIqJNtFm0M4IlaLBv7hv9uh6wP/jv5tuk+SV8v0eTmaYmF1JpftSG0ZJy0oBApIwa0 w+F2HouWmAJVKfl5R+L+cea7gKk3FrL+h9hnITaMdz3/IS66/In2gga9M+EUwbEsl+YbY+ vP94ozvjRJSEvNh4gJ4qLAtMLC8W3wy3+HGT+21nDnmwNeuIrRVwCTg4degx5NlUuPF31m F+VGgGqJAqEJjJfZ9a84Fi65CQtT2qryxyGVmG3p4UNaVPZVmyLGFuWDQH6OMlHYT1zkU/ cL3/8dMghsZ2FdahcLDDPgj1rmU533JPtI/aFr+MJE1GmoVtAMRxk8wCIZmXtg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1673990600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9cR92r6412sVEgsFseieEmbL64hVIExQVx/uajzRUqs=; b=IazwIGkx4PC9hoLOSFvpMA991cbQcJeJhX2yOasyZlxAXJ+KRq46Q/ubauNBbC2xEC/u7P tjfvpSXkS3vXS1CA== To: Johan Hovold , Marc Zyngier Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Hsin-Yi Wang , Mark-PK Tsai Subject: Re: [PATCH v4 06/19] irqdomain: Drop revmap mutex In-Reply-To: <20230116135044.14998-7-johan+linaro@kernel.org> References: <20230116135044.14998-1-johan+linaro@kernel.org> <20230116135044.14998-7-johan+linaro@kernel.org> Date: Tue, 17 Jan 2023 22:23:20 +0100 Message-ID: <871qnslut3.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230117_132322_283662_398F6CE5 X-CRM114-Status: UNSURE ( 8.60 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 16 2023 at 14:50, Johan Hovold wrote: > The global irq_domain_mutex is now held in all paths that update the > revmap structures so there is no longer any need for the revmap mutex. This can also go after the 3rd race fix, but ... > static void irq_domain_clear_mapping(struct irq_domain *domain, > irq_hw_number_t hwirq) > { > + lockdep_assert_held(&irq_domain_mutex); these lockdep asserts want to be part of the [dis]association race fixes. They are completely unrelated to the removal of the revmap_mutex. Your race fixes change the locking and you want to ensure that all callers comply right there, no? Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel