From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95FA6C433FE for ; Tue, 15 Nov 2022 11:02:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gpSXb1jWX+Q4rwUkRwogN9vKJIE1tyhSDUB3DIZQnEg=; b=kot0YIKWo40ZvX MgiXS/uoecd/00He6jdwMqCNRQMxR6UAuows5Hb0JjwlPSq2+jA3vmPVySVldhxg6aRD5HbFulfxl q8IVG6WAW/nx1EcfWyLRmQ0fp/n8W96rjz6HifMIy1/zgV2+WYJBu4lqxWiOe25EBuCAsUc1EuvzH BV6Ed9gfPvKeisWtYS9dGpA8E1z4knjTLNsHhGj5hQfdhcmic2M9MUSQNq42ji2GXH8OpIlBiZB5w 3UhvfI/GWgzYUmK0n+6YsTvzURQ6l7ZEGFiWqZT6wqVLYg++nB/jmSs5YG9oR1NUAMiuzs0u6SWYU sKNeVWqrMYzdshQX3xtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1outga-00AGfF-On; Tue, 15 Nov 2022 11:01:01 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1outZT-00ACKV-Op for linux-arm-kernel@lists.infradead.org; Tue, 15 Nov 2022 10:53:41 +0000 Received: by mail-wm1-x32f.google.com with SMTP id o30so9394275wms.2 for ; Tue, 15 Nov 2022 02:53:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=9v4AdcSj02dGN+sTSTSoX216vNK0czt4nsREyiqCyb4=; b=NT5dzigavrzAZNaKL2yUvKhOafoISGVMqFoAQSPXasJNT26gFU0qoxXabO5EMQtzcR yVvOImt7hHWW7qrhbJ3fyhqEGhg+ep+V49PMruaSIhXpIirFxwH1v51vl1GNbmIcpUy4 SND+sWLznD62yrhxApbWkzsCXO3W2qVQrfA/2H4mhq96AMN9wZUgfONX2lccoArNUAQP 907HsJ6V1yDgbu/M8l4CSfEw253OAlk2y6Cu6WPtAR7VprbOqFaV2cdWf3B7K4qsH/pX mQbVXjEDZWZpqzHgjSJqzzU+ZFrabAOjJTQXN/ximLGw0vD1e8KTwOQGQ6cTTFQRrKqV Vh3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9v4AdcSj02dGN+sTSTSoX216vNK0czt4nsREyiqCyb4=; b=C/Xrd1DveJixvadNDcMNeMPnkzD4EfbwL/qiciwhjucKz9OvgJkCYAhMYPM70bgyQU TpNfRS1egpknAbDOz0mn6+nTc3x8mlIMlPz5+jv3m2uvROBe5Jf2elQYnzhX9mRiE1pp 3+tyDI6MSqwN1bEiK7cjs5shGYCCcQVedOP/VKPaSvJoxfsznAulyWuB7KvBZhzmiqX0 xiWybl0oIFSYjxTzaLfQtJa6JxSw43ozzRffUm+3WxOh0Id60tjc/7w0vQNEU9wEZuiz nyqwwybNWrYcrHK9XjuDQrSIpXYUD3P3iuhgIuB6ll7QvA8DtAs3/FE4NhkSAvCi7os7 9UyQ== X-Gm-Message-State: ANoB5pnh891pSZDE7cJMem+GwZnCO/9NMjHrpaupVMYviWjbfyKzOWoy CLmOmbkEPVKgdVI1CGyYkGnIdw== X-Google-Smtp-Source: AA0mqf5TfBRXmvcgVn+EC/b/rnAnkzazg/OV2uoZRERg79JL9u7Hs8m91ehAeA7ttP2LR6ND1HgRsw== X-Received: by 2002:a05:600c:3ba9:b0:3cf:ade4:d529 with SMTP id n41-20020a05600c3ba900b003cfade4d529mr32253wms.193.1668509618538; Tue, 15 Nov 2022 02:53:38 -0800 (PST) Received: from localhost ([95.148.15.66]) by smtp.gmail.com with ESMTPSA id n9-20020a7bcbc9000000b003b47ff307e1sm14883286wmi.31.2022.11.15.02.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 02:53:38 -0800 (PST) From: Punit Agrawal To: Shang XiaoJing Cc: , , , , , , Subject: Re: [PATCH 2/2] perf/smmuv3: Fix hotplug callback leak in arm_smmu_pmu_init() References: <20221114133348.25705-1-shangxiaojing@huawei.com> <20221114133348.25705-3-shangxiaojing@huawei.com> Date: Tue, 15 Nov 2022 10:53:37 +0000 In-Reply-To: <20221114133348.25705-3-shangxiaojing@huawei.com> (Shang XiaoJing's message of "Mon, 14 Nov 2022 21:33:48 +0800") Message-ID: <871qq4zdxq.fsf@stealth> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221115_025339_832422_9802BB73 X-CRM114-Status: GOOD ( 21.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Shang XiaoJing writes: > arm_smmu_pmu_init() won't remove the callback added by > cpuhp_setup_state_multi() when platform_driver_register() failed. Remove > the callback by cpuhp_remove_multi_state() in fail path. > > Similar to the handling of arm_ccn_init() in commit 26242b330093 ("bus: > arm-ccn: Prevent hotplug callback leak") > > Fixes: 7d839b4b9e00 ("perf/smmuv3: Add arm64 smmuv3 pmu driver") > Signed-off-by: Shang XiaoJing > --- > drivers/perf/arm_smmuv3_pmu.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/perf/arm_smmuv3_pmu.c b/drivers/perf/arm_smmuv3_pmu.c > index 00d4c45a8017..82622861ec44 100644 > --- a/drivers/perf/arm_smmuv3_pmu.c > +++ b/drivers/perf/arm_smmuv3_pmu.c > @@ -959,6 +959,8 @@ static struct platform_driver smmu_pmu_driver = { > > static int __init arm_smmu_pmu_init(void) > { > + int ret; > + > cpuhp_state_num = cpuhp_setup_state_multi(CPUHP_AP_ONLINE_DYN, > "perf/arm/pmcg:online", > NULL, > @@ -966,7 +968,13 @@ static int __init arm_smmu_pmu_init(void) > if (cpuhp_state_num < 0) > return cpuhp_state_num; > > - return platform_driver_register(&smmu_pmu_driver); > + ret = platform_driver_register(&smmu_pmu_driver); > + if (ret) { > + cpuhp_remove_multi_state(cpuhp_state_num); > + return ret; > + } > + > + return 0; Same comment as the previous patch. With the changes, Reviewed-by: Punit Agrawal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel