From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F09F9C433EF for ; Thu, 20 Jan 2022 10:34:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UGh7AId+vVi50L5mpK2BS3+gFoaD919cS1jhFPZJTng=; b=o3M4TYKAdAF+Pn 4grsswzVKwq3VN795gOauzC0Un4R1wpSoeUxQnECV9LmMP60IUPr0wUyd+JPxME00nrS6Owgh1/8Y HXp+Re5zqlWA/DgcImWd86UpF+WPKRajOJxpuUEUP5dhJ8bXwymkhZrNR8wz4PQmjYtalN5k24m/K bdqXdG6sXoziqGQsEckK5D9jqQY3KkFkkWOgM19SHgPtG/kK40IqcYMSYWjoxm3cPriiN1I2jGVO7 MBab8jq7DkJPqqAVJmgdpAeBm3H1e3nG9gF+aV/5an+uq83inGLQ2aSRXLFoJGw29RlW5p7qp0eZq OeLk6PefxhSUlx57V9Mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAUkV-00AlIh-40; Thu, 20 Jan 2022 10:32:59 +0000 Received: from guitar.tcltek.co.il ([84.110.109.230] helo=mx.tkos.co.il) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAUkQ-00AlGE-Eq for linux-arm-kernel@lists.infradead.org; Thu, 20 Jan 2022 10:32:56 +0000 Received: from tarshish (unknown [10.0.8.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id A83A7440EC4; Thu, 20 Jan 2022 12:32:41 +0200 (IST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1642674762; bh=vLMmNW2zYd4cs+GrkWWq8UgDVQ4AcyicuNf3Ub6yOBM=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=PJf4vnRUn6ZMWWDokawzeHfIXZb+pppxcGRJUNB62fmaSCRCX1CIDwvyWLchN9dcS ksNv22a841TrpPPvuXRhs33vKx/wGpP2FcVXCh2H23lq2D7cm4ekodRlbHLM0s4yTq w4dyVJO2mveUsYlfzvcdJmT+HFsA+IESJTzoTG/vijQQqu0cUkcFoKyX3t43p0vgnR feBJMrb6PkY+rxk7evREegEIXqaDZtBn+zOFns93Xfi0sjklWOvMNaD9oa9/OkQmte 52PgdUQkfhMVQ+vPQuIsztHuTzwSPlG5U+bW9ExUdkO8aRuJh23kDqzx+31wzz0JfK AdCw9SLMbl//g== References: <20220119002438.106079-1-sean.anderson@seco.com> <87ee53fv01.fsf@tarshish> <1965fc315525b8ab26cf9f71f939c24d@codeaurora.org> User-agent: mu4e 1.6.10; emacs 27.1 From: Baruch Siach To: Kathiravan T Cc: Sean Anderson , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Felipe Balbi , Thinh Nguyen , Balaji Prakash J , linux-kernel@vger.kernel.org, Robert Hancock , Andy Gross , Bjorn Andersson , Michal Simek , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 0/7] usb: dwc3: Calculate REFCLKPER et. al. from reference clock Date: Thu, 20 Jan 2022 12:29:32 +0200 In-reply-to: <1965fc315525b8ab26cf9f71f939c24d@codeaurora.org> Message-ID: <871r12g0j2.fsf@tarshish> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220120_023254_945328_1DFC11BC X-CRM114-Status: GOOD ( 18.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Kathiravan, On Thu, Jan 20 2022, Kathiravan T wrote: > On 2022-01-19 23:44, Baruch Siach wrote: >> Hi Sean, >> On Tue, Jan 18 2022, Sean Anderson wrote: >>> This is a rework of patches 3-5 of [1]. It attempts to correctly program >>> REFCLKPER and REFCLK_FLADJ based on the reference clock frequency. Since >>> we no longer need a special property duplicating this configuration, >>> snps,ref-clock-period-ns is deprecated. >>> Please test this! Patches 3/4 in this series have the effect of >>> programming REFCLKPER and REFCLK_FLADJ on boards which already configure >>> the "ref" clock. I have build tested, but not much else. >> Tested here on IPQ6010 based system. USB still works. But the with >> "ref" >> clock at 24MHz, period is calculated as 0x29. Previous >> snps,ref-clock-period-ns value used to be 0x32. >> Is that expected? > > Yes, it is 0x29 for IPQ60xx based SoCs. In downstream it was wrongly mentioned > as 0x32, which was corrected recently. Thanks for the update. This needs fixing in upstream kernel. I'll send a patch. For some reason USB appears to work here with both values. Is it because I only use USB2 signals? If this is the case them I can not actually test this series on my system. Thanks, baruch >>> [1] >>> https://lore.kernel.org/linux-usb/20220114044230.2677283-1-robert.hancock@calian.com/ >>> Changes in v2: >>> - Document clock members >>> - Also program GFLADJ.240MHZDECR >>> - Don't program GFLADJ if the version is < 2.50a >>> - Add snps,ref-clock-frequency-hz property for ACPI >>> Sean Anderson (7): >>> dt-bindings: usb: dwc3: Deprecate snps,ref-clock-period-ns >>> usb: dwc3: Get clocks individually >>> usb: dwc3: Calculate REFCLKPER based on reference clock >>> usb: dwc3: Program GFLADJ >>> usb: dwc3: Add snps,ref-clock-frequency-hz property for ACPI >>> arm64: dts: zynqmp: Move USB clocks to dwc3 node >>> arm64: dts: ipq6018: Use reference clock to set dwc3 period >>> .../devicetree/bindings/usb/snps,dwc3.yaml | 7 +- >>> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 3 +- >>> .../arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi | 4 +- >>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 +- >>> drivers/usb/dwc3/core.c | 112 +++++++++++++++--- >>> drivers/usb/dwc3/core.h | 17 ++- >>> 6 files changed, 120 insertions(+), 27 deletions(-) -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel