From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E114C4338F for ; Fri, 30 Jul 2021 13:06:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB95B60240 for ; Fri, 30 Jul 2021 13:06:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EB95B60240 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Om9aG2WZmtEZflXitvV9nHtnPwFmZsOupeUxg8wJyRg=; b=q9VnqC722F0VVD E1IM0qq6pSFD86UOhAj5VWv3bdJd4yR3mrNPEp4M+pmvCiocsiQPgtdJb77eznxl8UzrlxEOypi5k 11cioPY5yJH6Zpsaaab8U7g+VEZbZZCi+zWKjrvLWOtcSO21NM0qkL/VS13w7pUxEPVwhrWoJl2oa 5P+h0+R9HPOeDtl97OixKqY6OQwPJOoqonlDMwxZN1qAgDXu2ndd5OC0PkJGo/55MGcMez4g0K2Vg ya/4cVez0D8v/g81FrJPDswbDjL0vRLh32dj5Xjm6I8CzeG1T4NT/bpCXq/EfOTCYEwiOWgWkHVzc 6Ukk261yYjKIAjZ9FdCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9SBt-008jLK-2q; Fri, 30 Jul 2021 13:04:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9SBp-008jKg-B8 for linux-arm-kernel@lists.infradead.org; Fri, 30 Jul 2021 13:04:38 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5737761019; Fri, 30 Jul 2021 13:04:36 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m9SBm-0020Ld-F0; Fri, 30 Jul 2021 14:04:34 +0100 Date: Fri, 30 Jul 2021 14:04:33 +0100 Message-ID: <871r7g2bry.wl-maz@kernel.org> From: Marc Zyngier To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, qperret@google.com, dbrazdil@google.com, Srivatsa Vaddagiri , Shanker R Donthineni , James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com Subject: Re: [PATCH 04/16] KVM: arm64: Add MMIO checking infrastructure In-Reply-To: <20210730122658.GG23589@willie-the-truck> References: <20210715163159.1480168-1-maz@kernel.org> <20210715163159.1480168-5-maz@kernel.org> <20210727181107.GC19173@willie-the-truck> <8735ryep6d.wl-maz@kernel.org> <20210730122658.GG23589@willie-the-truck> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, qperret@google.com, dbrazdil@google.com, vatsa@codeaurora.org, sdonthineni@nvidia.com, james.morse@arm.com, suzuki.poulose@arm.com, alexandru.elisei@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210730_060437_454452_B3390983 X-CRM114-Status: GOOD ( 30.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 30 Jul 2021 13:26:59 +0100, Will Deacon wrote: > > On Wed, Jul 28, 2021 at 10:57:30AM +0100, Marc Zyngier wrote: > > On Tue, 27 Jul 2021 19:11:08 +0100, > > Will Deacon wrote: > > > On Thu, Jul 15, 2021 at 05:31:47PM +0100, Marc Zyngier wrote: > > > > +bool kvm_install_ioguard_page(struct kvm_vcpu *vcpu, gpa_t ipa) > > > > +{ > > > > + struct kvm_mmu_memory_cache *memcache; > > > > + struct kvm_memory_slot *memslot; > > > > + int ret, idx; > > > > + > > > > + if (!test_bit(KVM_ARCH_FLAG_MMIO_GUARD, &vcpu->kvm->arch.flags)) > > > > + return false; > > > > + > > > > + /* Must be page-aligned */ > > > > + if (ipa & ~PAGE_MASK) > > > > + return false; > > > > + > > > > + /* > > > > + * The page cannot be in a memslot. At some point, this will > > > > + * have to deal with device mappings though. > > > > + */ > > > > + idx = srcu_read_lock(&vcpu->kvm->srcu); > > > > + memslot = gfn_to_memslot(vcpu->kvm, ipa >> PAGE_SHIFT); > > > > + srcu_read_unlock(&vcpu->kvm->srcu, idx); > > > > > > What does this memslot check achieve? A new memslot could be added after > > > you've checked, no? > > > > If you start allowing S2 annotations to coexist with potential memory > > mappings, you're in for trouble. The faulting logic will happily > > overwrite the annotation, and that's probably not what you want. > > I don't disagree, but the check above appears to be racy. Yup, the srcu_read_unlock() should be moved at the end of this function. It's rather silly as it is currently written... > > > As for new (or moving) memslots, I guess they should be checked > > against existing annotations. > > Something like that, but the devil is in the details as it will need to > synchronize with this check somehow. The SRCU read lock should protect us against memslots being removed whilst we're accessing it. In a way, this is no different from taking a page fault. For new memslots, it is a lot less clear. There are multiple levels of locking, more or less documented... It feels like slots_arch_lock is the right tool for this job, but I need to page all that stuff in... M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel