From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14DE7C4338F for ; Wed, 28 Jul 2021 10:07:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D882A60F9D for ; Wed, 28 Jul 2021 10:07:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D882A60F9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tC7HmDQcUtpZL1/jv3eb3YSXcU132LJWD90E4jlOvqE=; b=DxYttU9huSyqul R89iCTLundGzW+UYJc0Cr2Nj9bYzKsY0ss3CsMjQro4ObzFgzSTcAJBZxtuWHjIV4IbUp6Edd4API CXmKnqq/25ViiEb+JSO9l6+6oKtP8GRVyVMx/nOScKE7mWxJIRhhPLxbcKycLOXcrCS6iBm1m2xxf m+o8bVx9H/45QqU0m3hVpHFP2WDV06PN3FWOMMwtWoKTVsmbuWXU6W0VvzzfI7pYLWJEXoE81cx6z szCg5yky9ByH3z+iaQ4brhoElgfB1P1I9FtkIBqOBDo0WiMK3PRubDE+5UZYkoEfQm2J+mYMuomg3 oHazzUqeZ3PYERuFYPlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8gQu-000KSe-8z; Wed, 28 Jul 2021 10:05:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8gQp-000KR3-Sg; Wed, 28 Jul 2021 10:04:57 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A2EE960E78; Wed, 28 Jul 2021 10:04:55 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m8gQn-001VGv-LS; Wed, 28 Jul 2021 11:04:53 +0100 Date: Wed, 28 Jul 2021 11:04:53 +0100 Message-ID: <871r7ieou2.wl-maz@kernel.org> From: Marc Zyngier To: Cc: , , , , Catalin Marinas , Will Deacon , Matthias Brugger , David Brazdil , Suzuki K Poulose , Mark Rutland , Ionela Voinescu , Amit Daniel Kachhap , Quentin Perret , Andrew Scull , James Morse , Fuad Tabba , "moderated list:ARM64\ PORT (AARCH64 ARCHITECTURE)" , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCH 1/1] arm64/cpufeature: Add option to disable mte support In-Reply-To: <20210728094302.9949-2-yee.lee@mediatek.com> References: <20210728094302.9949-1-yee.lee@mediatek.com> <20210728094302.9949-2-yee.lee@mediatek.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: yee.lee@mediatek.com, linux-kernel@vger.kernel.org, nicholas.Tang@mediatek.com, Kuan-Ying.lee@mediatek.com, chinwen.chang@mediatek.com, catalin.marinas@arm.com, will@kernel.org, matthias.bgg@gmail.com, dbrazdil@google.com, suzuki.poulose@arm.com, mark.rutland@arm.com, ionela.voinescu@arm.com, amit.kachhap@arm.com, qperret@google.com, ascull@google.com, james.morse@arm.com, tabba@google.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_030456_031876_EE724C71 X-CRM114-Status: GOOD ( 21.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 28 Jul 2021 10:42:58 +0100, wrote: > > From: Yee Lee > > Add a static key to exapnd the logic of system_supports_mte(). > This function controls mte enablement in both EL1 and EL0. > > The static key, "arm64_mte_support" is default true and can > be disabled via the early_param. > > Signed-off-by: Yee Lee > --- > arch/arm64/include/asm/cpufeature.h | 4 +++- > arch/arm64/kernel/cpufeature.c | 13 +++++++++++++ > arch/arm64/kernel/image-vars.h | 3 +++ > 3 files changed, 19 insertions(+), 1 deletion(-) This seems terribly complicated. How about this instead ("arm64.nomte" on the command line)? Thanks, M. diff --git a/arch/arm64/kernel/idreg-override.c b/arch/arm64/kernel/idreg-override.c index 53a381a7f65d..eaf17beb2420 100644 --- a/arch/arm64/kernel/idreg-override.c +++ b/arch/arm64/kernel/idreg-override.c @@ -54,6 +54,7 @@ static const struct ftr_set_desc pfr1 __initconst = { .override = &id_aa64pfr1_override, .fields = { { "bt", ID_AA64PFR1_BT_SHIFT }, + { "mte", ID_AA64PFR1_MTE_SHIFT }, {} }, }; @@ -100,6 +101,7 @@ static const struct { { "arm64.nopauth", "id_aa64isar1.gpi=0 id_aa64isar1.gpa=0 " "id_aa64isar1.api=0 id_aa64isar1.apa=0" }, + { "arm64.nomte", "id_aa64pfr1.mte=0" }, { "nokaslr", "kaslr.disabled=1" }, }; -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel