From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26C22C2D0A7 for ; Mon, 7 Sep 2020 10:22:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B789D204FD for ; Mon, 7 Sep 2020 10:22:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nNCqq5ox"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EeMSBb8F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B789D204FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NwSAgonJboPdyKj3UD0k/RgNrCsO7RrKC2iPl6i0A0c=; b=nNCqq5ox3G/V4J2q9SsVaV54c zYWPIpX80lPLH+UWPrgl/v/oDY+k1H8G83vR8vBfRdPurXZtdQgkqTuDra+USX7HfumcBUvpTcjXz Gd8ySbekZVbRJDRNXIR/9B7yG6PrYvVUYseMAeg6lNGSxiUT80eIAplwH+SMEN2VbQilIWi7nE9sD e+UZZpXM5EfTLiCDQRwWfGFTj5/Ot5nO0AGZuBjwYb/hcplrhoxQgT6t+tUmfZjJTcRQcwoykmsZE uxW5cgjxY0QzhhBhD4RSTQT+42VFRd3pBR696L9dcXO1PgAPqyYpRfTillMLFWHF4DYjt9eGMwIc7 Dgbp7qbZQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFEGy-00031w-J5; Mon, 07 Sep 2020 10:21:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFEGv-000312-Or for linux-arm-kernel@lists.infradead.org; Mon, 07 Sep 2020 10:21:14 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EA63221481; Mon, 7 Sep 2020 10:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599474072; bh=MT9drlk3MUYMfe58ilgJTEbP9Y17nMXs/5+Jd7Bsq0M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EeMSBb8FInPBpMhTH+h6eB8IjmzMtYgCLaLKj7HgrlLZMNqKCIe5DLXmNLaZTRUph Q11yctDKuTrnjrtuH/6ubcXXrMBpzS1WwRDmxNpn+D+JlxtgS5oFpo4VAcEeq+lZdc E5cTEMb6wYogiEBBj5+xHNlzWiNXotTJD7nwMSg0= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFEGr-009jUx-U9; Mon, 07 Sep 2020 11:21:10 +0100 Date: Mon, 07 Sep 2020 11:21:08 +0100 Message-ID: <871rjdnazv.wl-maz@kernel.org> From: Marc Zyngier To: Andrew Scull Subject: Re: [PATCH v3 02/18] KVM: arm64: Remove hyp_panic arguments In-Reply-To: <20200903135307.251331-3-ascull@google.com> References: <20200903135307.251331-1-ascull@google.com> <20200903135307.251331-3-ascull@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: ascull@google.com, kvmarm@lists.cs.columbia.edu, james.morse@arm.com, suzuki.poulose@arm.com, julien.thierry.kdev@gmail.com, will@kernel.org, catalin.marinas@arm.com, kernel-team@android.com, sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_062113_910725_0DF290B6 X-CRM114-Status: GOOD ( 21.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, james.morse@arm.com, linux-arm-kernel@lists.infradead.org, Sudeep Holla , will@kernel.org, kvmarm@lists.cs.columbia.edu, julien.thierry.kdev@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, On Thu, 03 Sep 2020 14:52:51 +0100, Andrew Scull wrote: > > hyp_panic is able to find all the context it needs from within itself so > remove the argument. The __hyp_panic wrapper becomes redundant so is > also removed. > > Signed-off-by: Andrew Scull > --- > arch/arm64/include/asm/kvm_hyp.h | 2 +- > arch/arm64/kvm/hyp/hyp-entry.S | 7 +------ > arch/arm64/kvm/hyp/include/hyp/switch.h | 4 +--- > arch/arm64/kvm/hyp/nvhe/switch.c | 4 +++- > arch/arm64/kvm/hyp/vhe/switch.c | 4 +++- > 5 files changed, 9 insertions(+), 12 deletions(-) > [...] > diff --git a/arch/arm64/kvm/hyp/nvhe/switch.c b/arch/arm64/kvm/hyp/nvhe/switch.c > index 3c9c065b3264..1e8a31b7c94c 100644 > --- a/arch/arm64/kvm/hyp/nvhe/switch.c > +++ b/arch/arm64/kvm/hyp/nvhe/switch.c > @@ -242,11 +242,13 @@ int __kvm_vcpu_run(struct kvm_vcpu *vcpu) > return exit_code; > } > > -void __noreturn hyp_panic(struct kvm_cpu_context *host_ctxt) > +void __noreturn hyp_panic(void) > { > u64 spsr = read_sysreg_el2(SYS_SPSR); > u64 elr = read_sysreg_el2(SYS_ELR); > u64 par = read_sysreg(par_el1); > + struct kvm_cpu_context *host_ctxt = > + &__hyp_this_cpu_ptr(kvm_host_data)->host_ctxt; nit: Please keep assignments on a single line. If that's too long, just move it outside of the declaration block. No need to respin the series for that though. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel