public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: gregory.clement@bootlin.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: clearfog: fix sdhci supply property name
Date: Fri, 21 Sep 2018 15:42:09 +0200	[thread overview]
Message-ID: <871s9nhsr2.fsf@bootlin.com> (raw)
In-Reply-To: <606cef37c2776bdc7dfa3ef578a18c40004e17af.1534878753.git.baruch@tkos.co.il> (Baruch Siach's message of "Tue, 21 Aug 2018 22:12:33 +0300")

Hi Baruch,
 
 On mar., ao?t 21 2018, Baruch Siach <baruch@tkos.co.il> wrote:

> The vmmc phandle, like all power supply property names, must have the
> '-supply' suffix.
>

I also noticed it a few months ago and then I forgot. However, does it
add any value to have this regulator?

Now that I found my note, I considered to just remove this line as well
as the regulator node.

What do you think ?

Gregory

> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  arch/arm/boot/dts/armada-388-clearfog.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-388-clearfog.dtsi b/arch/arm/boot/dts/armada-388-clearfog.dtsi
> index 7c6ad2afb094..1b0d0680c8b6 100644
> --- a/arch/arm/boot/dts/armada-388-clearfog.dtsi
> +++ b/arch/arm/boot/dts/armada-388-clearfog.dtsi
> @@ -48,7 +48,7 @@
>  					     &clearfog_sdhci_cd_pins>;
>  				pinctrl-names = "default";
>  				status = "okay";
> -				vmmc = <&reg_3p3v>;
> +				vmmc-supply = <&reg_3p3v>;
>  				wp-inverted;
>  			};
>  
> -- 
> 2.18.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

  reply	other threads:[~2018-09-21 13:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-21 19:12 [PATCH] ARM: dts: clearfog: fix sdhci supply property name Baruch Siach
2018-09-21 13:42 ` Gregory CLEMENT [this message]
2018-09-21 13:51   ` Russell King - ARM Linux
2018-09-21 14:05     ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871s9nhsr2.fsf@bootlin.com \
    --to=gregory.clement@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox