From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: IRQ #0 broken on ARM
Date: Sat, 22 Nov 2014 13:18:27 +0100 [thread overview]
Message-ID: <871tov5sz0.fsf@free.fr> (raw)
In-Reply-To: <CAL_JsqL50EAmcrM=mcLRwa0OwnhnnXx6ZFzkgfybfQ49ROn7zA@mail.gmail.com> (Rob Herring's message of "Fri, 21 Nov 2014 16:27:35 -0600")
Rob Herring <robherring2@gmail.com> writes:
>> #ifdef CONFIG_PXA_HAVE_ISA_IRQS
>
> You can get rid of this ifdef and kconfig symbol. It is only used here.
Right.
>> -#define PXA_IRQ(x) (PXA_ISA_IRQ_NUM + (x))
>> +#define PXA_IRQ(x) (16 + (x))
>
> Perhaps use NR_IRQS_LEGACY here.
Ah yes, good idea.
I'll sent a proper patch next time, not an attached piece of code.
Cheers.
--
Robert
next prev parent reply other threads:[~2014-11-22 12:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 10:31 IRQ #0 broken on ARM Dmitry Eremin-Solenikov
2014-11-21 10:34 ` Russell King - ARM Linux
2014-11-21 10:51 ` Dmitry Eremin-Solenikov
2014-11-21 10:53 ` Uwe Kleine-König
2014-11-21 10:55 ` Dmitry Eremin-Solenikov
2014-11-21 10:52 ` Marc Zyngier
2014-11-21 11:01 ` Dmitry Eremin-Solenikov
2014-11-21 11:01 ` Russell King - ARM Linux
2014-11-21 11:17 ` Marc Zyngier
2014-11-21 21:32 ` Robert Jarzmik
2014-11-21 22:20 ` Dmitry Eremin-Solenikov
2014-11-21 22:27 ` Rob Herring
2014-11-22 12:18 ` Robert Jarzmik [this message]
2014-11-22 12:40 ` Dmitry Eremin-Solenikov
2014-11-22 12:55 ` Robert Jarzmik
2014-11-21 22:31 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tov5sz0.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).