From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] OMAP3: cpuidle: prevent CORE power domain from going to RET or OFF when DSS is on
Date: Mon, 07 Mar 2011 11:06:03 -0800 [thread overview]
Message-ID: <871v2i7ntw.fsf@ti.com> (raw)
In-Reply-To: <854C6400F5AA6644BA6FE7953F3E769B0380FE45@008-AM1MPN1-013.mgdnok.nokia.com> (Tero Kristo's message of "Mon, 7 Mar 2011 12:02:22 +0000")
<Tero.Kristo@nokia.com> writes:
[...]
>>>>>
>>>>> + /* If DSS is active, prevent CORE RET/OFF */
>>>>> + dss_state = pwrdm_read_pwrst(dss_pd);
>>>>> + if (dss_state == PWRDM_POWER_ON &&
>>>>> + core_next_state != PWRDM_POWER_ON)
>>>>> + core_next_state = PWRDM_POWER_INACTIVE;
>>>>> +
>>>>
>>>>Due to sleepdeps/autodeps, when this code runs, DSS powerdomain is
>>>>always on. The result is that CORE is always set to INACTIVE.
>>>
>>> Now I recall that someone was asking about a patch similar to this
>>> earlier, and had the same issue with DSS sleepdep collision.
>>
>>>
>>> What is the reason for having the sleepdep for DSS powerdomain anyway?
>>> At least I can't see any reason why the sleepdep for DSS should be
>>> set. In my opinion it should be perfectly okay for DSS domain to idle
>>> independently of MPU/CORE, as this is going to be better for power
>>> consumption also.
>>
>>Agreed, but currently the sleepdeps with MPU are automatically managed
>>(by clkdm autodeps and hwmod initiator deps.) Until we have merged a
>>solution to more selectively enable sleepdeps (or remove them) $SUBJECT
>>patch cannot be merged.
>
> Ok I thought this is the case... it would be possible to implement a
> temporary/permanent solution that uses idle status check instead of
> pwrdm state check, and prevent core idle if dss is not going to
> idle. What is the current status with those idlest patches anyway?
Paul will have to answer that one.
Kevin
next prev parent reply other threads:[~2011-03-07 19:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 22:49 [PATCH 0/2] OMAP3: cpuidle: prevent CORE pwrdm from entering low-power state when DSS active Paul Walmsley
2011-03-01 22:49 ` [PATCH 1/2] OMAP3: cpuidle: prevent CORE power domain from going to RET or OFF when DSS is on Paul Walmsley
2011-03-03 23:24 ` Kevin Hilman
2011-03-04 8:14 ` Tero.Kristo at nokia.com
2011-03-04 16:56 ` Kevin Hilman
2011-03-07 12:02 ` Tero.Kristo at nokia.com
2011-03-07 19:06 ` Kevin Hilman [this message]
2011-03-10 10:17 ` Paul Walmsley
2011-03-09 0:04 ` Paul Walmsley
2011-03-01 22:49 ` [PATCH 2/2] OMAP3: cpuidle: add more details to the DSS-related CORE power domain state restriction Paul Walmsley
2011-03-02 8:18 ` [PATCH 0/2] OMAP3: cpuidle: prevent CORE pwrdm from entering low-power state when DSS active Tero.Kristo at nokia.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871v2i7ntw.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox