Re: [PATCH] arm64: dts: rockchip: Remove non-existing pwm-delay-us DT property

From: Javier Martinez Canillas <javierm@redhat.com>
To: Brian Norris <briannorris@chromium.org>
Cc: linux-kernel@vger.kernel.org,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Douglas Anderson <dianders@chromium.org>,
	Enric Balletbo i Serra <eballetbo@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Judy Hsiao <judyhsiao@chromium.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Lin Huang <hl@rock-chips.com>, Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	zain wang <wzz@rock-chips.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Remove non-existing pwm-delay-us DT property
Date: Fri, 31 Mar 2023 00:59:24 +0200	[thread overview]
Message-ID: <87355lg81f.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <CA+ASDXOtyBgr0o+bhjOScjs2h3oUKdouoAi4m+Z=R=Bho=iRFA@mail.gmail.com>

Brian Norris <briannorris@chromium.org> writes:

Hello Brian,

> On Thu, Mar 30, 2023 at 3:03 PM Javier Martinez Canillas
> <javierm@redhat.com> wrote:
>>
>> There is no neither a driver that parses this nor a DT binding schema that

Ups, I noticed now that there's an unnecessary "no" and it should be instead:

"There is neither a driver..."

>> documents it so let's remove it from the DTS files that make use of this.
>>
>> The properties that exist are post-pwm-on-delay-ms and pwm-off-delay-ms,
>> defined in the pwm-backlight DT binding. So probably what these DTS want
>> is something like following:
>>
>>         backlight: backlight {
>>                 compatible = "pwm-backlight";
>>                 enable-gpios = <&gpio4 21 GPIO_ACTIVE_HIGH>;
>>                 pinctrl-names = "default";
>>                 pinctrl-0 = <&bl_en>;
>>                 pwms = <&pwm1 0 1000000 0>;
>>                 post-pwm-on-delay-ms = <10>;
>>                 pwm-off-delay-ms = <10>;
>>         };
>>
>> But that should be follow-up change if that is the case. Because otherwise
>> it would be change in behaviour, since currently pwm-delay-us is a no-op.
>>
>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>
> pwm-delay-us seems to have been a downstream-only ("CHROMIUM", if
> you're familiar with ChromiumOS kernel parlance) change that seems
> like a combination of the two now-upstream properties you point at. I

Yes, that's what I found too. So it seems that this was an oversight when
the DTS for these Chromebooks were upstreamed.

> looked through the first use of pwm-delay-us on RK3399 Gru systems,
> and I can't find a spec reference that said it was needed; perhaps it
> was needless copy/paste imitation?
>
> So, simple deletion is probably fine:
>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
>

Thanks for the confirmation and review!

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel