From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC1D2C46467 for ; Tue, 10 Jan 2023 19:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qElSBwkHhFcOnnQHA/ZF34JJKsmN55cK+l2GZEXjUWw=; b=bdRzAwY8u5097A FPkitfdpFEuNG0wPVsckrwgRPRMXFHI8Q8p7qJIGrk/7RIi3rpv8AAjoxRTbLYi8WKqWUn1CF+0tK OBHiP6MltAs/Do4cl9UkWp4WqlTb4dYdbyaHSD/eie44rNA3/9n7kXDTqrpDg4HZ4d26u2f1NRDMI m+0Gw0t3kJDrcbwvyqRZDQNL807rHl0R5+2LTROtd75l7ljsiP340fL1Y9OOMYKZ3xEPKc23XeOD5 LEa9VtiP6A9wcmii9+9uTGzZfkzIg0c00n5L1nHOqvYNaz7p/bT+nTGwpOvOgBcsWF3+puROFxLE+ DFYUVKv03NuNHgR6OR2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFKSY-008LEh-Re; Tue, 10 Jan 2023 19:38:58 +0000 Received: from smtp-out1.suse.de ([195.135.220.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFKSU-008L9l-N0 for linux-arm-kernel@lists.infradead.org; Tue, 10 Jan 2023 19:38:56 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4BF706AF88; Tue, 10 Jan 2023 19:38:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1673379528; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sRYzBeoVZ+ukKrg91gbjOMBkupd2Hjhi4l2mXMwMgr8=; b=cYDIoosAADX40eKABkNArzs/Yq9igxN24s+UsixZrgL7XVXomUf0e2TpVGnvnlLh0xki4e sBNn1SeK4dD7Qs9D2CxWo/nx3WceajG3Mkn/kCGmwYZuPf+xXOXJY35q//evkLrHm0J8vj BudpdbII6+DBX0jmynAb5OeHn0f0Eic= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1673379528; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sRYzBeoVZ+ukKrg91gbjOMBkupd2Hjhi4l2mXMwMgr8=; b=teF7WoyCKU9EulEVDFbenE7ubWB3+jo6huoIpcrcO3SVCmbw0P4u0v/sK8vqMnuq31ZOtK ecwLTCOLGkqqX0Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C435813338; Tue, 10 Jan 2023 19:38:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IRcEIse+vWNgfQAAMHmgww (envelope-from ); Tue, 10 Jan 2023 19:38:47 +0000 From: Gabriel Krisman Bertazi To: Will Deacon Cc: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, broonie@kernel.org Subject: Re: [RFC PATCH] arm64: Cache HW update of Access Flag support Organization: SUSE References: <20230106163825.4812-1-krisman@suse.de> <20230106170949.GA5019@willie-the-truck> <87lembg2ma.fsf@suse.de> <20230110161651.GB9436@willie-the-truck> Date: Tue, 10 Jan 2023 16:38:45 -0300 In-Reply-To: <20230110161651.GB9436@willie-the-truck> (Will Deacon's message of "Tue, 10 Jan 2023 16:16:51 +0000") Message-ID: <87358ifad6.fsf@suse.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_113854_976660_73D4E592 X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Will Deacon writes: > FWIW, I had a hack kicking around to avoid the bsearch. It wasn't too > fiddly to rebase, so I've included it below if you want to take it for a > spin. The grotty part is having to maintain the extra enum, which is why > I didn't merge it in the past. Hi Will, I applied your patch, converted my fix to use it and re-ran the benchmark. For the record, the test is a mmtests workload that builds the kernel a few times with allmod config. If you want to reproduce it, I used the configuration below: https://github.com/gormanm/mmtests/blob/master/configs/config-workload-kernbench-max >From my observation, the array patch doesn't seem to meaningfully impact this benchmark. Using my RFC as a baseline, and comparing read_sanitised_ftr_reg with bsearch and your patch (array), I got: RFC bsearch array Amean syst-20 2886.71 ( 0.00%) 2913.26 * -0.92%* 2911.01 * -0.84%* I sent a v2 that uses read_sanitised_ftr_reg on another thread [1]. If you decide to merge your patch, I'm happy to re-spin it to use this new interface. [1] https://lore.kernel.org/linux-arm-kernel/20230109151955.8292-1-krisman@suse.de/ Thanks, -- Gabriel Krisman Bertazi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel