From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 944CCC43219 for ; Tue, 15 Nov 2022 11:01:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=34QtVsmnSHNkc2eC0KKo5O2NsSWsuxqgxgcrTN4VKMA=; b=MRFhqyDC9G8NrZ wITjwSPSd/FmQtB9g39apd5DL+OeZIuzUK07156WLRQ0U59yifIq4bJaEfB7Yg0DZvgtYveAxnWtQ 34/Rx+qh1KXR74QGzm+LH+BXZYGHKeUFLd10FxTtBiB7+veOvRzA7G0Q6z1RNiZMULvIGdJP0Lk0y OE75cZjof0GfRmlOvBygndJ7spitSYE7yqB79zFqDA7JFdfdruA53RZv9iBYM9VIcoB0qEuKKqlXo zzd378byMkvcRbHg97bhUetfx/TFtvFoujvyC559ouY4woFvh/WNq5QNPGcIT7wPVJjqrRbd9kS0V 0kelgFNwbL0H8WrRcERA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1outfn-00AGCw-IQ; Tue, 15 Nov 2022 11:00:12 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1outZ8-00AC5H-6y for linux-arm-kernel@lists.infradead.org; Tue, 15 Nov 2022 10:53:20 +0000 Received: by mail-wm1-x32f.google.com with SMTP id ja4-20020a05600c556400b003cf6e77f89cso996188wmb.0 for ; Tue, 15 Nov 2022 02:53:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=qjVmEgrKUxIlwawRWcGNcgVVZ2IWhMqMKDNTf7sbbtk=; b=2vedVl27j0ZbPWSuwRCiwGDY8lA8dPGwr1St6m5H2WegJZGlLQ4+K4LIThqMukETon 6riiX6WDFsMbJIQj7NVl+6wjcnP/b8nAoI/WnESsSRFu2yVoNlzJjpXEZzhxLCLjl9jQ DBHiD6SHoZNcLxptSU5nvY+VjclBM18YlIxOYzyaU+t6bK8wbmqLQne1L0E53vcLF0Jd LSQaX5KbwNoJmDGHl1Xg6D/+6kCc8BuYBWRJsO4GsdZ60Lql5LTrUbCTesrvk9jAygnR D2idiTfYR4fG74J2+1vzuo2Fa9xGWuwoodYXmNuamAusuYJadKyd9cS36pHOuvqzZyIF n0Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qjVmEgrKUxIlwawRWcGNcgVVZ2IWhMqMKDNTf7sbbtk=; b=YC4pinfCoU4aRsdB3ktUmcNV1omSruTllDwVYUjwY0wJg7qgH80Y9mAtbVJZkwA2PB DnfVBnxjNLfacA8liQvkxntTmx2noeAM3WiU3K9MwpEar5Oki/dtlWTvV/0/paagoGWS rmSVt8ZRUI7JU0Wx+6yAl7BRLI5xzXE2/Mvu42Hldzes5pmBdOmY3ogAL741iaOpkLbV u24VD4lXAYc/isj82mY1ePhaf/ew3/q7s/sdq6cTaAePhgtt5kDaB3ivogIgiWDfKKj5 PI8KpJ1TZ1n74cgnIzG5COZNScd7olAvdrLz/zMMz/pk7UEjC5dOHG/FASC0flirX73f oQ/w== X-Gm-Message-State: ANoB5pmgwgfnV3+iWXjyeO+z/Sk0JLpIi347ww4A2al4DPG/PYjczem1 uBTBX7F16OwiEFu+j3vCs5bHjg== X-Google-Smtp-Source: AA0mqf4eLi5UTxX15vBmLM/f3gTllVAlK5zIy+/L9Fc1JfEx0tVImBrf/GlfMiO6TbpYiXF+QgUUuQ== X-Received: by 2002:a1c:a3c4:0:b0:3cf:b7bf:352d with SMTP id m187-20020a1ca3c4000000b003cfb7bf352dmr999250wme.106.1668509595769; Tue, 15 Nov 2022 02:53:15 -0800 (PST) Received: from localhost ([95.148.15.66]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c1c0700b003cf71b1f66csm16665543wms.0.2022.11.15.02.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 02:53:15 -0800 (PST) From: Punit Agrawal To: Shang XiaoJing Cc: , , , , , , Subject: Re: [PATCH 1/2] perf/arm_dmc620: Fix hotplug callback leak in dmc620_pmu_init() References: <20221114133348.25705-1-shangxiaojing@huawei.com> <20221114133348.25705-2-shangxiaojing@huawei.com> Date: Tue, 15 Nov 2022 10:53:14 +0000 In-Reply-To: <20221114133348.25705-2-shangxiaojing@huawei.com> (Shang XiaoJing's message of "Mon, 14 Nov 2022 21:33:47 +0800") Message-ID: <8735akzdyd.fsf@stealth> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221115_025318_510759_80DC315A X-CRM114-Status: GOOD ( 22.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Shang XiaoJing writes: > dmc620_pmu_init() won't remove the callback added by > cpuhp_setup_state_multi() when platform_driver_register() failed. Remove > the callback by cpuhp_remove_multi_state() in fail path. > > Similar to the handling of arm_ccn_init() in commit 26242b330093 ("bus: > arm-ccn: Prevent hotplug callback leak") > > Fixes: 53c218da220c ("driver/perf: Add PMU driver for the ARM DMC-620 memory controller") > Signed-off-by: Shang XiaoJing > --- > drivers/perf/arm_dmc620_pmu.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/perf/arm_dmc620_pmu.c b/drivers/perf/arm_dmc620_pmu.c > index 280a6ae3e27c..d07054a05861 100644 > --- a/drivers/perf/arm_dmc620_pmu.c > +++ b/drivers/perf/arm_dmc620_pmu.c > @@ -725,6 +725,8 @@ static struct platform_driver dmc620_pmu_driver = { > > static int __init dmc620_pmu_init(void) > { > + int ret; > + > cpuhp_state_num = cpuhp_setup_state_multi(CPUHP_AP_ONLINE_DYN, > DMC620_DRVNAME, > NULL, > @@ -732,7 +734,13 @@ static int __init dmc620_pmu_init(void) > if (cpuhp_state_num < 0) > return cpuhp_state_num; > > - return platform_driver_register(&dmc620_pmu_driver); > + ret = platform_driver_register(&dmc620_pmu_driver); > + if (ret) { > + cpuhp_remove_multi_state(cpuhp_state_num); > + return ret; > + } > + > + return 0; Nit: There's no need for two separate returns. Just return "ret" at the bottom of the function. With the change, Reviewed-by: Punit Agrawal . _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel