* Re: [PATCH net 1/1] net: stmmac: disable Split Header (SPH) for Intel platforms [not found] <20220426074531.4115683-1-tee.min.tan@linux.intel.com> @ 2022-04-26 13:58 ` Kurt Kanzenbach 2022-04-28 1:55 ` Tan Tee Min 0 siblings, 1 reply; 3+ messages in thread From: Kurt Kanzenbach @ 2022-04-26 13:58 UTC (permalink / raw) To: Tan Tee Min, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, David S . Miller, Jakub Kicinski, Paolo Abeni, Maxime Coquelin, Michael Sit Wei Hong, Xiaoliang Yang, Wong Vee Khee, Tan Tee Min, Ling Pei Lee, Bhupesh Sharma Cc: netdev, linux-stm32, linux-arm-kernel, linux-kernel, stable, Voon Wei Feng, Song Yoong Siang, Ong, Boon Leong, Tan Tee Min [-- Attachment #1.1: Type: text/plain, Size: 622 bytes --] Hi, On Tue Apr 26 2022, Tan Tee Min wrote: > Based on DesignWare Ethernet QoS datasheet, we are seeing the limitation > of Split Header (SPH) feature is not supported for Ipv4 fragmented packet. > This SPH limitation will cause ping failure when the packets size exceed > the MTU size. For example, the issue happens once the basic ping packet > size is larger than the configured MTU size and the data is lost inside > the fragmented packet, replaced by zeros/corrupted values, and leads to > ping fail. > > So, disable the Split Header for Intel platforms. Does this issue only apply on Intel platforms? Thanks, Kurt [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 861 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net 1/1] net: stmmac: disable Split Header (SPH) for Intel platforms 2022-04-26 13:58 ` [PATCH net 1/1] net: stmmac: disable Split Header (SPH) for Intel platforms Kurt Kanzenbach @ 2022-04-28 1:55 ` Tan Tee Min 2022-04-28 7:05 ` Paolo Abeni 0 siblings, 1 reply; 3+ messages in thread From: Tan Tee Min @ 2022-04-28 1:55 UTC (permalink / raw) To: Kurt Kanzenbach Cc: Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, David S . Miller, Jakub Kicinski, Paolo Abeni, Maxime Coquelin, Michael Sit Wei Hong, Xiaoliang Yang, Wong Vee Khee, Ling Pei Lee, Bhupesh Sharma, netdev, linux-stm32, linux-arm-kernel, linux-kernel, stable, Voon Wei Feng, Song Yoong Siang, Ong, Boon Leong, Tan Tee Min On Tue, Apr 26, 2022 at 03:58:56PM +0200, Kurt Kanzenbach wrote: > Hi, > > On Tue Apr 26 2022, Tan Tee Min wrote: > > Based on DesignWare Ethernet QoS datasheet, we are seeing the limitation > > of Split Header (SPH) feature is not supported for Ipv4 fragmented packet. > > This SPH limitation will cause ping failure when the packets size exceed > > the MTU size. For example, the issue happens once the basic ping packet > > size is larger than the configured MTU size and the data is lost inside > > the fragmented packet, replaced by zeros/corrupted values, and leads to > > ping fail. > > > > So, disable the Split Header for Intel platforms. > > Does this issue only apply on Intel platforms? According to Synopsys IP support, they have confirmed the header-payload splitting for IPv4 fragmented packets is not supported for the Synopsys Ether IPs. Intel platforms are integrating with GMAC EQoS IP which is impacted by the limitation above, so we are changing the default SPH setting to disabled for Intel Platforms only. If anyone can confirm on their platform also having the same issues, then we would change the SPH default to disable across the IPs. Thanks, Tee Min _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net 1/1] net: stmmac: disable Split Header (SPH) for Intel platforms 2022-04-28 1:55 ` Tan Tee Min @ 2022-04-28 7:05 ` Paolo Abeni 0 siblings, 0 replies; 3+ messages in thread From: Paolo Abeni @ 2022-04-28 7:05 UTC (permalink / raw) To: Tan Tee Min, Kurt Kanzenbach Cc: Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, David S . Miller, Jakub Kicinski, Maxime Coquelin, Michael Sit Wei Hong, Xiaoliang Yang, Wong Vee Khee, Ling Pei Lee, Bhupesh Sharma, netdev, linux-stm32, linux-arm-kernel, linux-kernel, stable, Voon Wei Feng, Song Yoong Siang, Ong, Boon Leong, Tan Tee Min Hello, On Thu, 2022-04-28 at 09:55 +0800, Tan Tee Min wrote: > On Tue, Apr 26, 2022 at 03:58:56PM +0200, Kurt Kanzenbach wrote: > > Hi, > > > > On Tue Apr 26 2022, Tan Tee Min wrote: > > > Based on DesignWare Ethernet QoS datasheet, we are seeing the limitation > > > of Split Header (SPH) feature is not supported for Ipv4 fragmented packet. > > > This SPH limitation will cause ping failure when the packets size exceed > > > the MTU size. For example, the issue happens once the basic ping packet > > > size is larger than the configured MTU size and the data is lost inside > > > the fragmented packet, replaced by zeros/corrupted values, and leads to > > > ping fail. > > > > > > So, disable the Split Header for Intel platforms. > > > > Does this issue only apply on Intel platforms? > > According to Synopsys IP support, they have confirmed the header-payload > splitting for IPv4 fragmented packets is not supported for the Synopsys > Ether IPs. > > Intel platforms are integrating with GMAC EQoS IP which is impacted by the > limitation above, so we are changing the default SPH setting to disabled > for Intel Platforms only. > > If anyone can confirm on their platform also having the same issues, > then we would change the SPH default to disable across the IPs. Could you please provide a Fixes tag here? Thanks! Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-28 7:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220426074531.4115683-1-tee.min.tan@linux.intel.com>
2022-04-26 13:58 ` [PATCH net 1/1] net: stmmac: disable Split Header (SPH) for Intel platforms Kurt Kanzenbach
2022-04-28 1:55 ` Tan Tee Min
2022-04-28 7:05 ` Paolo Abeni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).