From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92B46C4338F for ; Tue, 10 Aug 2021 14:26:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31C6960D07 for ; Tue, 10 Aug 2021 14:26:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 31C6960D07 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: References:List-Owner; bh=KYMoaBVQdfTPeTwbJcYMJ+hRNY13dD0Gb0mGMVs3odE=; b=gBU 2/R4ipCdKAQGvuoWKQg239keIbJDJXPSLVXw0IddAINAYoYrRsOuyftTUe2Sh/1+iXGl4l2s9LW6C 4RK/8C3mpplRlZBXkT0JTZpWAMu5za2O0deGKYqtHyS1HIyY12cbmT4t7ouV4q5DLyIH4PF4xkMtN /DJnHPIauM0oY+R25q2a0PwIKvA7b+CC1CRthlwiAwi3yZGFm7c8MrZae+PYd4i63KkPdLx19FZmb ZwbYJID21c/04xQQF3m4P45EXvfq3nwhldylL1bO5Yp79Vcc8hornSz6dUyghxtK9A/dC8h2FCkhS EyxL1/5AxIIdtsgYVfGcbGkS2KgigEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDSfj-004B0T-Fn; Tue, 10 Aug 2021 14:24:04 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDScq-0049Ve-L2 for linux-arm-kernel@lists.infradead.org; Tue, 10 Aug 2021 14:21:09 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1628605261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=VDGHBk8tQR44Lf8F3j420x6+Qn1ZVZrp3PWRsihZtvg=; b=RhwbHrWY/6e+wG5oxL0v233f/iSL7ZrkzwRbj37grRZj6XxdvyuQukFpxdihh5a1q0FDLK 9EF+qSzMvqWmOCCol4MVtOXVf/R/eEiAh2CFAo+x3il36a7csE70NIhwabHpzAwnUK0lNG 7Dcv0HEOIB042g29cnyU+I+zaEs3ta+ReL5I6gzG4HNpOZOfxMXYAFAun8C12m0n9Tm09w 2AOT9qjPVX6/xlLq7oXlb1Z/hmwYXAbsGC2o3nax8A0ZJ3QzKfYTJaG/oczQ3/bRLAfGZp NHfShznA+LEz3TKgrNG1n0XUZrK7wDQFoH/kH4kaUq+pVnAwUpeFJmuuIusUqA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1628605261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=VDGHBk8tQR44Lf8F3j420x6+Qn1ZVZrp3PWRsihZtvg=; b=+7XloPyPFscFA7BB0psnYXn6snwHnGL6yw82K8Q/4h1OFhrSm1d44YLH1JRYfQ5kQE0Iab YUWcCgayHV+Z1hAQ== To: Lee Jones , lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,Ming Lei ,Hannes Reinecke Subject: Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG In-Reply-To: <20210617073136.315723-1-lee.jones@linaro.org> Date: Tue, 10 Aug 2021 16:21:01 +0200 Message-ID: <8735rhs7n6.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210810_072105_319235_93382326 X-CRM114-Status: GOOD ( 17.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 17 2021 at 08:31, Lee Jones wrote: > This sort of information is only generally useful when debugging. > > No need to have these sprinkled through the kernel log otherwise. Yes and no. > Cc: Thomas Gleixner > Signed-off-by: Lee Jones > --- > kernel/irq/cpuhotplug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/irq/cpuhotplug.c b/kernel/irq/cpuhotplug.c > index 02236b13b3599..cf8d4f75632e8 100644 > --- a/kernel/irq/cpuhotplug.c > +++ b/kernel/irq/cpuhotplug.c > @@ -42,7 +42,7 @@ static inline bool irq_needs_fixup(struct irq_data *d) > * If this happens then there was a missed IRQ fixup at some > * point. Warn about it and enforce fixup. > */ > - pr_warn("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n", This one is clearly a warning as this should not happen. See the comments around that. > + pr_debug("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n", > cpumask_pr_args(m), d->irq, cpu); > return true; > } > @@ -166,7 +166,7 @@ void irq_migrate_all_off_this_cpu(void) > raw_spin_unlock(&desc->lock); > > if (affinity_broken) { > - pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n", > + pr_debug_ratelimited("IRQ %u: no longer affine to CPU%u\n", > irq, smp_processor_id()); Maybe, but distro people might have opinions on that. Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel