From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90AE7C433ED for ; Sat, 10 Apr 2021 22:20:54 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B8C160FE6 for ; Sat, 10 Apr 2021 22:20:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B8C160FE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c6RaLuLTaDD3qA+FtkkYHZg0CRti2frD2T0DxROp6uA=; b=ZYrmIvVm1Js00McQDx2y659ev YO3p543rktBwF0JXhE9xfvs7i1tqlQVIHJOb3uZCJi4TUT/fDq0maQHeSyiwqxnAf+6EyhcRAvktH BOuHiBfMafA63LWMplyJ4J7n2qABZlI0wL4kp2fcwaI77BTr7JZcFJmq04EOjsQaKyL2XJHUaLtwe RTT/gmRwo1+5WdvtFTjFx4yrlZJ4CgumUvyiZULVcJcHec4GqEPlmToyBHoOxbPjoFUWgxf0a+ur8 AJk/XkqWyoKGNIDcIyRsDAiVZ3gaX1xlofnYBzhXfguCFYD2Dx0Ki6V5PzezcXk+IOC/jA0OIdHZy A9evzr46g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVLwJ-003XW2-GJ; Sat, 10 Apr 2021 22:18:51 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVLwE-003XVr-Pg for linux-arm-kernel@desiato.infradead.org; Sat, 10 Apr 2021 22:18:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=m3maxRPcbHnCtHoHVwTi8KI+I1hGtN6saFr33mmEJ7U=; b=sByCR/u2koTRNf+3vvHdaJNHSa hHz1xo8GsrrkME0iDtHOLO8xa3/dXOmBzContmE56/G+P9OUlsUZVvIhxY/FlISHvBcBPP3u2gO8/ 4B/YruJaoTXuodOJJiLJe0yCpLVTrAzbr30S4BDskV0Oso4aCp0fs7Wb2tLC9fGNs15DUvJwbF9b2 F9ggwrKHSY5djmz2jszhBFJqXYMJ+baajCCBlwCd4QstXav9uJthAQv4Owjiz819swLa2rx0Ta5H9 B3nwbyLxeaa3RFJFwU25eA+CFx+WuqOABFDnyrZX7IzuO6PiULaMGk31GJvyMNVvZ6AWTGyXiUDT8 XNO9Er1g==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVLwC-005Hbz-Bp for linux-arm-kernel@lists.infradead.org; Sat, 10 Apr 2021 22:18:45 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B07060FE6; Sat, 10 Apr 2021 22:18:43 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lVLw9-006l0U-GN; Sat, 10 Apr 2021 23:18:41 +0100 Date: Sat, 10 Apr 2021 23:18:40 +0100 Message-ID: <8735vxg4vz.wl-maz@kernel.org> From: Marc Zyngier To: Edmundo Carmona Antoranz Cc: catalin.marinas@arm.com, will@kernel.org, avagin@gmail.com, 0x7f454c46@gmail.com, mark.rutland@arm.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH -next] arm64: vdso: correct definition of macro vdso_clocksource_ok In-Reply-To: References: <20210410181117.23967-1-eantoranz@gmail.com> <874kgeezc6.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: eantoranz@gmail.com, catalin.marinas@arm.com, will@kernel.org, avagin@gmail.com, 0x7f454c46@gmail.com, mark.rutland@arm.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210410_151844_449931_31C81183 X-CRM114-Status: GOOD ( 22.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 10 Apr 2021 20:58:22 +0100, Edmundo Carmona Antoranz wrote: > > On Sat, Apr 10, 2021 at 1:03 PM Marc Zyngier wrote: > > > > Hi Edmundo, > > Sup! > > > > > > > No difference? Have you simply tried removing the macro and witness > > the effect? If it made no difference, why have the macro at all then? > > Oh, come on! so having the macro defined so that you can do things like > > lib/vdso/gettimeofday.c:34:#ifndef vdso_clocksource_ok > > counts as "a difference" to you? XD ok ok ... so, I have deleted > "extended linux kernel C preprocessor knowledge" from my linkedin > profile. If you want to look cool on Linkedin, the C preprocessor really is the wrong thing to boast about. Consider adding things like iron oxide, which will definitely boost your visibility. > I can safely assume that this is a big resounding NACK, right? :-D Not necessarily a NAK, because I don't like doing that. But I find this an unnecessarily change and a fairly pointless divergence from an established practice. Others may agree with you. But it was worth pointing out that "it actually makes no difference to have the macro defined or not" wasn't quite the right thing to put in the commit message. > > > > > Also, run this, for example: > > > > git grep '^\#define' arch/arm64/include/asm/| awk '$2 == $3 { print }' > > > > Are you going to "fix" these too? > > > > Thanks, > > Thank you for the lesson, man. Still have a lot of stuff to learn in > front of me. We all do. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel