From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97338C433E2 for ; Sat, 5 Sep 2020 11:05:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3854B2074B for ; Sat, 5 Sep 2020 11:05:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2EQgX84O"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZMH/9Dxi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3854B2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JBbLwwJ7kpiu79OWHxSM/Yxcn46MN2FlTXUNVCI9wwA=; b=2EQgX84OvDYxZDrb5PItIu5ex qGWxmDIA69o4IX3I5K6k2/yWJNim2G3jMoZWd6soSNqCkJGBBlF28P3Dy96oMDhtxcFN2MgcCj6mJ unEpg9ukJVFK16vnUm1HlCBHdx37yvNkVBDwS3+uIwRuoPCsnVgcw4fvth/+XAmv4MJSrXO0o/P9B fKY7NXO9N2q2wxQThg8LEQ8HbBovqT/aOdK0Tiap4+7z+sH1yZC0WSUz0Qnpr1gASRiPgA/N4x035 7ctvSgt+wJGhLSQns6QevUZhzPOAZ0qiyFMQK6+gJi3K0479U2y+R/bK5BBzMrskEZ6s+C97M4bUe FkJGwxEMg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEVzV-0004pl-EM; Sat, 05 Sep 2020 11:04:17 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEVzT-0004pH-Dd for linux-arm-kernel@lists.infradead.org; Sat, 05 Sep 2020 11:04:16 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE1932074B; Sat, 5 Sep 2020 11:04:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599303853; bh=W7V8ZU7QH4bhyjnEuCPx/ysHegXohN29y01K74kjKS8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZMH/9Dxi3qJfkhd7VLtbaguJfgBtdzMSQCGEujpCfOvhFG2+ePwZNWWEC3jCpJtyO qwWscifFtIwxsOvPw/yUPISHf+t+7GNXTNmFEUmy1Tyu+O9SHMxJ1DRfH9XUkW6mSl ZTCI6cAdDwK2idzR/d2ukgq/nOaU49BF6d4dwUAQ= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEVzP-009M5B-VJ; Sat, 05 Sep 2020 12:04:12 +0100 Date: Sat, 05 Sep 2020 12:04:10 +0100 Message-ID: <87363wmqmt.wl-maz@kernel.org> From: Marc Zyngier To: Jianyong Wu Subject: Re: [PATCH v14 07/10] arm64/kvm: Add hypercall service for kvm ptp. In-Reply-To: <20200904092744.167655-8-jianyong.wu@arm.com> References: <20200904092744.167655-1-jianyong.wu@arm.com> <20200904092744.167655-8-jianyong.wu@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: jianyong.wu@arm.com, netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com, sean.j.christopherson@intel.com, richardcochran@gmail.com, Mark.Rutland@arm.com, will@kernel.org, suzuki.poulose@arm.com, steven.price@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Steve.Capper@arm.com, justin.he@arm.com, nd@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200905_070415_516159_DC623165 X-CRM114-Status: GOOD ( 20.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark.Rutland@arm.com, justin.he@arm.com, kvm@vger.kernel.org, suzuki.poulose@arm.com, netdev@vger.kernel.org, richardcochran@gmail.com, Steve.Capper@arm.com, linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com, steven.price@arm.com, john.stultz@linaro.org, yangbo.lu@nxp.com, pbonzini@redhat.com, tglx@linutronix.de, nd@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 04 Sep 2020 10:27:41 +0100, Jianyong Wu wrote: > > ptp_kvm will get this service through smccc call. > The service offers wall time and counter cycle of host for guest. > caller must explicitly determines which cycle of virtual counter or > physical counter to return if it needs counter cycle. > > Signed-off-by: Jianyong Wu > --- > arch/arm64/kvm/Kconfig | 6 +++++ > arch/arm64/kvm/arch_timer.c | 2 +- > arch/arm64/kvm/hypercalls.c | 49 ++++++++++++++++++++++++++++++++++++ > include/kvm/arm_arch_timer.h | 1 + > include/linux/arm-smccc.h | 16 ++++++++++++ > 5 files changed, 73 insertions(+), 1 deletion(-) > [...] On top of what I said yesterday: > index 32ba6fbc3814..eb85f6701845 100644 > --- a/arch/arm64/kvm/arch_timer.c > +++ b/arch/arm64/kvm/arch_timer.c > @@ -81,7 +81,7 @@ u64 timer_get_cval(struct arch_timer_context *ctxt) > } > } > > -static u64 timer_get_offset(struct arch_timer_context *ctxt) > +u64 timer_get_offset(struct arch_timer_context *ctxt) > { > struct kvm_vcpu *vcpu = ctxt->vcpu; > Why has this become global? I can't see a reason why we would want to expose this purely KVM internal helper. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel