From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 11/11] thermal: armada: Give meaningful names to the thermal zones
Date: Fri, 22 Dec 2017 16:36:04 +0100 [thread overview]
Message-ID: <873742epwb.fsf@free-electrons.com> (raw)
In-Reply-To: <20171222093226.23456-12-miquel.raynal@free-electrons.com> (Miquel Raynal's message of "Fri, 22 Dec 2017 10:32:26 +0100")
Hi Miquel,
On ven., d?c. 22 2017, Miquel Raynal <miquel.raynal@free-electrons.com> wrote:
> After registration to the thermal core, sysfs will make one entry
> per instance of the driver in /sys/class/thermal_zoneX and
> /sys/class/hwmon/hwmonX, X being the index of the instance, all of them
> having the type/name "armada_thermal".
>
> Until now there was only one thermal zone per SoC but SoCs like Armada
> A7K and Armada A8K have respectively two and three thermal zones (one
> per AP and one per CP) and this number is subject to grow in the future.
>
> Use dev_name() instead of the "armada_thermal" string to get a
> meaningful name and be able to identify the thermal zones from
> userspace.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com>
> Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
And here I also tested that when all the series was applied there was no
regression on an Armada XP based board: PlatHome OpenBlocks AX3-4, and
on an Armada 388 one: SolidRun Clearfog A1. hera again for both of them
it was OK:
Tested-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Gregory
> ---
> drivers/thermal/armada_thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
> index ea958e651312..454137f78eb3 100644
> --- a/drivers/thermal/armada_thermal.c
> +++ b/drivers/thermal/armada_thermal.c
> @@ -406,8 +406,8 @@ static int armada_thermal_probe(struct platform_device *pdev)
>
> priv->data->init_sensor(pdev, priv);
>
> - thermal = thermal_zone_device_register("armada_thermal", 0, 0,
> - priv, &ops, NULL, 0, 0);
> + thermal = thermal_zone_device_register(dev_name(&pdev->dev), 0, 0, priv,
> + &ops, NULL, 0, 0);
> if (IS_ERR(thermal)) {
> dev_err(&pdev->dev,
> "Failed to register thermal zone device\n");
> --
> 2.11.0
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-12-22 15:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 9:32 [PATCH v6 00/11] Armada thermal: improvements and A7K/A8K SoCs support Miquel Raynal
2017-12-22 9:32 ` [PATCH v6 01/11] dt-bindings: thermal: Describe Armada AP806 and CP110 Miquel Raynal
2017-12-22 9:43 ` Miquel RAYNAL
2017-12-22 9:32 ` [PATCH v6 02/11] thermal: armada: Use msleep for long delays Miquel Raynal
2017-12-22 9:32 ` [PATCH v6 03/11] thermal: armada: Simplify the check of the validity bit Miquel Raynal
2017-12-22 9:32 ` [PATCH v6 04/11] thermal: armada: Clarify control registers accesses Miquel Raynal
2017-12-22 15:33 ` Gregory CLEMENT
2017-12-22 9:32 ` [PATCH v6 05/11] thermal: armada: Use real status register name Miquel Raynal
2017-12-22 9:32 ` [PATCH v6 06/11] thermal: armada: Add support for Armada AP806 Miquel Raynal
2017-12-22 10:14 ` Baruch Siach
2017-12-22 10:49 ` Miquel RAYNAL
2017-12-22 11:03 ` Baruch Siach
2017-12-22 9:32 ` [PATCH v6 07/11] thermal: armada: Add support for Armada CP110 Miquel Raynal
2017-12-22 9:32 ` [PATCH v6 08/11] thermal: armada: Update Kconfig and module description Miquel Raynal
2017-12-22 9:32 ` [PATCH v6 09/11] thermal: armada: Change sensors trim default value Miquel Raynal
2017-12-22 9:32 ` [PATCH v6 10/11] thermal: armada: Wait sensors validity before exiting the init callback Miquel Raynal
2017-12-22 9:32 ` [PATCH v6 11/11] thermal: armada: Give meaningful names to the thermal zones Miquel Raynal
2017-12-22 15:36 ` Gregory CLEMENT [this message]
2017-12-22 15:51 ` Miquel RAYNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873742epwb.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).