From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: linux-4.6-rc5/arch/arm/mach-pxa/pcm990-baseboard.c:354: possible missing code ?
Date: Wed, 27 Apr 2016 22:08:54 +0200 [thread overview]
Message-ID: <8737q6stk9.fsf@belgarion.home> (raw)
In-Reply-To: <DUB128-W41502854DD81E8A089EBCA9C620@phx.gbl> (David Binderman's message of "Mon, 25 Apr 2016 20:26:22 +0000")
David Binderman <dcb314@hotmail.com> writes:
> Hello there,
>
> linux-4.6-rc5/arch/arm/mach-pxa/pcm990-baseboard.c:354]: (style) Variable 'val' is assigned a value that is never used.
>
> Source code is
>
> ??? if ((1 << vdd) & p_d->ocr_mask)
> ??????? val |= PCM990_CTRL_MMC2PWR;
> ??? else
> ??????? val &= ~PCM990_CTRL_MMC2PWR;
>
> ??? pcm990_cpld_writeb(PCM990_CTRL_MMC2PWR, PCM990_CTRL_REG5);
> ??? return 0;
>
> Suggest either use local variable val or delete it.
Can you please submit a proper patch as in Documentation/SubmittingPatches ?
Cheers.
--
Robert
next prev parent reply other threads:[~2016-04-27 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 20:26 linux-4.6-rc5/arch/arm/mach-pxa/pcm990-baseboard.c:354: possible missing code ? David Binderman
2016-04-27 20:08 ` Robert Jarzmik [this message]
2016-04-27 21:13 ` David Binderman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737q6stk9.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox