* linux-4.6-rc5/arch/arm/mach-pxa/pcm990-baseboard.c:354: possible missing code ?
@ 2016-04-25 20:26 David Binderman
2016-04-27 20:08 ` Robert Jarzmik
0 siblings, 1 reply; 3+ messages in thread
From: David Binderman @ 2016-04-25 20:26 UTC (permalink / raw)
To: linux-arm-kernel
Hello there,
linux-4.6-rc5/arch/arm/mach-pxa/pcm990-baseboard.c:354]: (style) Variable 'val' is assigned a value that is never used.
Source code is
??? if ((1 << vdd) & p_d->ocr_mask)
??????? val |= PCM990_CTRL_MMC2PWR;
??? else
??????? val &= ~PCM990_CTRL_MMC2PWR;
??? pcm990_cpld_writeb(PCM990_CTRL_MMC2PWR, PCM990_CTRL_REG5);
??? return 0;
Suggest either use local variable val or delete it.
Regards
David Binderman
^ permalink raw reply [flat|nested] 3+ messages in thread
* linux-4.6-rc5/arch/arm/mach-pxa/pcm990-baseboard.c:354: possible missing code ?
2016-04-25 20:26 linux-4.6-rc5/arch/arm/mach-pxa/pcm990-baseboard.c:354: possible missing code ? David Binderman
@ 2016-04-27 20:08 ` Robert Jarzmik
2016-04-27 21:13 ` David Binderman
0 siblings, 1 reply; 3+ messages in thread
From: Robert Jarzmik @ 2016-04-27 20:08 UTC (permalink / raw)
To: linux-arm-kernel
David Binderman <dcb314@hotmail.com> writes:
> Hello there,
>
> linux-4.6-rc5/arch/arm/mach-pxa/pcm990-baseboard.c:354]: (style) Variable 'val' is assigned a value that is never used.
>
> Source code is
>
> ??? if ((1 << vdd) & p_d->ocr_mask)
> ??????? val |= PCM990_CTRL_MMC2PWR;
> ??? else
> ??????? val &= ~PCM990_CTRL_MMC2PWR;
>
> ??? pcm990_cpld_writeb(PCM990_CTRL_MMC2PWR, PCM990_CTRL_REG5);
> ??? return 0;
>
> Suggest either use local variable val or delete it.
Can you please submit a proper patch as in Documentation/SubmittingPatches ?
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 3+ messages in thread
* linux-4.6-rc5/arch/arm/mach-pxa/pcm990-baseboard.c:354: possible missing code ?
2016-04-27 20:08 ` Robert Jarzmik
@ 2016-04-27 21:13 ` David Binderman
0 siblings, 0 replies; 3+ messages in thread
From: David Binderman @ 2016-04-27 21:13 UTC (permalink / raw)
To: linux-arm-kernel
Hello there,
----------------------------------------
>> Suggest either use local variable val or delete it.
> Can you please submit a proper patch as in Documentation/SubmittingPatches ?
Sorry no. Not only do I not know if deletion or use is the best solution,
this email account conflicts with the whitespace requirements of a kernel patch.
I am happy for someone else to invent a patch.
Regards
David Binderman
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-27 21:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-25 20:26 linux-4.6-rc5/arch/arm/mach-pxa/pcm990-baseboard.c:354: possible missing code ? David Binderman
2016-04-27 20:08 ` Robert Jarzmik
2016-04-27 21:13 ` David Binderman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox