From mboxrd@z Thu Jan  1 00:00:00 1970
From: robert.jarzmik@free.fr (Robert Jarzmik)
Date: Wed, 27 Apr 2016 22:08:54 +0200
Subject: linux-4.6-rc5/arch/arm/mach-pxa/pcm990-baseboard.c:354: possible
 missing code ?
In-Reply-To: <DUB128-W41502854DD81E8A089EBCA9C620@phx.gbl> (David Binderman's
 message of "Mon, 25 Apr 2016 20:26:22 +0000")
References: <DUB128-W41502854DD81E8A089EBCA9C620@phx.gbl>
Message-ID: <8737q6stk9.fsf@belgarion.home>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

David Binderman <dcb314@hotmail.com> writes:

> Hello there,
>
> linux-4.6-rc5/arch/arm/mach-pxa/pcm990-baseboard.c:354]: (style) Variable 'val' is assigned a value that is never used.
>
> Source code is
>
> ??? if ((1 << vdd) & p_d->ocr_mask)
> ??????? val |= PCM990_CTRL_MMC2PWR;
> ??? else
> ??????? val &= ~PCM990_CTRL_MMC2PWR;
>
> ??? pcm990_cpld_writeb(PCM990_CTRL_MMC2PWR, PCM990_CTRL_REG5);
> ??? return 0;
>
> Suggest either use local variable val or delete it.
Can you please submit a proper patch as in Documentation/SubmittingPatches ?

Cheers.

-- 
Robert