* mach-pxa/pxa_cplds_irqs.c:126: bad if test ?
@ 2015-05-18 21:44 David Binderman
2015-05-19 6:00 ` Robert Jarzmik
0 siblings, 1 reply; 2+ messages in thread
From: David Binderman @ 2015-05-18 21:44 UTC (permalink / raw)
To: linux-arm-kernel
Hello there,
[linux-4.1-rc4/arch/arm/mach-pxa/pxa_cplds_irqs.c:126]: (style) Checking if unsigned variable 'base_irq' is less than zero.
??? base_irq = platform_get_irq(pdev, 1);
??? if (base_irq < 0)
??????? base_irq = 0;
Suggest code rework.
Regards
David Binderman
^ permalink raw reply [flat|nested] 2+ messages in thread
* mach-pxa/pxa_cplds_irqs.c:126: bad if test ?
2015-05-18 21:44 mach-pxa/pxa_cplds_irqs.c:126: bad if test ? David Binderman
@ 2015-05-19 6:00 ` Robert Jarzmik
0 siblings, 0 replies; 2+ messages in thread
From: Robert Jarzmik @ 2015-05-19 6:00 UTC (permalink / raw)
To: linux-arm-kernel
David Binderman <dcb314@hotmail.com> writes:
> Hello there,
>
> [linux-4.1-rc4/arch/arm/mach-pxa/pxa_cplds_irqs.c:126]: (style) Checking if
> unsigned variable 'base_irq' is less than zero.
>
> ??? base_irq = platform_get_irq(pdev, 1);
> ??? if (base_irq < 0)
> ??????? base_irq = 0;
Thanks David, a patch has already been provided by Dan Carpenter.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-19 6:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-18 21:44 mach-pxa/pxa_cplds_irqs.c:126: bad if test ? David Binderman
2015-05-19 6:00 ` Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).