From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch v2 3/3] mm: page_alloc: fair zone allocator policy
Date: Fri, 16 Aug 2013 14:52:11 -0700 [thread overview]
Message-ID: <8738q9b8xg.fsf@kernel.org> (raw)
In-Reply-To: <20130816201814.GA26409@cmpxchg.org> (Johannes Weiner's message of "Fri, 16 Aug 2013 16:18:14 -0400")
Johannes Weiner <hannes@cmpxchg.org> writes:
> Hi Kevin,
>
> On Fri, Aug 16, 2013 at 10:17:01AM -0700, Kevin Hilman wrote:
>> Johannes Weiner <hannes@cmpxchg.org> writes:
>> > On Wed, Aug 07, 2013 at 11:37:43AM -0400, Johannes Weiner wrote:
>> > Subject: [patch] mm: page_alloc: use vmstats for fair zone allocation batching
>> >
>> > Avoid dirtying the same cache line with every single page allocation
>> > by making the fair per-zone allocation batch a vmstat item, which will
>> > turn it into batched percpu counters on SMP.
>> >
>> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
>>
>> I bisected several boot failures on various ARM platform in
>> next-20130816 down to this patch (commit 67131f9837 in linux-next.)
>>
>> Simply reverting it got things booting again on top of -next. Example
>> boot crash below.
>
> Thanks for the bisect and report!
You're welcome. Thanks for the quick fix!
> I deref the percpu pointers before initializing them properly. It
> didn't trigger on x86 because the percpu offset added to the pointer
> is big enough so that it does not fall into PFN 0, but it probably
> ended up corrupting something...
>
> Could you try this patch on top of linux-next instead of the revert?
Yup, that change fixes it.
Tested-by: Kevin Hilman <khilman@linaro.org>
Kevin
next prev parent reply other threads:[~2013-08-16 21:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1375457846-21521-1-git-send-email-hannes@cmpxchg.org>
[not found] ` <1375457846-21521-4-git-send-email-hannes@cmpxchg.org>
[not found] ` <20130807145828.GQ2296@suse.de>
[not found] ` <20130807153743.GH715@cmpxchg.org>
[not found] ` <20130808041623.GL1845@cmpxchg.org>
[not found] ` <87haepblo2.fsf@kernel.org>
2013-08-16 20:18 ` [patch v2 3/3] mm: page_alloc: fair zone allocator policy Johannes Weiner
2013-08-16 21:24 ` Stephen Warren
2013-08-16 21:52 ` Kevin Hilman [this message]
2013-08-19 0:48 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738q9b8xg.fsf@kernel.org \
--to=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).