From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM : omap : remove __init for _enable_preprogram
Date: Tue, 14 May 2013 11:08:20 -0700 [thread overview]
Message-ID: <8738tpxwmj.fsf@linaro.org> (raw)
In-Reply-To: <1368547621-8570-1-git-send-email-jp.francois@cynove.com> (jp francois's message of "Tue, 14 May 2013 18:07:01 +0200")
jp.francois at cynove.com writes:
> _enable_preprogram is marked as __init, but is called from _enable which is not.
> This results in oops once init is freed.
> Fix this by removing the __init marker.
>
> Signed-off-by: Jean-Philippe Fran?ois <jp.francois@cynove.com>
Acked-by: Kevin Hilman <khilman@linaro.org>
Tony, this should probably be queued for v3.10-rc, and tagged for stable.
Kevin
> Index: b/arch/arm/mach-omap2/omap_hwmod.c
> ===================================================================
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -2066,7 +2066,7 @@
> * do so is present in the hwmod data, then call it and pass along the
> * return value; otherwise, return 0.
> */
> -static int __init _enable_preprogram(struct omap_hwmod *oh)
> +static int _enable_preprogram(struct omap_hwmod *oh)
> {
> if (!oh->class->enable_preprogram)
> return 0;
next prev parent reply other threads:[~2013-05-14 18:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 16:07 [PATCH] ARM : omap : remove __init for _enable_preprogram jp.francois at cynove.com
2013-05-14 18:08 ` Kevin Hilman [this message]
2013-05-16 18:15 ` Tony Lindgren
2013-05-14 18:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738tpxwmj.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).