Status of gpio-pxa driver and dummy clock

Status of gpio-pxa driver and dummy clock

[Robert Jarzmik]

Hi Haojian,

As you certainly know, Russell reverted the patch "ARM: pxa: add dummy clock for
sa1100-rtc", id a55b5adaf403c4d032e0871ad4ee3367782f4db6. As a consequence, the
dummy clock for gpio-pxa was removed, causing breakage of gpio-pxa driver.

I wonder if you (or somebody through you) sent an update to fix the gpio-pxa by
either fixing gpio-pxa or adding back "pxa-gpio" clock. As of today, I see no
fix in 3.3-rc free (Linus tree).

Cheers.

-- 
Robert

Status of gpio-pxa driver and dummy clock

[Haojian Zhuang]

On Sun, Mar 4, 2012 at 5:34 AM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> Hi Haojian,
>
> As you certainly know, Russell reverted the patch "ARM: pxa: add dummy clock for
> sa1100-rtc", id a55b5adaf403c4d032e0871ad4ee3367782f4db6. As a consequence, the
> dummy clock for gpio-pxa was removed, causing breakage of gpio-pxa driver.
>
> I wonder if you (or somebody through you) sent an update to fix the gpio-pxa by
> either fixing gpio-pxa or adding back "pxa-gpio" clock. As of today, I see no
> fix in 3.3-rc free (Linus tree).
>

This patch is already merged into arm-soc tree for v3.4. I don't have
a plan to push it into
v3.3.

Thanks
Haojian

Status of gpio-pxa driver and dummy clock

[Robert Jarzmik]

Haojian Zhuang <haojian.zhuang@gmail.com> writes:

> On Sun, Mar 4, 2012 at 5:34 AM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>> Hi Haojian,
>>
>> As you certainly know, Russell reverted the patch "ARM: pxa: add dummy clock for
>> sa1100-rtc", id a55b5adaf403c4d032e0871ad4ee3367782f4db6. As a consequence, the
>> dummy clock for gpio-pxa was removed, causing breakage of gpio-pxa driver.
>>
>> I wonder if you (or somebody through you) sent an update to fix the gpio-pxa by
>> either fixing gpio-pxa or adding back "pxa-gpio" clock. As of today, I see no
>> fix in 3.3-rc free (Linus tree).
>>
>
> This patch is already merged into arm-soc tree for v3.4. I don't have
> a plan to push it into
> v3.3.

Oh, you should push it to 3.3. It's a fix, and the mioa701 board is broken (and
probably many others PXA based boards too) because no GPIO is available (as
probe function of pxa-gpio always fail on clk_get()).

If you don't want to push it to 3.3, I'll have to send a fix to Arnd to fix the
breakage.

Without it, a PXA based kernel (pxa2xx) will hang in its boot phase, on the
first gpio_get_* or gpio_set_*, which is called by many drivers.

Cheers.

-- 
Robert

Status of gpio-pxa driver and dummy clock

[Paul Parsons]

--- On Sun, 4/3/12, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> From: Robert Jarzmik <robert.jarzmik@free.fr>
> Subject: Re: Status of gpio-pxa driver and dummy clock
> To: "Haojian Zhuang" <haojian.zhuang@gmail.com>
> Cc: "Arnd Bergmann" <arnd@arndb.de>, linux-arm-kernel at lists.infradead.org
> Date: Sunday, 4 March, 2012, 10:25
> Haojian Zhuang <haojian.zhuang@gmail.com>
> writes:
> 
> > On Sun, Mar 4, 2012 at 5:34 AM, Robert Jarzmik <robert.jarzmik@free.fr>
> wrote:
> >> Hi Haojian,
> >>
> >> As you certainly know, Russell reverted the patch
> "ARM: pxa: add dummy clock for
> >> sa1100-rtc", id
> a55b5adaf403c4d032e0871ad4ee3367782f4db6. As a consequence,
> the
> >> dummy clock for gpio-pxa was removed, causing
> breakage of gpio-pxa driver.
> >>
> >> I wonder if you (or somebody through you) sent an
> update to fix the gpio-pxa by
> >> either fixing gpio-pxa or adding back "pxa-gpio"
> clock. As of today, I see no
> >> fix in 3.3-rc free (Linus tree).
> >>
> >
> > This patch is already merged into arm-soc tree for
> v3.4. I don't have
> > a plan to push it into
> > v3.3.
> 
> Oh, you should push it to 3.3. It's a fix, and the mioa701
> board is broken (and
> probably many others PXA based boards too) because no GPIO
> is available (as
> probe function of pxa-gpio always fail on clk_get()).
> 
> If you don't want to push it to 3.3, I'll have to send a fix
> to Arnd to fix the
> breakage.
> 
> Without it, a PXA based kernel (pxa2xx) will hang in its
> boot phase, on the
> first gpio_get_* or gpio_set_*, which is called by many
> drivers.

There are two further pxa gpio regressions still present in
linux-3.3-rc5:

mfp/gpio regression: pxa_last_gpio used before initialized
http://lists.infradead.org/pipermail/linux-arm-kernel/2012-January/082624.html

reboot/suspend regression: hx4700 freezes under linux-3.3-rc1
http://lists.infradead.org/pipermail/linux-arm-kernel/2012-February/082873.html
(2 regressions are reported here; the reboot regression is still present in
linux-3.3-rc5 while the suspend regression has now been fixed).

Status of gpio-pxa driver and dummy clock

[Haojian Zhuang]

On Mon, Mar 5, 2012 at 2:26 AM, Paul Parsons <lost.distance@yahoo.com> wrote:
> --- On Sun, 4/3/12, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>> From: Robert Jarzmik <robert.jarzmik@free.fr>
>> Subject: Re: Status of gpio-pxa driver and dummy clock
>> To: "Haojian Zhuang" <haojian.zhuang@gmail.com>
>> Cc: "Arnd Bergmann" <arnd@arndb.de>, linux-arm-kernel at lists.infradead.org
>> Date: Sunday, 4 March, 2012, 10:25
>> Haojian Zhuang <haojian.zhuang@gmail.com>
>> writes:
>>
>> > On Sun, Mar 4, 2012 at 5:34 AM, Robert Jarzmik <robert.jarzmik@free.fr>
>> wrote:
>> >> Hi Haojian,
>> >>
>> >> As you certainly know, Russell reverted the patch
>> "ARM: pxa: add dummy clock for
>> >> sa1100-rtc", id
>> a55b5adaf403c4d032e0871ad4ee3367782f4db6. As a consequence,
>> the
>> >> dummy clock for gpio-pxa was removed, causing
>> breakage of gpio-pxa driver.
>> >>
>> >> I wonder if you (or somebody through you) sent an
>> update to fix the gpio-pxa by
>> >> either fixing gpio-pxa or adding back "pxa-gpio"
>> clock. As of today, I see no
>> >> fix in 3.3-rc free (Linus tree).
>> >>
>> >
>> > This patch is already merged into arm-soc tree for
>> v3.4. I don't have
>> > a plan to push it into
>> > v3.3.
>>
>> Oh, you should push it to 3.3. It's a fix, and the mioa701
>> board is broken (and
>> probably many others PXA based boards too) because no GPIO
>> is available (as
>> probe function of pxa-gpio always fail on clk_get()).
>>
>> If you don't want to push it to 3.3, I'll have to send a fix
>> to Arnd to fix the
>> breakage.
>>
>> Without it, a PXA based kernel (pxa2xx) will hang in its
>> boot phase, on the
>> first gpio_get_* or gpio_set_*, which is called by many
>> drivers.
>
> There are two further pxa gpio regressions still present in
> linux-3.3-rc5:
>
> mfp/gpio regression: pxa_last_gpio used before initialized
> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-January/082624.html
>
> reboot/suspend regression: hx4700 freezes under linux-3.3-rc1
> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-February/082873.html
> (2 regressions are reported here; the reboot regression is still present in
> linux-3.3-rc5 while the suspend regression has now been fixed).

I missed them. Maybe I was not in the Cc list. I'll append the patches
to fix them.

Best Regards
Haojian

Status of gpio-pxa driver and dummy clock

[Robert Jarzmik]

Haojian Zhuang <haojian.zhuang@gmail.com> writes:

> I missed them. Maybe I was not in the Cc list. I'll append the patches
> to fix them.

Just to be sure, this is the patch which is missing for the dummy clock, which
was not submitted before AFAIK (Jonathan, Paul, please confirm).

I added the commit text to Paul's patch, and authored it as Paul's with
Jonathan's report. Again, Jonathan, Paul, I'd like to have your agreement here.

Haojian, if you have another patch ready, don't hesitate to drop this patch and
take your own, as long as gpio-pxa is fixed, I'll be happy.

Cheers.

--
Robert

8>----
>From 505a23475843a8fbac077e789d911ee07e1ae9cc Mon Sep 17 00:00:00 2001
From: Paul Parsons <lost.distance@yahoo.com>
Date: Sat, 3 Mar 2012 21:10:09 +0100
Subject: [PATCH] arch/arm: pxa add dummy clocks for gpio driver

Fix gpio driver by providing it a dummy clock. This
regression was introduced by the commit "ARM: pxa: add dummy
clock for sa1100-rtc", id
a55b5adaf403c4d032e0871ad4ee3367782f4db6.

Reported-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
 arch/arm/mach-pxa/pxa25x.c |    1 +
 arch/arm/mach-pxa/pxa27x.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-pxa/pxa25x.c b/arch/arm/mach-pxa/pxa25x.c
index 00d6eac..d8de3e5 100644
--- a/arch/arm/mach-pxa/pxa25x.c
+++ b/arch/arm/mach-pxa/pxa25x.c
@@ -208,6 +208,7 @@ static struct clk_lookup pxa25x_clkregs[] = {
 	INIT_CLKREG(&clk_pxa25x_gpio11, NULL, "GPIO11_CLK"),
 	INIT_CLKREG(&clk_pxa25x_gpio12, NULL, "GPIO12_CLK"),
 	INIT_CLKREG(&clk_pxa25x_mem, "pxa2xx-pcmcia", NULL),
+	INIT_CLKREG(&clk_dummy, "pxa-gpio", NULL),
 };
 
 static struct clk_lookup pxa25x_hwuart_clkreg =
diff --git a/arch/arm/mach-pxa/pxa27x.c b/arch/arm/mach-pxa/pxa27x.c
index c1673b3..a3fabc9 100644
--- a/arch/arm/mach-pxa/pxa27x.c
+++ b/arch/arm/mach-pxa/pxa27x.c
@@ -229,6 +229,7 @@ static struct clk_lookup pxa27x_clkregs[] = {
 	INIT_CLKREG(&clk_pxa27x_im, NULL, "IMCLK"),
 	INIT_CLKREG(&clk_pxa27x_memc, NULL, "MEMCLK"),
 	INIT_CLKREG(&clk_pxa27x_mem, "pxa2xx-pcmcia", NULL),
+	INIT_CLKREG(&clk_dummy, "pxa-gpio", NULL),
 };
 
 #ifdef CONFIG_PM
-- 
1.7.5.4

Status of gpio-pxa driver and dummy clock

[Paul Parsons]

--- On Mon, 5/3/12, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> Date: Monday, 5 March, 2012, 22:08
> Haojian Zhuang <haojian.zhuang@gmail.com>
> writes:
> 
> > I missed them. Maybe I was not in the Cc list. I'll
> append the patches
> > to fix them.
> 
> Just to be sure, this is the patch which is missing for the
> dummy clock, which
> was not submitted before AFAIK (Jonathan, Paul, please
> confirm).
> 
> I added the commit text to Paul's patch, and authored it as
> Paul's with
> Jonathan's report. Again, Jonathan, Paul, I'd like to have
> your agreement here.
> 
> Haojian, if you have another patch ready, don't hesitate to
> drop this patch and
> take your own, as long as gpio-pxa is fixed, I'll be happy.

I created this patch without waiting for an official fix purely to solve
the problem for myself. I then posted it in case it would be useful to
others. By all means use it or, if a better patch exists, drop it.

> Cheers.
> 
> --
> Robert
> 
> 8>----
> From 505a23475843a8fbac077e789d911ee07e1ae9cc Mon Sep 17
> 00:00:00 2001
> From: Paul Parsons <lost.distance@yahoo.com>
> Date: Sat, 3 Mar 2012 21:10:09 +0100
> Subject: [PATCH] arch/arm: pxa add dummy clocks for gpio
> driver
> 
> Fix gpio driver by providing it a dummy clock. This
> regression was introduced by the commit "ARM: pxa: add
> dummy
> clock for sa1100-rtc", id
> a55b5adaf403c4d032e0871ad4ee3367782f4db6.
> 
> Reported-by: Jonathan Cameron <jic23@cam.ac.uk>
> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
> Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
>  arch/arm/mach-pxa/pxa25x.c |? ? 1 +
>  arch/arm/mach-pxa/pxa27x.c |? ? 1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-pxa/pxa25x.c
> b/arch/arm/mach-pxa/pxa25x.c
> index 00d6eac..d8de3e5 100644
> --- a/arch/arm/mach-pxa/pxa25x.c
> +++ b/arch/arm/mach-pxa/pxa25x.c
> @@ -208,6 +208,7 @@ static struct clk_lookup
> pxa25x_clkregs[] = {
>  ??? INIT_CLKREG(&clk_pxa25x_gpio11,
> NULL, "GPIO11_CLK"),
>  ??? INIT_CLKREG(&clk_pxa25x_gpio12,
> NULL, "GPIO12_CLK"),
>  ??? INIT_CLKREG(&clk_pxa25x_mem,
> "pxa2xx-pcmcia", NULL),
> +??? INIT_CLKREG(&clk_dummy, "pxa-gpio",
> NULL),
>  };
>  
>  static struct clk_lookup pxa25x_hwuart_clkreg =
> diff --git a/arch/arm/mach-pxa/pxa27x.c
> b/arch/arm/mach-pxa/pxa27x.c
> index c1673b3..a3fabc9 100644
> --- a/arch/arm/mach-pxa/pxa27x.c
> +++ b/arch/arm/mach-pxa/pxa27x.c
> @@ -229,6 +229,7 @@ static struct clk_lookup
> pxa27x_clkregs[] = {
>  ??? INIT_CLKREG(&clk_pxa27x_im, NULL,
> "IMCLK"),
>  ??? INIT_CLKREG(&clk_pxa27x_memc, NULL,
> "MEMCLK"),
>  ??? INIT_CLKREG(&clk_pxa27x_mem,
> "pxa2xx-pcmcia", NULL),
> +??? INIT_CLKREG(&clk_dummy, "pxa-gpio",
> NULL),
>  };
>  
>  #ifdef CONFIG_PM
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

Status of gpio-pxa driver and dummy clock

[Jonathan Cameron]

On 3/5/2012 10:48 PM, Paul Parsons wrote:
> --- On Mon, 5/3/12, Robert Jarzmik<robert.jarzmik@free.fr>  wrote:
>> Date: Monday, 5 March, 2012, 22:08
>> Haojian Zhuang<haojian.zhuang@gmail.com>
>> writes:
>>
>>> I missed them. Maybe I was not in the Cc list. I'll
>> append the patches
>>> to fix them.
>> Just to be sure, this is the patch which is missing for the
>> dummy clock, which
>> was not submitted before AFAIK (Jonathan, Paul, please
>> confirm).
>>
>> I added the commit text to Paul's patch, and authored it as
>> Paul's with
>> Jonathan's report. Again, Jonathan, Paul, I'd like to have
>> your agreement here.
>>
>> Haojian, if you have another patch ready, don't hesitate to
>> drop this patch and
>> take your own, as long as gpio-pxa is fixed, I'll be happy.
> I created this patch without waiting for an official fix purely to solve
> the problem for myself. I then posted it in case it would be useful to
> others. By all means use it or, if a better patch exists, drop it.
I'm carrying the exact same thing in my local tree for pxa27x so for 
that at least
I've stuck a tested-by below.  (going to loose the cam address at 
somepoint soonish
hence the kernel.org one. Really don't care though!)
>
>> Cheers.
>>
>> --
>> Robert
>>
>> 8>----
>>  From 505a23475843a8fbac077e789d911ee07e1ae9cc Mon Sep 17
>> 00:00:00 2001
>> From: Paul Parsons<lost.distance@yahoo.com>
>> Date: Sat, 3 Mar 2012 21:10:09 +0100
>> Subject: [PATCH] arch/arm: pxa add dummy clocks for gpio
>> driver
>>
>> Fix gpio driver by providing it a dummy clock. This
>> regression was introduced by the commit "ARM: pxa: add
>> dummy
>> clock for sa1100-rtc", id
>> a55b5adaf403c4d032e0871ad4ee3367782f4db6.
>>
>> Reported-by: Jonathan Cameron<jic23@cam.ac.uk>
>> Signed-off-by: Paul Parsons<lost.distance@yahoo.com>
>> Tested-by: Robert Jarzmik<robert.jarzmik@free.fr>
Tested-by: Jonathan Cameron <jic23@kernel.org>
>> ---
>>   arch/arm/mach-pxa/pxa25x.c |    1 +
>>   arch/arm/mach-pxa/pxa27x.c |    1 +
>>   2 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-pxa/pxa25x.c
>> b/arch/arm/mach-pxa/pxa25x.c
>> index 00d6eac..d8de3e5 100644
>> --- a/arch/arm/mach-pxa/pxa25x.c
>> +++ b/arch/arm/mach-pxa/pxa25x.c
>> @@ -208,6 +208,7 @@ static struct clk_lookup
>> pxa25x_clkregs[] = {
>>       INIT_CLKREG(&clk_pxa25x_gpio11,
>> NULL, "GPIO11_CLK"),
>>       INIT_CLKREG(&clk_pxa25x_gpio12,
>> NULL, "GPIO12_CLK"),
>>       INIT_CLKREG(&clk_pxa25x_mem,
>> "pxa2xx-pcmcia", NULL),
>> +    INIT_CLKREG(&clk_dummy, "pxa-gpio",
>> NULL),
>>   };
>>
>>   static struct clk_lookup pxa25x_hwuart_clkreg =
>> diff --git a/arch/arm/mach-pxa/pxa27x.c
>> b/arch/arm/mach-pxa/pxa27x.c
>> index c1673b3..a3fabc9 100644
>> --- a/arch/arm/mach-pxa/pxa27x.c
>> +++ b/arch/arm/mach-pxa/pxa27x.c
>> @@ -229,6 +229,7 @@ static struct clk_lookup
>> pxa27x_clkregs[] = {
>>       INIT_CLKREG(&clk_pxa27x_im, NULL,
>> "IMCLK"),
>>       INIT_CLKREG(&clk_pxa27x_memc, NULL,
>> "MEMCLK"),
>>       INIT_CLKREG(&clk_pxa27x_mem,
>> "pxa2xx-pcmcia", NULL),
>> +    INIT_CLKREG(&clk_dummy, "pxa-gpio",
>> NULL),
>>   };
>>
>>   #ifdef CONFIG_PM
>> -- 
>> 1.7.5.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>