From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 043CEC4332F for ; Tue, 12 Dec 2023 18:21:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YtwX9Px65rV+GZTMawqS3Wuh5H4TYmkJa+6+GyEjY0A=; b=4nBfValXXL9Gr3 8MROC/QzuTuRjIogBFlxxGJ71Gg0FVSUYI1ulpOGXKoud27RXh2zEh4b5wf/4QFpmFhF66ysNgkvm KLcxMzA8fjgriSkRoRBWfZHi+h9QR6YIIdW1ysGu/uHvQA6gIsO0+4fPBjuY0f/bpYuW8sj0cXr35 7DG6S7fj9na+0aP2CdiQ+NKnv5nAj/pDw1NiLmujUBpFqOxNfZ+ZdkjRn8uc6zp/FyBuX1DbgVSpg BJLHSGHhVCj2fPOXBC8pxykTsuQV72bURV+GhZG7meoh+T5pr0HxwmfeezJqTQoFzx3Hkbmj8diRv d8MMp4kQSUIB47Dp9VvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rD7NH-00CUJB-0k; Tue, 12 Dec 2023 18:20:55 +0000 Received: from mail-oa1-x35.google.com ([2001:4860:4864:20::35]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rD7ND-00CUIc-0z for linux-arm-kernel@lists.infradead.org; Tue, 12 Dec 2023 18:20:52 +0000 Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-20316647099so114500fac.2 for ; Tue, 12 Dec 2023 10:20:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702405249; x=1703010049; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=FDE81kuOGXddlPQChxv8quZusCqlbynJ9UhLrlhz+O8=; b=ccSaL/6sUOxV+O3fTO9eARlpKmPONErpYBS3aghIBlq4qtwr453/xJZbp6d+Rfnb8r 6wP95/jKavQ4NeB3UWZOYVs2yfCKf7P5NMNc3Gy8BbLj81uF9cfZOhTKaFf7ZNPcK7dR W66zT9LVJk+9K1roaO7UTa0qc3qipZosFPuGfsgL1lzowTSNaXcGTWjcJ8igOpfsgqq9 osTE7lC0NzqxPzG0Q6WNwrKlHdpdRKzZp6d5yzHsQPFbbdBTNY4yczsVpTjTQ2RAT6/B MSqu0UAZGdujsTvLuqAy6E7tsgn8Z5AZwgV1oKrzRtEygdBKt+fT4I/zElhHOnzUMWtU ediw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702405249; x=1703010049; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FDE81kuOGXddlPQChxv8quZusCqlbynJ9UhLrlhz+O8=; b=u1lMZCvJqlB13BTAU5KqVWVNKTF2jPTkdAr8xxTsAtxMPv5R4SthGOnLSprD6z37tY Mk79Z/DkWhayOeCIj/OaJ8dljxjv28bUZSopHWO6Tc7zj4QIlmYHpaDlJZ7ijpoh04Qf A07AhcKdEy/PPnjEHZ1TTZUFZtbeq6twi9Vp/RPReGDnd5w/jLbwUBWD8vWsgyzU0rjD 9xvPvxMpesTQWgE5TBsL+DE3CfZWwxhSRpnjLpn/adsohUd8pdcUl4fiXTugDJYxTRdg PRWQ0Sehf3Yf//Eoe9aiGGm83CUc9LmxnBuYDqdlguoaIpZxPxEIBWc8iMZIPk8eEflE /Vjg== X-Gm-Message-State: AOJu0Yx+m2bF2ncgdhPLifAnAyf7HWU9m5kAjb3LWonsJ2zZ+WCPGCjj 3OFuCyj4ef9EXRviyN3mTBM= X-Google-Smtp-Source: AGHT+IGXLWFXupo/tm4tBeTHuC5qUcoL4NqHg6JPGuiyBNYPVPEE1uHva1Z0E6nslMmzhakP+HwG5Q== X-Received: by 2002:a05:6871:798a:b0:1fb:dc3:782d with SMTP id pb10-20020a056871798a00b001fb0dc3782dmr7720211oac.55.1702405249374; Tue, 12 Dec 2023 10:20:49 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id wd15-20020a056871a58f00b001fb21cee425sm3338823oab.40.2023.12.12.10.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 10:20:48 -0800 (PST) Date: Tue, 12 Dec 2023 10:20:47 -0800 From: Guenter Roeck To: Conor Dooley Cc: Ninad Palsule , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca, keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com, johannes.holland@infineon.com, broonie@kernel.org, patrick.rudolph@9elements.com, vincent@vtremblay.dev, peteryin.openbmc@gmail.com, lakshmiy@us.ibm.com, bhelgaas@google.com, naresh.solanki@9elements.com, alexander.stein@ew.tq-group.com, festevam@denx.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-hardening@vger.kernel.org, geissonator@yahoo.com Subject: Re: [PATCH v1 2/8] dt-bindings: tpm: Add schema for TIS I2C devices Message-ID: <874d4416-86e5-48cc-9c84-97357e4caefe@roeck-us.net> References: <20231212164004.1683589-1-ninad@linux.ibm.com> <20231212164004.1683589-3-ninad@linux.ibm.com> <20231212-amusement-elevation-28e42bcccc35@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231212-amusement-elevation-28e42bcccc35@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231212_102051_344114_F551926E X-CRM114-Status: GOOD ( 24.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 12, 2023 at 05:14:26PM +0000, Conor Dooley wrote: > Hey, > > On Tue, Dec 12, 2023 at 10:39:58AM -0600, Ninad Palsule wrote: > > From: Johannes Holland > > > > Add a dt schema to support device tree bindings > > "Add bindings for..." > > > for the generic I2C > > physical layer. Refer to the TCG PC Client Platform TPM Profile (PTP) > > Specification for TPM 2.0 v1.04 Revision 14. > > > > This includes descriptions for the Nuvoton and Infineon devices. > > > > > OpenBMC-Staging-Count: 3 > > I have no idea what this is, but it needs to be removed from the patch. > > > Signed-off-by: Johannes Holland > > Signed-off-by: Joel Stanley > > Signed-off-by: Ninad Palsule > > --- > > .../bindings/security/tpm/tpm-tis-i2c.yaml | 50 +++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml > > > > diff --git a/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml b/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml > > new file mode 100644 > > index 000000000000..de1e34065748 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml > > @@ -0,0 +1,50 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/security/tpm/tpm-tis-i2c.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: I2C PTP based TPM Devices > > + > > +maintainers: > > + - Johannes Holland > > + > > +description: > > + Device Tree Bindings for I2C based Trusted Platform Module (TPM). > > s/Device Tree Bindings for //. Doesn't dt_binding_check now complain if > you have this in a title or description? > > > +properties: > > + $nodename: > > + pattern: "^tpm(@[0-9a-f]+)?$" > > + > > + compatible: > > + oneOf: > > + - description: Infineon's Trusted Platform Module (TPM) (SLB9673). > > + items: > > + - const: infineon,slb9673 > > + - const: tcg,tpm-tis-i2c > > + - description: Nuvoton's Trusted Platform Module (TPM) (NPCT75x). > > + items: > > + - const: nuvoton,npct75x > > + - const: tcg,tpm-tis-i2c > > > + - const: tcg,tpm-tis-i2c > > IMO this should be removed and this fallback should only be used in > combination with device specific compatibles, like you have here for the > infineon and nuvoton devices. As mentioned in my response to the other patch, "only" isn't sufficient since the tacoma devicetree file only references the generic entry. It would also make support for chips from other vendors unnecessarily complex. Question should in my opinion be if the non-fallback entries are really needed. Thanks, Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel