From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45D98F4180E for ; Mon, 9 Mar 2026 16:50:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uCa5E0cT/HxGsfvjRkAG8+WAJStVe5z2flz2Ygtj3Lo=; b=RiPhxTo0qr8VJrdE3aYkU7rGHD uGx6Fl48cWKNcxVPO1DSXpTF7+HZmmxK+Ah0TLxmHSjXaZ8L+999ue9MJlXKfK/5Z0l8Q015c47KO 3h3CiKML35fV3SPdwRGsV9jJRKmLB9Tt5hilIXg1tsXN+WdT83g+QA+a4MDczuPzw3P5iG0N5dz8g NDleeROcOdn9G0BdO9viAvwAJwPx1a5UMhmSIHK6t+KLFZXRGqOhYVoddl9i3LoagRn99pDxGKEVQ TgAhmP4JV5E6FXcYb0TCqrELg1jE+Y6XlC4Mtrl83/brmdYBRwXR8iAlbJ6NLc5TSlv5QRNQXoJax KF4YWPGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzdoK-00000007lNB-3anK; Mon, 09 Mar 2026 16:50:28 +0000 Received: from smtpout-02.galae.net ([185.246.84.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzdoH-00000007lMZ-1ewY; Mon, 09 Mar 2026 16:50:27 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 4479F1A2D62; Mon, 9 Mar 2026 16:50:22 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 154C15FFB8; Mon, 9 Mar 2026 16:50:22 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 86BDE10369C0E; Mon, 9 Mar 2026 17:50:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1773075021; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=uCa5E0cT/HxGsfvjRkAG8+WAJStVe5z2flz2Ygtj3Lo=; b=Xuzi6GbzaDiNcpso4+1/KP7UHSFNrQ81rvx3+kESkybunmDg+cFAM4wgTctbKObWH198RX TFoav7BOLChBSgCPOQg+IX3SWMOCELeqaHXkilooUXCU7bWaTXvVZp1/ht0PQjDV+YMBV3 T6FFVZ3etgHD9qcR8Kp8gGJKk0fhkBFrhaw43MFkxX1K8isr8E2lKXnm89kZUc+CLGw+om h36glR8Z79u6Pc3CMw0T/rJYGFfokgsuuEx9eU/KB08++uKgCgnobrFLNjBoSF1k78ADmr 53vdusBNgArh4+DOAxpAezoYygaSHQ5RmvQVdsXHno827P4WuJ+QRHI6065syw== From: Miquel Raynal To: Richard Genoud Cc: Richard Weinberger , Vignesh Raghavendra , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Wentao Liang , Maxime Ripard , Boris Brezillon , Thomas Petazzoni , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/6] mtd: rawnand: sunxi: make the code mode self-explanatory In-Reply-To: <20260305100137.2558423-6-richard.genoud@bootlin.com> (Richard Genoud's message of "Thu, 5 Mar 2026 11:01:36 +0100") References: <20260305100137.2558423-1-richard.genoud@bootlin.com> <20260305100137.2558423-6-richard.genoud@bootlin.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Mon, 09 Mar 2026 17:50:16 +0100 Message-ID: <874impne0n.fsf@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260309_095025_587762_B5767D5D X-CRM114-Status: UNSURE ( 8.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/03/2026 at 11:01:36 +01, Richard Genoud wrote: In the title: s/mode/more/? > In sunxi_nfc_hw_ecc_{read,write}_chunk(), the ECC step was force to 0, forced! > the reason is not trivial to get when reading the code. > > The explanation is that, from the NAND flash controller perspective, we > are indeed at step 0 for user data length and ECC errors. > > Just add a const value with an explanation to clarify things. >