Re: [PATCH] ALSA: hda: cix-ipbloq: Use modern PM ops

[Takashi Iwai <tiwai@suse.de>]

On Thu, 11 Dec 2025 02:50:03 +0100,
Nathan Chancellor wrote:
> 
> When building without CONFIG_PM_SLEEP, there are several warnings (or
> errors with CONFIG_WERROR=y / W=e) from the cix-ipbloq driver:
> 
>   sound/hda/controllers/cix-ipbloq.c:378:12: error: 'cix_ipbloq_hda_runtime_resume' defined but not used [-Werror=unused-function]
>     378 | static int cix_ipbloq_hda_runtime_resume(struct device *dev)
>         |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   sound/hda/controllers/cix-ipbloq.c:362:12: error: 'cix_ipbloq_hda_runtime_suspend' defined but not used [-Werror=unused-function]
>     362 | static int cix_ipbloq_hda_runtime_suspend(struct device *dev)
>         |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   sound/hda/controllers/cix-ipbloq.c:349:12: error: 'cix_ipbloq_hda_resume' defined but not used [-Werror=unused-function]
>     349 | static int cix_ipbloq_hda_resume(struct device *dev)
>         |            ^~~~~~~~~~~~~~~~~~~~~
>   sound/hda/controllers/cix-ipbloq.c:336:12: error: 'cix_ipbloq_hda_suspend' defined but not used [-Werror=unused-function]
>     336 | static int cix_ipbloq_hda_suspend(struct device *dev)
>         |            ^~~~~~~~~~~~~~~~~~~~~~
> 
> When CONFIG_PM and CONFIG_PM_SLEEP are unset, SET_SYSTEM_SLEEP_PM_OPS()
> and SET_RUNTIME_PM_OPS() evaluate to nothing, so these functions appear
> unused to the compiler in this configuration.
> 
> Use the modern SYSTEM_SLEEP_PM_OPS and RUNTIME_PM_OPS macros to resolve
> these warnings, which is what they are intended to do. Additionally,
> wrap &cix_ipbloq_hda_pm in pm_ptr() to ensure the compiler can drop the
> entire structure when CONFIG_PM is unset.
> 
> Fixes: d91e9bd10125 ("ALSA: hda: add CIX IPBLOQ HDA controller support")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Applied now.  Thanks.


Takashi