From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA613C4345F for ; Wed, 17 Apr 2024 07:52:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W64V32cvffCk4UtBOkZjSZN/3n/lZj57aFnkHOOR4uI=; b=te+DFce3pxgGwK JD7MySXThedaPeST9MIpyyks429iZjky46G6rmaySDeibosLzlj6R8BXTj+bIqzrZxBC+9K+8qvz2 JdeXb2NV5BBhs+7LYkAg+rdmQ5P7x2mRv2rWZ43dBprL3Z3/Z0X0rMd7BpuBD4nVSun4jHj5tCm+h NcPzG6F00JISffS4taPxVe7OJwOie+NmLHY1XLAAz5hfb1SsR0jLHF7mu/AM2B7aMlPhI4ABOkd1Z mpYEq03bfTvCmqgLdOqOKD5rdZN24qv+tIYSZcI0ENiaF4QYI8yT2bYZxUbcUI3t5MdvZLBTaW7Y6 2h3SdEbxySDyilm0VDKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx05I-0000000F6G3-0Yyu; Wed, 17 Apr 2024 07:52:00 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx05G-0000000F6E9-0HUU for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2024 07:51:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 95767CE1262; Wed, 17 Apr 2024 07:51:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCBDFC072AA; Wed, 17 Apr 2024 07:51:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713340307; bh=oDubD3s6K3Vp9t5I92UODI1kpQy++uUyuHq9AfWOrbE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GhZ6B9tnE/ndzP+0tBZLh/KgM/KeNvAE5JbPs68UpOYwThywd0OzzhF3lAz4I9BbG Vsw6XMGkHp0Mvztg9iYRDAmh2PaoTVSzmiJEGPcmX/XzJYN+C9mt4KOKzt0WadXI6m gN/8TOxljxdP3HIJ55EKe9HaSeKUGBOO4eXGlxdyjLO9LgFwJ9nAke+E3xP/e/CViJ HHzFolrswKs8FvWzGkyHHdwFVhSozdDsBGzauMeiq6O1Itlt8MoCy37Z87wo1aMD6i qYqisOX7t/27oMAClsrpQzIe0fsZT6C8nqou5eR4h9GxZSJXUuZy2XaRBTnUW+Kn2N keMujT677CHoQ== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rx053-005HMD-CD; Wed, 17 Apr 2024 08:51:45 +0100 Date: Wed, 17 Apr 2024 08:51:42 +0100 Message-ID: <874jc0s9yp.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Zenghui Yu , Joey Gouly , Will Deacon , Catalin Marinas Subject: Re: [PATCH v3 04/15] KVM: arm64: nv: Drop VCPU_HYP_CONTEXT flag In-Reply-To: References: <20240321155356.3236459-1-maz@kernel.org> <20240321155356.3236459-5-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, joey.gouly@arm.com, will@kernel.org, catalin.marinas@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240417_005158_308582_3C5CDF72 X-CRM114-Status: GOOD ( 17.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 16 Apr 2024 21:06:26 +0100, Oliver Upton wrote: > > On Thu, Mar 21, 2024 at 03:53:45PM +0000, Marc Zyngier wrote: > > diff --git a/arch/arm64/kvm/hyp/vhe/switch.c b/arch/arm64/kvm/hyp/vhe/switch.c > > index 1581df6aec87..58415783fd53 100644 > > --- a/arch/arm64/kvm/hyp/vhe/switch.c > > +++ b/arch/arm64/kvm/hyp/vhe/switch.c > > @@ -197,7 +197,7 @@ static void early_exit_filter(struct kvm_vcpu *vcpu, u64 *exit_code) > > * If we were in HYP context on entry, adjust the PSTATE view > > * so that the usual helpers work correctly. > > */ > > - if (unlikely(vcpu_get_flag(vcpu, VCPU_HYP_CONTEXT))) { > > + if (unlikely(read_sysreg(hcr_el2) & HCR_NV)) { > > Can this be additionally predicated on vcpu_has_nv() so we condition on > the NV cpucap and avoid the sysreg read on non-nesting hardware? Yup, good call. I'll add that. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel