From: Marc Zyngier <maz@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org,
bertrand.marquis@arm.com, boris.ostrovsky@oracle.com,
broonie@kernel.org, catalin.marinas@arm.com,
daniel.lezcano@linaro.org, james.morse@arm.com, jgross@suse.com,
oliver.upton@linux.dev, pcc@google.com, sstabellini@kernel.org,
suzuki.poulose@arm.com, tglx@linutronix.de,
vladimir.murzin@arm.com, will@kernel.org
Subject: Re: [PATCH 01/37] clocksource/drivers/arm_arch_timer: Initialize evtstrm after finalizing cpucaps
Date: Thu, 21 Sep 2023 08:41:52 +0100 [thread overview]
Message-ID: <874jjo3rcv.wl-maz@kernel.org> (raw)
In-Reply-To: <20230919092850.1940729-2-mark.rutland@arm.com>
On Tue, 19 Sep 2023 10:28:14 +0100,
Mark Rutland <mark.rutland@arm.com> wrote:
>
> We attempt to initialize each CPU's arch_timer event stream in
> arch_timer_evtstrm_enable(), which we call from the
> arch_timer_starting_cpu() cpu hotplug callback which is registered early
> in boot. As this is registered before we initialize the system cpucaps,
> the test for ARM64_HAS_ECV will always be false for CPUs present at boot
> time, and will only be taken into account for CPUs onlined late
> (including those which are hotplugged out and in again).
>
> Due to this, CPUs present and boot time may not use the intended divider
> and scale factor to generate the event stream, and may differ from other
> CPUs.
>
> Correct this by only initializing the event stream after cpucaps have been
> finalized, registering a separate CPU hotplug callback for the event stream
> configuration. Since the caps must be finalized by this point, use
> cpus_have_final_cap() to verify this.
Isn't this the same as 20230907133410.3817800-1-mark.rutland@arm.com?
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-21 7:42 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 9:28 [PATCH 00/37] arm64: Remove cpus_have_const_cap() Mark Rutland
2023-09-19 9:28 ` [PATCH 01/37] clocksource/drivers/arm_arch_timer: Initialize evtstrm after finalizing cpucaps Mark Rutland
2023-09-21 7:41 ` Marc Zyngier [this message]
2023-09-21 16:27 ` Mark Rutland
2023-09-19 9:28 ` [PATCH 02/37] arm64/arm: xen: enlighten: Fix KPTI checks Mark Rutland
2023-09-19 9:28 ` [PATCH 03/37] arm64: Factor out cpucap definitions Mark Rutland
2023-09-19 9:28 ` [PATCH 04/37] arm64: Add cpucap_is_possible() Mark Rutland
2023-09-19 9:28 ` [PATCH 05/37] arm64: Add cpus_have_final_boot_cap() Mark Rutland
2023-09-21 9:13 ` Suzuki K Poulose
2023-09-21 16:36 ` Mark Rutland
2023-09-22 10:26 ` Suzuki K Poulose
2023-10-02 10:25 ` Mark Rutland
2023-10-05 9:23 ` Mark Rutland
2023-10-05 9:39 ` Suzuki K Poulose
2023-09-19 9:28 ` [PATCH 06/37] arm64: Rework setup_cpu_features() Mark Rutland
2023-09-25 13:04 ` Suzuki K Poulose
2023-09-19 9:28 ` [PATCH 07/37] arm64: Fixup user features at boot time Mark Rutland
2023-09-19 9:28 ` [PATCH 08/37] arm64: Split kpti_install_ng_mappings() Mark Rutland
2023-09-19 9:28 ` [PATCH 09/37] arm64: kvm: Use cpus_have_final_cap() explicitly Mark Rutland
2023-09-21 7:49 ` Marc Zyngier
2023-09-19 9:28 ` [PATCH 10/37] arm64: Explicitly save/restore CPACR when probing SVE and SME Mark Rutland
2023-09-19 9:28 ` [PATCH 11/37] arm64: Rename SVE/SME cpu_enable functions Mark Rutland
2023-09-19 10:52 ` Mark Brown
2023-09-21 16:50 ` Mark Rutland
2023-09-19 9:28 ` [PATCH 12/37] arm64: Use a positive cpucap for FP/SIMD Mark Rutland
2023-09-19 11:21 ` Mark Brown
2023-09-19 9:28 ` [PATCH 13/37] arm64: Avoid cpus_have_const_cap() for ARM64_HAS_{ADDRESS,GENERIC}_AUTH Mark Rutland
2023-09-19 9:28 ` [PATCH 14/37] arm64: Avoid cpus_have_const_cap() for ARM64_HAS_ARMv8_4_TTL Mark Rutland
2023-09-19 9:28 ` [PATCH 15/37] arm64: Avoid cpus_have_const_cap() for ARM64_HAS_BTI Mark Rutland
2023-09-19 11:23 ` Mark Brown
2023-09-19 9:28 ` [PATCH 16/37] arm64: Avoid cpus_have_const_cap() for ARM64_HAS_CACHE_DIC Mark Rutland
2023-09-19 9:28 ` [PATCH 17/37] arm64: Avoid cpus_have_const_cap() for ARM64_HAS_CNP Mark Rutland
2023-09-19 9:28 ` [PATCH 18/37] arm64: Avoid cpus_have_const_cap() for ARM64_HAS_DIT Mark Rutland
2023-09-19 9:28 ` [PATCH 19/37] arm64: Avoid cpus_have_const_cap() for ARM64_HAS_GIC_PRIO_MASKING Mark Rutland
2023-09-19 9:28 ` [PATCH 20/37] arm64: Avoid cpus_have_const_cap() for ARM64_HAS_PAN Mark Rutland
2023-09-19 9:28 ` [PATCH 21/37] arm64: Avoid cpus_have_const_cap() for ARM64_HAS_EPAN Mark Rutland
2023-09-19 9:28 ` [PATCH 22/37] arm64: Avoid cpus_have_const_cap() for ARM64_HAS_RNG Mark Rutland
2023-09-19 11:24 ` Mark Brown
2023-09-19 9:28 ` [PATCH 23/37] arm64: Avoid cpus_have_const_cap() for ARM64_HAS_WFXT Mark Rutland
2023-09-19 9:28 ` [PATCH 24/37] arm64: Avoid cpus_have_const_cap() for ARM64_HAS_TLB_RANGE Mark Rutland
2023-09-19 9:28 ` [PATCH 25/37] arm64: Avoid cpus_have_const_cap() for ARM64_MTE Mark Rutland
2023-09-19 9:28 ` [PATCH 26/37] arm64: Avoid cpus_have_const_cap() for ARM64_SSBS Mark Rutland
2023-09-19 9:28 ` [PATCH 27/37] arm64: Avoid cpus_have_const_cap() for ARM64_SPECTRE_V2 Mark Rutland
2023-09-19 9:28 ` [PATCH 28/37] arm64: Avoid cpus_have_const_cap() for ARM64_{SVE,SME,SME2,FA64} Mark Rutland
2023-09-19 11:27 ` Mark Brown
2023-09-19 9:28 ` [PATCH 29/37] arm64: Avoid cpus_have_const_cap() for ARM64_UNMAP_KERNEL_AT_EL0 Mark Rutland
2023-09-19 9:28 ` [PATCH 30/37] arm64: Avoid cpus_have_const_cap() for ARM64_WORKAROUND_843419 Mark Rutland
2023-09-19 9:28 ` [PATCH 31/37] arm64: Avoid cpus_have_const_cap() for ARM64_WORKAROUND_1542419 Mark Rutland
2023-09-19 9:28 ` [PATCH 32/37] arm64: Avoid cpus_have_const_cap() for ARM64_WORKAROUND_1742098 Mark Rutland
2023-09-19 9:28 ` [PATCH 33/37] arm64: Avoid cpus_have_const_cap() for ARM64_WORKAROUND_2645198 Mark Rutland
2023-09-19 9:28 ` [PATCH 34/37] arm64: Avoid cpus_have_const_cap() for ARM64_WORKAROUND_CAVIUM_23154 Mark Rutland
2023-09-19 9:28 ` [PATCH 35/37] arm64: Avoid cpus_have_const_cap() for ARM64_WORKAROUND_NVIDIA_CARMEL_CNP Mark Rutland
2023-09-19 9:28 ` [PATCH 36/37] arm64: Avoid cpus_have_const_cap() for ARM64_WORKAROUND_REPEAT_TLBI Mark Rutland
2023-09-19 9:28 ` [PATCH 37/37] arm64: Remove cpus_have_const_cap() Mark Rutland
2023-10-03 17:20 ` Kristina Martsenko
2023-10-05 9:35 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jjo3rcv.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=ardb@kernel.org \
--cc=bertrand.marquis@arm.com \
--cc=boris.ostrovsky@oracle.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=james.morse@arm.com \
--cc=jgross@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=oliver.upton@linux.dev \
--cc=pcc@google.com \
--cc=sstabellini@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=vladimir.murzin@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).