From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4048ACD5BD5 for ; Thu, 21 Sep 2023 07:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ymtRc6614iVK2dsXLaKtMmsLJkyuIZIkXYS2wq/jmAI=; b=wGESfKLwK8R21r DhJHKZDUnTK5bQZCpnKYHRgQu1nWOOrLu2ZSCY0SRDIr5lKlCg4GxlWHEB512G6MfZVliR8RAWy01 Fgx+TygqCOUWAaBKZNVWXpgVYhUYrufUkHp7kcPNXy5VveLNxowvV09qqJX9+FPNuHVMNDfkPNOSK lFL+ZaoMEQKf6sn47lwy90F/0UyRb79ctvjwYokjB2rr3jNbqB9go6rd0HWXnSKJtwOm4QhY5wAY2 nB7dx63+z5x+yblsbsOVoQ2Sc9100plKWd8aWkugYxTy549diq8vi58bnNFADnH46pRVz4sOxFIv3 EOFuCh6HajOrrPl84Z8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjEK5-005OKJ-17; Thu, 21 Sep 2023 07:42:05 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qjEK2-005OJv-2o for linux-arm-kernel@lists.infradead.org; Thu, 21 Sep 2023 07:42:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3556661E06; Thu, 21 Sep 2023 07:42:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BD32C43142; Thu, 21 Sep 2023 07:42:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695282121; bh=miGWF//8X4V8u+fF0BfnaYyZxkKwVohvZlfz+IwA6PM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aP5fSclZY0ORE2XsRpqXUQtJ9R3hvnobKclEji/s8zhH1ZAP6okMlsOpfGEmgujjZ NZK/mtNph4WPZXKZ1a7UWjCKiPm9lvUaNknNBjL4k3bt+vZpphuZjazcqN55dEMvhk YuemX5RYMj2swfokFAPsp94t1j8mpC/P9KlSYXQxgqAFsZdy11T8UnHtRrBi1vsDvY v9hAFVuBlZ2kONoDmJBW26sFS/7yTG+iogDScF9EQmauCY5sfcfRfjSqeP1pB8AqIE txXMIra5DZZgMpE+9uWtSVee9wLFUkM2ehouM6XL+Nt7PP4QhHHgaAFxDVttVPvSbg i8aZl16fhn/JA== Received: from 82-132-232-12.dab.02.net ([82.132.232.12] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qjEJy-00Es74-He; Thu, 21 Sep 2023 08:41:59 +0100 Date: Thu, 21 Sep 2023 08:41:52 +0100 Message-ID: <874jjo3rcv.wl-maz@kernel.org> From: Marc Zyngier To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org, bertrand.marquis@arm.com, boris.ostrovsky@oracle.com, broonie@kernel.org, catalin.marinas@arm.com, daniel.lezcano@linaro.org, james.morse@arm.com, jgross@suse.com, oliver.upton@linux.dev, pcc@google.com, sstabellini@kernel.org, suzuki.poulose@arm.com, tglx@linutronix.de, vladimir.murzin@arm.com, will@kernel.org Subject: Re: [PATCH 01/37] clocksource/drivers/arm_arch_timer: Initialize evtstrm after finalizing cpucaps In-Reply-To: <20230919092850.1940729-2-mark.rutland@arm.com> References: <20230919092850.1940729-1-mark.rutland@arm.com> <20230919092850.1940729-2-mark.rutland@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 82.132.232.12 X-SA-Exim-Rcpt-To: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, ardb@kernel.org, bertrand.marquis@arm.com, boris.ostrovsky@oracle.com, broonie@kernel.org, catalin.marinas@arm.com, daniel.lezcano@linaro.org, james.morse@arm.com, jgross@suse.com, oliver.upton@linux.dev, pcc@google.com, sstabellini@kernel.org, suzuki.poulose@arm.com, tglx@linutronix.de, vladimir.murzin@arm.com, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230921_004202_989594_BDA1C274 X-CRM114-Status: GOOD ( 19.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 19 Sep 2023 10:28:14 +0100, Mark Rutland wrote: > > We attempt to initialize each CPU's arch_timer event stream in > arch_timer_evtstrm_enable(), which we call from the > arch_timer_starting_cpu() cpu hotplug callback which is registered early > in boot. As this is registered before we initialize the system cpucaps, > the test for ARM64_HAS_ECV will always be false for CPUs present at boot > time, and will only be taken into account for CPUs onlined late > (including those which are hotplugged out and in again). > > Due to this, CPUs present and boot time may not use the intended divider > and scale factor to generate the event stream, and may differ from other > CPUs. > > Correct this by only initializing the event stream after cpucaps have been > finalized, registering a separate CPU hotplug callback for the event stream > configuration. Since the caps must be finalized by this point, use > cpus_have_final_cap() to verify this. Isn't this the same as 20230907133410.3817800-1-mark.rutland@arm.com? M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel