From: Marc Zyngier <maz@kernel.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
john@phrozen.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 03/14] ARM: dts: Add basic support for Airoha EN7523
Date: Wed, 22 Dec 2021 18:07:44 +0000 [thread overview]
Message-ID: <874k701pjj.wl-maz@kernel.org> (raw)
In-Reply-To: <a83c5c25-c3f9-fbf9-93a9-39e763590c6e@nbd.name>
On Wed, 22 Dec 2021 16:04:07 +0000,
Felix Fietkau <nbd@nbd.name> wrote:
>
>
> On 2021-12-21 16:02, Marc Zyngier wrote:
> > On 2021-12-20 21:18, Felix Fietkau wrote:
> >> From: John Crispin <john@phrozen.org>
> >>
> >> Add basic support for Airoha EN7523, enough for booting to console.
> >>
> >> The UART is basically 8250-compatible, except for the clock selection.
> >> A clock-frequency value is synthesized to get this to run at 115200
> >> bps.
> >>
> >> Signed-off-by: John Crispin <john@phrozen.org>
> >> Signed-off-by: Bert Vermeulen <bert@biot.com>
> >> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> >> ---
> >> arch/arm/boot/dts/Makefile | 2 +
> >> arch/arm/boot/dts/en7523-evb.dts | 27 ++++++++
> >> arch/arm/boot/dts/en7523.dtsi | 114 +++++++++++++++++++++++++++++++
> >> 3 files changed, 143 insertions(+)
> >> create mode 100644 arch/arm/boot/dts/en7523-evb.dts
> >> create mode 100644 arch/arm/boot/dts/en7523.dtsi
> >>
> >
> > [...]
> >
> >> + gic: interrupt-controller@9000000 {
> >> + compatible = "arm,gic-v3";
> >> + interrupt-controller;
> >> + #interrupt-cells = <3>;
> >> + #address-cells = <1>;
> >> + #size-cells = <1>;
> >> + reg = <0x09000000 0x20000>, <0x09080000 0x80000>;
> >
> > You are missing the 3 extra regions implemented by the A53 cores
> > (GICC, GICV, GICH). Please see the binding and the A53 TRM.
> The SoC memory map documentation contains an address for GICC, but not
> for the other two. Maybe this CPU doesn't implement them.
Please read the CPU TRM (it is publicly available from the ARM web
site). GICC, GICV and GICH are all at a fixed offset form each other,
and are always implemented by the A53 when connected to a GICv3.
> I will add GICC in v9
Please add all 3 missing regions.
>
> >> + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_LOW>;
> >> + };
> >> +
> >> + timer {
> >> + compatible = "arm,armv7-timer";
> >
> > This is an ARMv8 CPU, even when used in 32bit mode.
> >
> >> + interrupt-parent = <&gic>;
> >> + interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
> >> + <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>,
> >> + <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
> >> + <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
> >> + clock-frequency = <25000000>;
> >
> > Why isn't this properly configured by the firmware?
> I don't know.
Then drop it.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-22 18:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 21:18 [PATCH v8 00/14] Add support for Airoha EN7523 SoC Felix Fietkau
2021-12-20 21:18 ` [PATCH v8 01/14] dt-bindings: Add vendor prefix for Airoha Felix Fietkau
2021-12-29 14:47 ` Matthias Brugger
2021-12-20 21:18 ` [PATCH v8 02/14] dt-bindings: arm: airoha: Add binding for EN7523 SoC and EVB Felix Fietkau
2021-12-29 14:48 ` Matthias Brugger
2021-12-20 21:18 ` [PATCH v8 03/14] ARM: dts: Add basic support for Airoha EN7523 Felix Fietkau
2021-12-21 15:02 ` Marc Zyngier
2021-12-22 16:04 ` Felix Fietkau
2021-12-22 18:07 ` Marc Zyngier [this message]
2021-12-20 21:18 ` [PATCH v8 04/14] ARM: Add basic support for Airoha EN7523 SoC Felix Fietkau
2021-12-29 15:22 ` Matthias Brugger
2021-12-20 21:18 ` [PATCH v8 05/14] ARM: multi_v7_defconfig: Add " Felix Fietkau
2021-12-20 21:18 ` [PATCH v8 06/14] dt-bindings: Add en7523-scu device tree binding documentation Felix Fietkau
2021-12-20 21:18 ` [PATCH v8 07/14] clk: en7523: Add clock driver for Airoha EN7523 SoC Felix Fietkau
2021-12-21 14:06 ` Arnd Bergmann
2021-12-22 15:35 ` Felix Fietkau
2021-12-20 21:18 ` [PATCH v8 08/14] ARM: dts: add clock support for Airoha EN7523 Felix Fietkau
2021-12-20 21:18 ` [PATCH v8 09/14] dt-bindings: PCI: Add support for Airoha EN7532 Felix Fietkau
2021-12-20 21:18 ` [PATCH v8 10/14] PCI: mediatek: Allow building for ARCH_AIROHA Felix Fietkau
2022-01-05 14:50 ` Lorenzo Pieralisi
2021-12-20 21:18 ` [PATCH v8 11/14] ARM: dts: Add PCIe support for Airoha EN7523 Felix Fietkau
2021-12-20 21:18 ` [PATCH v8 12/14] dt-bindings: arm: airoha: Add binding for Airoha GPIO controller Felix Fietkau
2021-12-20 21:18 ` [PATCH v8 13/14] gpio: Add support for Airoha EN7523 " Felix Fietkau
2021-12-21 13:49 ` Arnd Bergmann
2021-12-22 2:34 ` Linus Walleij
2021-12-22 7:56 ` Bartosz Golaszewski
2021-12-22 12:03 ` Andy Shevchenko
2021-12-20 21:18 ` [PATCH v8 14/14] ARM: dts: add GPIO support for Airoha EN7523 Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k701pjj.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).