From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EC3AC433B4 for ; Wed, 5 May 2021 17:05:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5662E613C0 for ; Wed, 5 May 2021 17:05:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5662E613C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QZTBLOGVy2a86uOz8CaLc1PpWiiolzFe7WvG5HP7FVw=; b=ANERcH5jAgQ4TvyhcDXqpb8Hg myn8a/OuxpE3IKvmWC+KI2zyqk+E4cFety3BoC0WvOYzjYYkDer+/yAWpogv+5YPto0LQZF1anpzL QKtRNJ50FMGVtvEEcX7C8kZ0xao3+RfMy6inV4Yu50dtTSrfn/zFztfI2WZW/sL0UNby6IE+Ot4AM QVLTDSAUNdJLF4l3WR1LVNBoWiQRwnSy1MVF0v0Dl1NzFZHHYshQy1mXEmeMA/7NEW6EvFPnH7Dxt 1FpsYqK9j3kNF4jqFpCmxnddtyPEq4Anh10bwdN/8hhuMEMnORM5L0wjIP09e1bo4oPdpIm8uBil9 L0usALY8w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leKw3-001qJM-43; Wed, 05 May 2021 17:03:43 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leKhm-001kyQ-9H for linux-arm-kernel@desiato.infradead.org; Wed, 05 May 2021 16:48:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KicrfFYGNILo9WrgV2Dzcga43EgqwpHeugJeD+O4doI=; b=BTaRVHTdxqBMrFr3Px/5sHAB+9 gK6OesZvd6UMRT2uC1fa8hf0fjp+hQD1pYZzz4Hm6WZ/mEXKTvNOkxg8Xad0Y/LtZ2DOpwffLCqkD mgwmiJixymc7b+ZPNptyor5+alD/5QvaxmkIvTzrKZ2U7rQxR6e5jPoQdT3/xVW1Ne8u5rsoospyE yOZ8v7bBDvgEM7OX+PslgkBCqa6NcFvkSpiQYwLs/fQSDjNTBNnj17M/fLP++c0vS6aGThjulYTSC 95xS6X9zqsG4TPmkh9EE1iIo9i3QTf+zvQ/AGhe8lkkVr/L6muyx2spzemVPfnZG8VlErqbBj5PgP v6nW2sNA==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leKhj-004zQ2-9r for linux-arm-kernel@lists.infradead.org; Wed, 05 May 2021 16:48:57 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E679D610FB; Wed, 5 May 2021 16:48:54 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1leKhg-00B3AR-80; Wed, 05 May 2021 17:48:52 +0100 Date: Wed, 05 May 2021 17:48:51 +0100 Message-ID: <874kfhnn2k.wl-maz@kernel.org> From: Marc Zyngier To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Andrew Scull , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH AUTOSEL 5.11 036/104] KVM: arm64: Use BUG and BUG_ON in nVHE hyp In-Reply-To: <20210505163413.3461611-36-sashal@kernel.org> References: <20210505163413.3461611-1-sashal@kernel.org> <20210505163413.3461611-36-sashal@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: sashal@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, ascull@google.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_094855_384443_122F810B X-CRM114-Status: GOOD ( 16.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sasha, On Wed, 05 May 2021 17:33:05 +0100, Sasha Levin wrote: > > From: Andrew Scull > > [ Upstream commit f79e616f27ab6cd74deb0995a8eead3d1c9d65af ] > > hyp_panic() reports the address of the panic by using ELR_EL2, but this > isn't a useful address when hyp_panic() is called directly. Replace such > direct calls with BUG() and BUG_ON() which use BRK to trigger an > exception that then goes to hyp_panic() with the correct address. Also > remove the hyp_panic() declaration from the header file to avoid > accidental misuse. > > Signed-off-by: Andrew Scull > Acked-by: Will Deacon > Signed-off-by: Marc Zyngier > Link: https://lore.kernel.org/r/20210318143311.839894-5-ascull@google.com > Signed-off-by: Sasha Levin This has no chance of working without the patches that enable BUG() support at EL2, and *really* isn't stable material. Please drop this patch. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel