From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25FA6C433ED for ; Sat, 10 Apr 2021 19:05:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D2F9610D1 for ; Sat, 10 Apr 2021 19:05:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D2F9610D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pkp40Znl2eUhMsKMrA0/wAW3LxsuyxYHGlPa8E4tCiI=; b=kc8AUJF47sskwenHV/XRNpFC6 kEONcp3feNzOIAkpOqhub1yz3L0l9gmHIC3vtGQeY6/F4r9fSbUFmzHQF3sxdc5R8LqyqGqaQIFk3 2AXLBMqP3dWD90nMf7g1hHKVivnucN7kFtozOOVeMv2MwI1ZqBbyWXtxV3uekB5XKXPds/CDpgTqO plaEabogLb94o0Xjjtnpzw2Qs9rmxh3HzGgn0dQxDjhyE5VrEKRY+/KSMor2RhBa2qG0ioG9iFgsk iGAS2i3p2nb3g+s4Tj6JIU1Q4loiuhfeXrYwgwFppZC6s+t/Vsq614HF9955hluPvgjsNU5RuKo7H ejuryG3/Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVIto-003IdW-HQ; Sat, 10 Apr 2021 19:04:04 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVItk-003Id3-JG for linux-arm-kernel@desiato.infradead.org; Sat, 10 Apr 2021 19:04:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jjhbtLOpEZ2jLp0mUHsDC7Zq8/pCU2TXX1rQuKoiPZo=; b=bJEu39wgIbwhGA+yd5YowiWA4Q U67YbwLji1dOksUH5RohfCk50Chx02cOYQB+MlubMx5ez/BEpLE+IY9ZPwLFWMO43dImG8LkMpO/Q acq10F4LfRNV1izXejpiPFdeBvdC42bwZja0MPSGdWVOH/XSk1u8rmtNY8Fs9JZiuyj8+iu77DJ2j pSAqL18yBeL4l4kwrEBeemmdw+HY+IcgJXlo1Qpxzt+UK/08WOlrqSYonSkVNbdzXrEvuW6z2neRn whhTae6K4gXXgTVnI5vRVmeiNh8N+7dy5cHor9MtmY9/FI6e5J1q3S41edDNyeTBQ6erQ0sfw730B vNSSLPyw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVIth-005Dyp-DT for linux-arm-kernel@lists.infradead.org; Sat, 10 Apr 2021 19:03:58 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6837D610D1; Sat, 10 Apr 2021 19:03:56 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lVIte-006kBh-Aj; Sat, 10 Apr 2021 20:03:54 +0100 Date: Sat, 10 Apr 2021 20:03:53 +0100 Message-ID: <874kgeezc6.wl-maz@kernel.org> From: Marc Zyngier To: Edmundo Carmona Antoranz Cc: catalin.marinas@arm.com, will@kernel.org, avagin@gmail.com, 0x7f454c46@gmail.com, mark.rutland@arm.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH -next] arm64: vdso: correct definition of macro vdso_clocksource_ok In-Reply-To: <20210410181117.23967-1-eantoranz@gmail.com> References: <20210410181117.23967-1-eantoranz@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: eantoranz@gmail.com, catalin.marinas@arm.com, will@kernel.org, avagin@gmail.com, 0x7f454c46@gmail.com, mark.rutland@arm.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210410_120357_491342_D21E1659 X-CRM114-Status: GOOD ( 13.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Edmundo, On Sat, 10 Apr 2021 19:11:17 +0100, Edmundo Carmona Antoranz wrote: > > The macro vdso_clocksource_ok is shadowing a function with the same > name and so it actually makes no difference to have the macro defined > or not. No difference? Have you simply tried removing the macro and witness the effect? If it made no difference, why have the macro at all then? Also, run this, for example: git grep '^\#define' arch/arm64/include/asm/| awk '$2 == $3 { print }' Are you going to "fix" these too? Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel