From: Baruch Siach <baruch@tkos.co.il>
To: Sven Auhagen <sven.auhagen@voleatech.de>
Cc: linux-arm-kernel@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: CP110 Comphy Issue
Date: Sun, 24 Nov 2019 09:31:06 +0200 [thread overview]
Message-ID: <874kythgsl.fsf@tarshish> (raw)
In-Reply-To: <7BB0B44E-A78D-4DDF-962E-5C8130B6F31A@voleatech.de>
Hi Sven, Miquel,
On Sun, Nov 24 2019, Sven Auhagen wrote:
> I am testing Kernel 5.4 RC8 with the new CP110 comphy initialization
> and it does not work for our custom board on CP 1 PCIE0.
>
> It hangs on phy up indefinitely during boot.
>
> CP0 PCIE0 works fine.
>
> I am using:
> +&cp1_pcie0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&cp0_pci1_reset_pins>;
> + num-lanes = <1>;
> + //num-viewport = <8>;
> + reset-gpios = <&cp0_gpio2 1 GPIO_ACTIVE_LOW>;
> + //rx-disable-gpio = <&cp0_gpio2 20 GPIO_ACTIVE_LOW>;
> + phys = <&cp1_comphy0 0>;
> + phy-names = "cp1-pcie0-x1-phy";
> + status = "okay";
> +};
>
> And this one works
>
> +&cp0_pcie0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&cp0_pci0_reset_pins>;
> + num-lanes = <1>;
> + //num-viewport = <8>;
> + reset-gpios = <&cp0_gpio2 0 GPIO_ACTIVE_LOW>;
> + //rx-disable-gpio = <&cp0_gpio2 19 GPIO_ACTIVE_LOW>;
> + phys = <&cp0_comphy0 0>;
> + phy-names = "cp0-pcie0-x1-phy";
> + status = "okay";
> +};
> +
>
> I am using u-boot 2019.04 and ATF 2.1.
> PCIe is initialized by U-Boot.
>
> I was using a ported version of the comphy code from the marvell linux
> github before which did not have this problem.
>
> Let me know if I can debug anything here on my end.
One important bit of missing information is that the board is based on
Armada 8040.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-24 7:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 7:07 CP110 Comphy Issue Sven Auhagen
2019-11-24 7:31 ` Baruch Siach [this message]
2019-11-24 14:18 ` Miquel Raynal
2019-11-24 16:21 ` Sven Auhagen
2019-11-25 8:24 ` Sven Auhagen
2019-11-25 15:12 ` Miquel Raynal
[not found] <4EC81A7A-C1D1-4DDD-BD09-88D46BC0D058@voleatech.de>
2019-11-27 11:06 ` Miquel Raynal
2019-11-27 11:44 ` Sven Auhagen
2019-11-28 7:47 ` Sven Auhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kythgsl.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=sven.auhagen@voleatech.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).