From: arnaud.patard@rtp-net.org (Arnaud Patard (Rtp))
To: linux-arm-kernel@lists.infradead.org
Subject: [patch 1/1] iMX51: introduce MX51_GPIO_NR
Date: Wed, 24 Nov 2010 17:28:27 +0100 [thread overview]
Message-ID: <874ob6y9ck.fsf@lechat.rtp-net.org> (raw)
In-Reply-To: <20101124052128.GA15971@sahyadri-mini10> (Amit Kucheria's message of "Wed, 24 Nov 2010 10:51:28 +0530")
Amit Kucheria <amit.kucheria@linaro.org> writes:
[...]
>> Index: gpionr/arch/arm/plat-mxc/include/mach/iomux-mx51.h
>> ===================================================================
>> --- gpionr.orig/arch/arm/plat-mxc/include/mach/iomux-mx51.h 2010-11-22 23:04:23.000000000 +0100
>> +++ gpionr/arch/arm/plat-mxc/include/mach/iomux-mx51.h 2010-11-22 23:04:25.000000000 +0100
>> @@ -15,6 +15,8 @@
>>
>> #include <mach/iomux-v3.h>
>>
>
> Please add a comment here that bank numbers start from 1 to make it explicit
>
ok.
>> +#define MX51_GPIO_NR(bank, nr) ((bank-1)*32+nr)
>> +
> ^^^^^^^^^ whitespace fixes
>
> Also, why is this in iomux-mx51.h?
Because I thought it was a good place to put it. fwiw, I've no strong opinion
on where to put it.
> It might be better to introduce a gpio.h
Introduce a gpio.h ? There's already one: arch/arm/plat-mxc/include/mach/gpio.h
So, you prefer to see this macro in it ?
Arnaud
next prev parent reply other threads:[~2010-11-24 16:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 22:45 [patch 1/1] iMX51: introduce MX51_GPIO_NR Arnaud Patard (Rtp)
2010-11-24 5:21 ` Amit Kucheria
2010-11-24 7:46 ` Lothar Waßmann
2010-11-24 16:28 ` Arnaud Patard (Rtp) [this message]
2010-11-24 16:49 ` Fabio Estevam
2010-11-24 17:04 ` Arnaud Patard (Rtp)
2010-11-24 23:06 ` Richard Zhao
2010-11-25 8:24 ` Sascha Hauer
2010-11-25 8:52 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ob6y9ck.fsf@lechat.rtp-net.org \
--to=arnaud.patard@rtp-net.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).