From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1359C43381 for ; Sat, 16 Mar 2019 22:31:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7108F218D4 for ; Sat, 16 Mar 2019 22:31:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iRRfSM31" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7108F218D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Message-ID:MIME-Version:To:Date :From:In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=hY++Qk7WNdn4NygVv6a1VQc1EB2Xlf7qvCn2weFl/xg=; b=iRRfSM316im/iy xgYzlJmRhmAubh+tbsRYMEoOsfzr/HItEsCLbKWw2c9oPyVzwlzO/yosb3xv9hPSNEfK6tc8isMfd +V3aLHaGj/c4sJ7dddocBhvimh4skNphuj0W8aLxk7l9lg4KExVVwjxdj8p0VF00qVtaJIaEdbA2r wJPTuhQb90l+sTqDdv9PXakfHjqFHNrkF+L46xei0dlgUo4D+rXN8yU04PLhGkElNfpZEloqB5ZJ/ WLUg2KnKhYnUw9Ickht05U9OSYw0DquGMYtm/HYgiswlpW++IKq1JNntMyt2WBY0XbzIV9EIYnzNZ pFeN+v93qYajyMNv3F0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5HqJ-00021y-0s; Sat, 16 Mar 2019 22:31:51 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5HqF-00021a-Iu; Sat, 16 Mar 2019 22:31:49 +0000 Received: from turkeyburger.collabora.co.uk (turkeyburger.collabora.co.uk [46.235.227.230]) by bhuna.collabora.co.uk (Postfix) with ESMTP id 028DB2807B9; Sat, 16 Mar 2019 22:31:43 +0000 (GMT) In-Reply-To: <20190315033140.GB1671@sol.localdomain> From: "Ezequiel Garcia" X-Forward: 186.225.233.158 Date: Sat, 16 Mar 2019 22:31:43 +0000 To: "Eric Biggers" , "Gael Portay" MIME-Version: 1.0 Message-ID: <875-5c8d7980-7-55088a00@27384378> Subject: =?utf-8?q?Re=3A?==?utf-8?q?_=5BBug=5D?= Rockchip crypto driver sometimes produces wrong ciphertext User-Agent: SOGoMail 4.0.7 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190316_153147_886676_E2F9C655 X-CRM114-Status: GOOD ( 13.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tao Huang , Zain Wang , Heiko Stuebner , Arnd Bergmann , Ard Biesheuvel , Zhang Zhijie , linux-rockchip@lists.infradead.org, =?utf-8?q?open_list=3AHARDWARE_RANDOM_NUMBER_GENERATOR_CORE?= , Olof Johansson , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Adding my colleague Gael, who has been working on fixing this driver. On Friday, March 15, 2019 00:31 -03, Eric Biggers wrote: > Hi Zhang, > > On Mon, Jan 28, 2019 at 11:14:32AM +0800, Tao Huang wrote: > > Hi Eric and Heiko: > > > > >> On Sat, 26 Jan 2019 at 22:05, Eric Biggers wrote: > > >>> > > >>> Hello, > > >>> > > >>> I don't know whether anyone is actually maintaining the Rockchip crypto driver > > >>> in drivers/crypto/rockchip/, but it's failing the improved crypto tests > > >>> that I currently have out for review: https://patchwork.kernel.org/cover/10778089/ > > > > Zhang Zhijie, engineer from Rockchip, will try to fix this software bug. > > > > >>> > > >>> See the boot logs for RK3288 from the KernelCI job here: > > >>> > > >>> https://storage.kernelci.org/ardb/for-kernelci/v5.0-rc1-86-geaffe22db9d1/arm/multi_v7_defconfig/lab-collabora/boot-rk3288-rock2-square.txt > > >>> https://storage.kernelci.org/ardb/for-kernelci/v5.0-rc1-86-geaffe22db9d1/arm/multi_v7_defconfig/lab-collabora/boot-rk3288-veyron-jaq.txt > > >>> > > >>> alg: skcipher: ecb-aes-rk encryption test failed (wrong result) on test vector 0, cfg=\"random: use_digest src_divs=[15.64%@+3258, 84.36%@+4059] dst_divs=[69.11%@+1796, 8.49%@+4027, 6.34%@+1, 16.6%@+4058] iv_offset=21\" > > >>> alg: skcipher: cbc-aes-rk encryption test failed (wrong result) on test vector 0, cfg=\"random: may_sleep use_digest src_divs=[100.0%@alignmask+3993] dst_divs=[65.31%@alignmask+1435, 34.69%@+14]\" > > >>> alg: skcipher: ecb-des-rk encryption test failed (wrong result) on test vector 0, cfg=\"random: may_sleep use_final src_divs=[ 66.52%@+11, 33.48%@+1519] dst_divs=[58.82%@+1, 19.43%@+4082, 21.75%@+8]\" > > >>> alg: skcipher: cbc-des-rk encryption test failed (wrong result) on test vector 0, cfg=\"random: may_sleep use_finup src_divs=[100.0%@+3980] dst_divs=[60.4%@+3763, 23.9%@+4011, 16.87%@+4046]\" > > >>> alg: skcipher: ecb-des3-ede-rk encryption test failed (wrong result) on test vector 0, cfg=\"random: may_sleep use_digest src_divs=[100.0%@+4] dst_divs=[47.25%@+19, 14.83%@+22, 37.92%@+31]\" > > >>> alg: skcipher: cbc-des3-ede-rk encryption test failed (wrong result) on test vector 0, cfg=\"two even aligned splits\" > > >>> > > >>> In other words: the ecb-aes-rk, cbc-aes-rk, ecb-des-rk, cbc-des-rk, > > >>> ecb-des3-ede-rk, and cbc-des3-ede-rk algorithms are failing because they produce > > >>> the wrong ciphertext on some scatterlist layouts. > > >>> > > >>> You can reproduce by pulling from > > >>> https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git > > >>> branch "testmgr-improvements", unsetting CONFIG_CRYPTO_MANAGER_DISABLE_TESTS, > > >>> setting CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y, rebooting and checking dmesg. > > >>> > > >>> Note that I don't have this hardware myself, so if it turns out that no one is > > >>> interested in fixing this anytime soon I'll instead have to propose disabling > > >>> these algorithms until they can be fixed. > > >>> > > >>> Thanks, > > >>> > > >>> - Eric > > >> > > Thanks for the fixes, but I've improved the self-tests more, and there is > another bug. See the KernelCI job here: > > https://kernelci.org/boot/all/job/ardb/branch/for-kernelci/kernel/v5.0-11071-g7d597cc3f0ef/ > > The self-tests are failing on the rk3288-rock2-square platform: > > alg: skcipher: cbc-aes-rk encryption test failed (wrong output IV) on test vector 0, cfg=\"in-place\" > alg: skcipher: cbc-des-rk encryption test failed (wrong output IV) on test vector 0, cfg=\"in-place\" > alg: skcipher: cbc-des3-ede-rk encryption test failed (wrong output IV) on test vector 0, cfg=\"in-place\" > > The issue is that the self-tests now verify that CBC implementations update the > IV buffer to contain the next IV, aka the last ciphertext block. But the > Rockchip crypto driver doesn't do that, so it needs to be fixed. > > This has always been a requirement for CBC implementations so that users can > chain CBC requests. Unfortunately it was just never tested for... > > This should be easily reproducible using the mainline kernel. > > - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel