From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75CFAC433DF for ; Mon, 10 Aug 2020 12:26:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 455A520734 for ; Mon, 10 Aug 2020 12:26:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dKnmIj8b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 455A520734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Crx/gDTIUc9qh1ArqWXYSMVzmIhKj56xzG2wbO3a2qs=; b=dKnmIj8bN80dYbypC1ZbAqULm 0pfCdq10wgDOvfteIbuoKoaacI2NSXA91La8gpLysKR9UbbMCzjMMhHQo4dtHRdZenCInnOeIY3sB DWB4OMr5s6Qk7KIcSthEAaFkhfpV6sqo+usVqapEI3ihXcZh/8ZV8YtFmmQmwb8i3Ug4yFAJWWlMM ewGUc/H6knmvfsQ7SaC9zL6/evBAJI085+zJLlAYOk/2u6sJ8cewqynFpS3ZiCdmOdjKNI9Astvo5 TPLhWhMT3ap3cEDGShMiMTUHtc4BcecYgTWxFBdOsj9vH5PFDxR6MEA7A3Q0xlJIwXhCmNc0EBS31 6sPG/JdqQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k56rt-0002EM-RM; Mon, 10 Aug 2020 12:25:33 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k56rr-0002DT-68 for linux-arm-kernel@lists.infradead.org; Mon, 10 Aug 2020 12:25:31 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: gtucker) with ESMTPSA id 0840B2935C0 Subject: Re: [PATCH 1/3] ARM: exynos: clear L220_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val To: Russell King - ARM Linux admin , Krzysztof Kozlowski References: <860eb8a1eed879e55daf960c96acdac514cbda93.1596028601.git.guillaume.tucker@collabora.com> <20200803133439.GB476@kozik-lap> <20200803142244.GO1551@shell.armlinux.org.uk> From: Guillaume Tucker Message-ID: <875ad268-d65c-673e-6f5a-76d48c24f478@collabora.com> Date: Mon, 10 Aug 2020 13:25:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200803142244.GO1551@shell.armlinux.org.uk> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200810_082531_328558_968D6953 X-CRM114-Status: GOOD ( 20.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Kukjin Kim , kernel@collabora.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/08/2020 15:22, Russell King - ARM Linux admin wrote: > On Mon, Aug 03, 2020 at 03:34:39PM +0200, Krzysztof Kozlowski wrote: >> On Wed, Jul 29, 2020 at 02:47:31PM +0100, Guillaume Tucker wrote: >>> The L220_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable >>> sequence. There is no need to set it in the default register value, >>> this was done before support for it was implemented in the code. It >>> is not set in the hardware initial value either. >>> >>> Clean this up by removing this flag from the default l2c_aux_val, and >>> add it to the l2c_aux_mask to print an alert message if it was already >>> set before the kernel initialisation. >>> >>> Signed-off-by: Guillaume Tucker >>> --- >>> arch/arm/mach-exynos/exynos.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Makes sense. I'll take it after the merge window. > > Yes, because platforms actually have no control over this bit through > these values. > > Please fix the description to use the right define, it's > L310_AUX_CTRL_NS_LOCKDOWN not L220_AUX_CTRL_NS_LOCKDOWN. Thanks, fixed in v2. Guilaume _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel