From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0681C43334 for ; Sat, 23 Jul 2022 17:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tO67PapVj32fgJ7j34s4DWISaaAjImKG0vbgnIJpR+0=; b=DThA5swYAhTf1k Z/07MO3NrWl+PRbRy/jQIkNAye90olNbkvz6m8DDharXZ3Tx8RTvWJEVn4NnkofjNxRl01w9RUO4z EiebkDMwfHo8fqhiulNENhJiytYvhUfJKwBwPGUlHvCPncc98GEUkw2qp3GzFDN7347oBPihjbOGs 0hnDMRy8zHEKgXDdiGvJKtmBA8Ng0n7kJG4vF5QAEQzJ4LPxLWFOPvxD498pPFDe0varKgqOYPeZN v5XmRzGeBPVK9xoaEHKc5cOtxm24G6EajyQM0C5gRvkXUPv+ALBgJtpBMolaP2Jd3+lh2GPFcvP4O /RtO4PUG/LGeTun8iNVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oFIzr-0061OU-Cb; Sat, 23 Jul 2022 17:32:59 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oFIzn-0061Kh-2r for linux-arm-kernel@lists.infradead.org; Sat, 23 Jul 2022 17:32:56 +0000 Received: by mail-lj1-x22a.google.com with SMTP id u20so905142ljk.0 for ; Sat, 23 Jul 2022 10:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=x/VzrMn8IRoR/XUw2GaIkz6W+3AiZWGAF5ssto6LX8c=; b=xgtnl3PPZqZRZyGiYh7t2imdcj4sSnzXczgHwKS8ckUS1IUCukpgRcY9SqKF7LynXi puuEHvJ2iLcVMM47QKj/jsDAlUvu6jFI+0TnPjsxr13Q6f/XacJPb9W9jw9RsO7PT1IH oEC8gCBQI+AWCpm8CB+Td3p7FLy0kE+5DwxmEIGZVPxsJsNXW40wnHfokUctKLrqle1h fpsLl/mpXpS/VeinwjnS3wMeSZQ4AWftDqgw81r7BE8hldMpfN/8KhuO+i2O7ZKQWuQX SDyRRcrlO7/ID4hvNtchMJ9vXSBZP/Bvzfq4blcVqaG3glnoFCcbqosqEirGQmTQJwyB SVgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=x/VzrMn8IRoR/XUw2GaIkz6W+3AiZWGAF5ssto6LX8c=; b=lM88EHFg3WYGxLJcjUeYac5sQ8ntq57PUza+VKNTz9c7W6iMoZcD3PUF2Bq4ypwlV0 n0sDrtirkTz2gGbyBO9YPg86eGmAQftLir+1piUGaCqxIRfMt7iEp8m9AOhjB1p3MgDN gmflFIdbr1ff2GgZjCNj9WvXChFYsRtaUvL/lq5wkhmT/cPlhcoiEWL6aph0YrgPjDrG RJIlIsSyzCD00vgck4oiaHhYGhXOmUfk0pIiSb/2qCP1YUWr+NUphzTAY7lOoXdsmjQx urED/I2lxhPg+kkioVaMkSOTahiFHVzTDFSbVpXTnZ4hAScgu1gKzDSLVqdaoRLIkfzS yyWg== X-Gm-Message-State: AJIora/LPBAyXglwx+y2pJR5ak4LSt6q0IZgIyYQ7S2rs9PqIuRBvq2u mniMETl7IvUn4BQwfM7TLSjtarDe8AmXdypj X-Google-Smtp-Source: AGRyM1sEVLBhf0FP/hJuoN3w9Mu0qolkvPJs5Kd7aIL1sOqGbzFi73wXw0ZOQDoqGnNjSehK/o0iPg== X-Received: by 2002:a2e:82c6:0:b0:25d:eef5:8096 with SMTP id n6-20020a2e82c6000000b0025deef58096mr1763269ljh.201.1658597571541; Sat, 23 Jul 2022 10:32:51 -0700 (PDT) Received: from [192.168.10.173] (93.81-167-86.customer.lyse.net. [81.167.86.93]) by smtp.gmail.com with ESMTPSA id u11-20020a056512128b00b004875a37b7b7sm1736514lfs.159.2022.07.23.10.32.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Jul 2022 10:32:51 -0700 (PDT) Message-ID: <875d6856-dea4-e1ff-60b3-706cf00f8bb9@linaro.org> Date: Sat, 23 Jul 2022 19:32:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/3] memory: mtk-smi: Add enable IOMMU SMC command for MM master Content-Language: en-US To: "Chengci.Xu" , Yong Wu , Rob Herring , Matthias Brugger Cc: linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, srv_heupstream@mediatek.com References: <20220723031955.12552-1-chengci.xu@mediatek.com> <20220723031955.12552-3-chengci.xu@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220723031955.12552-3-chengci.xu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220723_103255_137101_651FDA6D X-CRM114-Status: GOOD ( 12.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/07/2022 05:19, Chengci.Xu wrote: Thank you for your patch. There is something to discuss/improve. > #endif > diff --git a/include/soc/mediatek/smi.h b/include/soc/mediatek/smi.h > index 11f7d6b59642..76093b856335 100644 > --- a/include/soc/mediatek/smi.h > +++ b/include/soc/mediatek/smi.h > @@ -8,6 +8,15 @@ > > #include > #include > +#include > +#include The headers do not look like used here. Include only relevant headers. > + > +/* IOMMU & SMI ATF CMD */ > + > +enum IOMMU_ATF_CMD { > + IOMMU_ATF_CMD_CONFIG_SMI_LARB, /* For mm master to en/disable iommu */ > + IOMMU_ATF_CMD_COUNT, > +}; > > #if IS_ENABLED(CONFIG_MTK_SMI) > Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel