From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Rafał Miłecki" <rafal@milecki.pl>,
devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: broadcom: bcm4908: describe USB PHY
Date: Tue, 15 Dec 2020 15:03:44 -0800 [thread overview]
Message-ID: <875dd94c-a405-fa62-365b-d1b0e7d075b8@gmail.com> (raw)
In-Reply-To: <20201215212232.11275-1-zajec5@gmail.com>
On 12/15/20 1:22 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> It's (nearly?) identical PHY as in the STB line and has to be
> initialized the same way.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts | 4 ++++
> arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi | 13 +++++++++++++
> 2 files changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
> index ee3ed612274c..e2bb0b04b524 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
> @@ -26,6 +26,10 @@ wps {
> };
> };
>
> +&usb_phy {
> + brcm,ioc = <1>;
> +};
> +
> &nandcs {
> nand-ecc-strength = <4>;
> nand-ecc-step-size = <512>;
> diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
> index b5b772a9a51b..a96ec9b85d1f 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
> @@ -110,10 +110,21 @@ soc {
> #size-cells = <1>;
> ranges = <0x00 0x00 0x80000000 0x10000>;
>
> + usb_phy: usb-phy@c200 {
> + compatible = "brcm,brcmstb-usb-phy";
It is probably prudent to define a compatible string for the 4908 just
in case we need to key off that chip id within the USB PHY driver. Other
than that, this looks good to me.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
parent reply other threads:[~2020-12-15 23:05 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201215212232.11275-1-zajec5@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875dd94c-a405-fa62-365b-d1b0e7d075b8@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).