From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE9F6C43458 for ; Wed, 8 Jul 2026 10:24:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zSfm6Hy5p1eTVe6xsQSBGh/nMEACx2PFvy9wwc0WZWs=; b=EE6m2uYStom6Hc/NUiZK/TbjTm +SqZ8GIoWHEs6Bw6mnTc0IfBYiqx4V2Zfu6sgjF6sVDeY7fGLfmLfasUGrvNQgzoGvvjOZ9u4rIhX JOn6HgryKHd7UyL8F8O+6BaWV11eG9z+LazkYB43pV4DHgT+J9eF2rVc+ikGJr6tEmQ7I2q26AZPS K5/NkJzmbSJTiFv1yul3cVjXs52l8yrr6FXRz6wKu9VtYebHOoKBt2jN/332aFPr5XSNzBK5VVwzB o8r3CbAjm3tNbyefjk4jEwtBAzY0oeDyPTJbuXW8g5mT7fW5HDZZAQlHsVZhPrZH7hCKM3T+vCVSD 3wPnJ7mA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whPSW-0000000GtnF-3w6q; Wed, 08 Jul 2026 10:24:53 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whPSV-0000000GtmO-20ID for linux-arm-kernel@lists.infradead.org; Wed, 08 Jul 2026 10:24:51 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id D400360008; Wed, 8 Jul 2026 10:24:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 865231F000E9; Wed, 8 Jul 2026 10:24:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783506290; bh=zSfm6Hy5p1eTVe6xsQSBGh/nMEACx2PFvy9wwc0WZWs=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=G0JAAg3caBWmNn7VbMRqrtSqx0vsnaBohbRYhqIF01Ze+7Tu3O4U4Yh6SvRdLLr7c xwlt8dvvlhbjGPXb/Iy1w6lA1pGirhTQ1r4BVCN2DCivqL7qyqxpMeDyX4es/SxolR IrRBdi6v8787TOSi5835bwAOTupvDffYUUOet0N69h1OBiK8w+lG2sPyIlNQg4PQyV As/0jZ/sSEYvkHfw9cu5saTG0m8v2aIjqJFFoEJFkY2r29CCSYfqIfvqioymRklZFy I+BBbccSOEOaX6WR0tlY1V8weC4cxVXZW4YIWo4em2eZytAXrbgih+lJckXHioJrfs 4SZPOFW249CWA== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1whPSS-00000002m0e-0dnB; Wed, 08 Jul 2026 10:24:48 +0000 Date: Wed, 08 Jul 2026 11:26:37 +0100 Message-ID: <875x2p7p5u.wl-maz@kernel.org> From: Marc Zyngier To: Bjoern Doebel Cc: , Thomas Gleixner , , , David Woodhouse , "Ali\ Saidi" , David Arinzon , "Zeev\ Zilberman" Subject: Re: [PATCH] irqchip/gic-v3-its: Reconfigure ITS from software state on resume In-Reply-To: References: <20260507183102.1897629-1-doebel@amazon.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: doebel@amazon.de, stable@vger.kernel.org, tglx@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dwmw@amazon.co.uk, alisaidi@amazon.com, darinzon@amazon.com, zeev@amazon.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 02 Jul 2026 12:57:15 +0100, Bjoern Doebel wrote: > > Hi all, > > gentle ping on this one. > > Since the original posting I've re-validated the fix against current > mainline: > > - It still applies cleanly to v7.2-rc1 (and to v7.1.0). > > - I reproduced the original failure on *stock* v7.2-rc1. On EC2 > Graviton instances, hibernation resume fails 100% of the time: the > ITS comes back reset, MAPD/MAPTI are never replayed, and the ENA > NIC silently loses its LPIs: > > ena 0000:00:05.0: ... didn't receive a MSI-X interrupt (cmd 3) > ena 0000:00:05.0: Failed to create IO CQ. error: -62 > But how did the resumed kernel get there the first place? Surely you had interrupts to load it, right? > The instance then has no networking after resume. > > - With this patch applied, the same kernel survives hibernate/resume > cleanly: 9/9 cycles with zero failures, across all three Graviton > generations (Graviton 2/3/4, i.e. Neoverse N1/V1/V2), networking > fully restored on every resume. > > As described in the previous message, this is the fallout from 713335b6ee29 > ("irqchip/gic-v3-its: Implement .msi_teardown() callback"): device > teardown no longer happens across a suspend/resume that keeps the MSI > domain, so the ITS is never reprogrammed and drops interrupts after the > hardware has been reset. > > Could you take a look when you get a chance? What I don't immediately see is how this particular patch influences anything, given that at this point it isn't doing anything. Beside that, how does hibernation actually influences LPIs being released? Can you at least describe the sequence of events? The other thing that worries me is that in general, (bare metal) GICv3 is unable to deal with hibernation, given that you can't reprogram the property and pending table addresses. Yes, it *may* work if you are lucky enough that the boot kernel and the resumed one use the same memory regions, but this only show that you like playing Russian roulette. Thanks, M. -- Jazz isn't dead. It just smells funny.