From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95D17107BCF2 for ; Wed, 18 Mar 2026 10:40:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MTpDYX+upBLp9SRW+OziKTrzB+mfPMcb5cpom+85poA=; b=Uyd3ovWjfZWBrkQAcThj1S62So MMpE+Zy08cL0W/G7oL88cBCKq5PIq9xzfFcxrBfvZWz+ck1Ig8HON1Nd892hfoFax+iZiwaDJ9GTp rnxBMO5m/js46oCaT6yKpuOYA2hs6gwvHAm+Y1qGrNMekkvL7qpJLK5AG3EryKsiLIPmnSNm9lw7A Rr6Me2UQcgThW0KgIRB7ZpTJHykB8t024cFGP0LLbiLLrw/0ebI96n1HBEWAM+pCQ6KG6rusW8GZx VWhdvG7r2IEa3pw8sYTWEv4/Yqbl58zR4RzS6x6jdiFA+kk2Eb/oM5HkcCcxX4G6/rVRrYqZe88ya kinYDODA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w2oKW-00000008Drh-3xjJ; Wed, 18 Mar 2026 10:40:48 +0000 Received: from smtpout-03.galae.net ([185.246.85.4]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w2oKT-00000008DrK-3LU7 for linux-arm-kernel@lists.infradead.org; Wed, 18 Mar 2026 10:40:48 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 0CCB34E426DE; Wed, 18 Mar 2026 10:40:42 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B8AD86004F; Wed, 18 Mar 2026 10:40:41 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 76FE710450640; Wed, 18 Mar 2026 11:40:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1773830441; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=MTpDYX+upBLp9SRW+OziKTrzB+mfPMcb5cpom+85poA=; b=Xl8kAqorr9x26xPNdldYAncL7sNq+jQvTPr/yiNg5ZUPkUOs2+PKu2dX/uagdKQfulmjN/ 2+MhpkqlwGI9vR86BRpHp10uLJJlWNQ+ylat5Djjw10mG2zP4PjBi95CS2oX+T5gGn57jG DttZzB3s6kjF99hmQ+LWweczKSJs02TzIMSGpvWModpi7mcbvFaAYxtJ/1+NMvIlqQOo2C cxW3iCiA6vwYeWCkzePysalM7tCv5Y2X61Gedku3xnN1glWj1lZ6xZqCATgYkwu5G+zkPs aVtGbiP/Tib1oluIGzRklUcYePBpnX3YC1cq69W4L+1EOnDdr6Sjj9tMed523A== From: Gregory CLEMENT To: Gabor Juhos , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?utf-8?Q?Miqu=C3=A8l?= Raynal Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos Subject: Re: [PATCH v2] arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' from USB host nodes In-Reply-To: <20260317-armada-37xx-drop-usb-misc-reg-v2-1-ddff72114414@gmail.com> References: <20260317-armada-37xx-drop-usb-misc-reg-v2-1-ddff72114414@gmail.com> Date: Wed, 18 Mar 2026 11:40:37 +0100 Message-ID: <875x6t5ska.fsf@BLaptop.bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260318_034046_336057_B9C542AE X-CRM114-Status: GOOD ( 22.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org +Miqu=C3=A8l Hello Gabor, Thanks it is better, > The 'marvell,usb-misc-reg' property is present both in the EHCI and > in the XHCI USB host device nodes, however it is not documented. Thus > 'make dtbs_check' produces warnings like these: > > /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@58000 (marvell,arm= ada3700-xhci): Unevaluated properties are not allowed ('marvell,usb-misc-re= g' was unexpected) > from schema $id: http://devicetree.org/schemas/usb/generic-xhci= .yaml > /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@5e000 (marvell,arm= ada-3700-ehci): Unevaluated properties are not allowed ('marvell,usb-misc-r= eg' was unexpected) > from schema $id: http://devicetree.org/schemas/usb/generic-ehci= .yaml > > Apart from the fact that the properties are not documented, those are > not even used by any USB host drivers. Due to this, drop the properties > in order to get rid of the warnings. > > Note: > > With the same name, there is a property used for the Armada 3700 USB > UTMI PHYs of which dt-bindings documentation has been added in commit > e60958699afa ("dt-bindings: phy: mvebu-utmi: add UTMI PHY bindings"). > > Additionally, the property is handled by the 'phy-mvebu-a3700-utmi' > driver since commit cc8b7a0ae866 ("phy: add A3700 UTMI PHY driver"). > > When the nodes of the UTMI PHYs has been added to the SoC dtsi by > commit 05d168a56fae ("arm64: dts: marvell: armada-37xx: declare USB2 > UTMI PHYs"), the properties has been added to the USB host controller > nodes also. According to the commit message this was intentional, Miquel will confirm that, after speaking with him, it appears to be a mistake rather than an intentional act. Gr=C3=A9gory > however in regard to the USB hosts, neither the respective documentation, > nor driver support has been added into the tree since that. > > Reviewed-by: Andrew Lunn > Signed-off-by: Gabor Juhos > --- > Changes in v2: > - add Reviewed-by tag from Andrew > - change subject and reword commit message > - Link to v1: https://lore.kernel.org/r/20260304-armada-37xx-drop-usb-m= isc-reg-v1-1-800c1b746b7a@gmail.com > --- > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/bo= ot/dts/marvell/armada-37xx.dtsi > index ea1824f5321fbb32fc4373c08a0d94bca1dc793b..44c47409f8793ae1266303607= 812ef481edbfbc5 100644 > --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > @@ -369,7 +369,6 @@ usb3: usb@58000 { > compatible =3D "marvell,armada3700-xhci", > "generic-xhci"; > reg =3D <0x58000 0x4000>; > - marvell,usb-misc-reg =3D <&usb32_syscon>; > interrupts =3D ; > clocks =3D <&sb_periph_clk 12>; > phys =3D <&comphy0 0>, <&usb2_utmi_otg_phy>; > @@ -393,7 +392,6 @@ usb32_syscon: system-controller@5d800 { > usb2: usb@5e000 { > compatible =3D "marvell,armada-3700-ehci"; > reg =3D <0x5e000 0x1000>; > - marvell,usb-misc-reg =3D <&usb2_syscon>; > interrupts =3D ; > phys =3D <&usb2_utmi_host_phy>; > phy-names =3D "usb"; > > --- > base-commit: 98226a594f313442fcba38cefc1df0b6c1691c7e > change-id: 20260304-armada-37xx-drop-usb-misc-reg-e9635498cae6 > > Best regards, > --=20 > Gabor Juhos > --=20 Gr=C3=A9gory CLEMENT, Bootlin Embedded Linux and Kernel engineering https://bootlin.com