From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5814C0218B for ; Thu, 23 Jan 2025 15:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EFR6JY8J8m1z5CQx7aJ0aewuTPA3EJR90G+iLmo6XgQ=; b=QTWX8Zq1IQdA7VsMl3Uu8ydCmT GXJz0cR2BEnMAOLg0tCiCt1WtTELH1XJFgJ669YI+BxaIZ4Cdc3TkieOkCUDXWkw4KozbEGTk0c1X LzX06OQ7tgO+NpwiDlOwb/L5nZWMF+hX4xwg7SsKHF09Ci31iuAHw9r+9bnIZBkajfyxpsxhIqzcj 9zQiKcgUQ0AwGeNLNRQxgxjgxxxyglStoP/Kl0jOgpwspP9IWoayTN4mOyy0d+yjLE5OtX7daa6m/ hCZm7xXolpLF65jyWDFmekqQYEPRcfmRKkWdTVT251RMoNqXA7rsTgIijQzvHJFSZpKTfRd3/WeHA eMyoiKUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tayuh-0000000Cgbu-1xkI; Thu, 23 Jan 2025 15:14:35 +0000 Received: from mgamail.intel.com ([198.175.65.11]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1taytO-0000000CgTt-3vpL; Thu, 23 Jan 2025 15:13:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737645195; x=1769181195; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=PJ7aYCbtXYZu+NJO1JN2by/s67/mM6chwppH2LXXzu4=; b=Oj8HRSQ3JKt9aq/VC+jaeYsJ9uAGfuuEuSvcpZHsx3WaWwGBTB3uFD7w ds4Qqbe0FXyE9FKPDS0tUH0KwXpFct3GoeLsdPVPxmd9QYY6ExZf8CpXK IQIw2zXILMfx679oDt9yQ/AT/xn3sYHmy1AjebVIfyqgM0wwSg63M5O2y 7qcyMUJIEhStGOV5scTOnHTyHQ89KEnO/f1zBNPcJFfCVuQfTb1jm57zB W2QodRwTlg7VDlPBgw94bJhSFMMKGeLHR7EkqDKZd7zL5wt9IjPe8nyxS 5R7VW784BKHidfRdVRJ9OYZY6fRtjSDqPd68p0Ul1hgJ+kDOSfejcscSO g==; X-CSE-ConnectionGUID: lP/wuiDdStqff8wh6Kislg== X-CSE-MsgGUID: o8++i65CSrOhkeX83zJyZw== X-IronPort-AV: E=McAfee;i="6700,10204,11324"; a="48645065" X-IronPort-AV: E=Sophos;i="6.13,228,1732608000"; d="scan'208";a="48645065" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2025 07:12:41 -0800 X-CSE-ConnectionGUID: iA8pr0lGR2G7SnmEsAU9RQ== X-CSE-MsgGUID: pnYUQ/TcQBKbHiLGBBM+LQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,228,1732608000"; d="scan'208";a="107299297" Received: from unknown (HELO localhost) ([10.237.66.160]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2025 07:12:34 -0800 From: Jani Nikula To: Damon Ding , heiko@sntech.de Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rfoss@kernel.org, vkoul@kernel.org, sebastian.reichel@collabora.com, cristian.ciocaltea@collabora.com, l.stach@pengutronix.de, dmitry.baryshkov@linaro.org, andy.yan@rock-chips.com, hjc@rock-chips.com, algea.cao@rock-chips.com, kever.yang@rock-chips.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Damon Ding Subject: Re: [PATCH v6 01/14] drm/rockchip: analogix_dp: Replace DRM_...() functions with drm_...() In-Reply-To: <87ikq5n2di.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250123100747.1841357-1-damon.ding@rock-chips.com> <20250123100747.1841357-2-damon.ding@rock-chips.com> <87ikq5n2di.fsf@intel.com> Date: Thu, 23 Jan 2025 17:12:31 +0200 Message-ID: <875xm5mun4.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250123_071315_021133_45430946 X-CRM114-Status: GOOD ( 12.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 23 Jan 2025, Jani Nikula wrote: > On Thu, 23 Jan 2025, Damon Ding wrote: >> According to the comments in include/drm/drm_print.h, the DRM_...() >> functions are deprecated in favor of drm_...() or dev_...() functions. >> >> Use drm_err()/drm_dbg_core()/drm_dbg_kms() instead of >> DRM_DEV_ERROR()/DRM_ERROR()/DRM_DEV_DEBUG()/DRM_DEBUG_KMS(). >> >> Signed-off-by: Damon Ding >> >> --- >> >> Changes in v6: >> - Use drm_...() uniformly rather than mixing drm_...() and dev_..() >> - Pass 'dp' in drm_...() rather than 'dp->drm_dev' >> --- >> .../gpu/drm/rockchip/analogix_dp-rockchip.c | 29 ++++++++++--------- >> 1 file changed, 15 insertions(+), 14 deletions(-) >> >> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> index 0844175c37c5..dd33d7540e4b 100644 >> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> @@ -100,13 +100,13 @@ static int rockchip_dp_poweron(struct analogix_dp_plat_data *plat_data) >> >> ret = clk_prepare_enable(dp->pclk); >> if (ret < 0) { >> - DRM_DEV_ERROR(dp->dev, "failed to enable pclk %d\n", ret); >> + drm_err(dp, "failed to enable pclk %d\n", ret); > > Please don't do this. > > You're supposed to pass struct drm_device to drm_err() and friends. Not > some random struct pointer that just happens to have a ->dev member. > > The drm_* macros may change at any time to actually expect the correct > type. And with [1] I'm hoping "at any time" becomes "real soon now". BR, Jani. [1] https://lore.kernel.org/all/cover.1737644530.git.jani.nikula@intel.com -- Jani Nikula, Intel